RE: [Xen-ia64-devel] [PATCH] Cleanup to irq.c
From: Tristan Gingold [mailto:[EMAIL PROTECTED] Sent: 2006年4月11日 19:33 Le Mardi 11 Avril 2006 13:15, Tian, Kevin a écrit : This patch is a big cleanup to irq.c, with only real necessary interfaces kept now. The irq subsystem of xen is very simple since most external devices are controlled by dom0. Also especially there's no need to keep CONFIG_XEN everywhere, since this file is already out of sync of linux version for a long time. Actually xen defines irq related structures differently and it's worthy of creating a xen specific version here. Good cleanup. Maybe we could also merge irq.c and xenirq.c ? Here it comes. Alex, please apply this one on top of previous clean_irq.patch. Remove xenirq.c. Signed-off-by Kevin Tian [EMAIL PROTECTED] Thanks, Kevin remove_xenirq.patch Description: remove_xenirq.patch ___ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel
RE: [Xen-ia64-devel] [PATCH] Cleanup to irq.c
BTW, one confusing point here is serial_input_init() which hard coded a vector (0x30), which happens to conflict with eth0 vector on my tiger box. What's the purpose of this registration? Actually the registration here is bogus which never severs the purpose. Before my patch, previous logic simply injects that vector (0x30) into guest since it's not timer/ipi. Even xen wants to handle this vector, the hw_interrupt_type assocated with this vector is no_irq_type which is also bogus. Since it doesn't work as the code wants, I simply disabled the serial_input_init to avoid unnecessary warnings like Unexpected irq vector 0x30 on cpu 0. Never understood its purpose! Tristan. Hardcoding 0x30 for keyboard input is very old code that goes back to vBlades. It's possible that it is necessary for running Xen on ski... I'm not sure. Dan ___ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel
