Re: [Xen-ia64-devel] [PATCH] sparse tree cleanups

2006-06-09 Thread Akio Takebe
Hi, Alex

   Without seeing the changes, it's hard to say.  What I mean by simple
checks are that it cannot call functions or declare variables that are
only defined in CONFIG_XEN code.  It's minor cleanup that you may not be
able to use.  Thanks,
OK, I understand it.
And I wanted to cleanup xenpage in linux-2.6-sparse/mm/memory.c
But this xenpage isn't already used.
So I simply remove it.
I'll post this patch with another mail.

Best Regards,

Akio Takebe

On Wed, 2006-06-07 at 15:08 +0900, Akio Takebe wrote:
 Hi, Alex
 
 I agree your suggestion.
 But your patch use ifdef CONFIG_XEN.
 You say we use simple is_running_on_xen() checks, aren't you?
 Is this mistake? or do I mis-understand?
 
 I want to clean up mm/memory.c.
 (This work is for cleanup fedora-xen's warning.)
 I should use is_running_on_xen() in mm/memory.c, shouldn't I?

Hi Akio,

   Without seeing the changes, it's hard to say.  What I mean by simple
checks are that it cannot call functions or declare variables that are
only defined in CONFIG_XEN code.  It's minor cleanup that you may not be
able to use.  Thanks,

   Alex

-- 
Alex Williamson HP Open Source  Linux Org.



___
Xen-ia64-devel mailing list
Xen-ia64-devel@lists.xensource.com
http://lists.xensource.com/xen-ia64-devel


Re: [Xen-ia64-devel] [PATCH] sparse tree cleanups

2006-06-07 Thread Alex Williamson
On Wed, 2006-06-07 at 15:08 +0900, Akio Takebe wrote:
 Hi, Alex
 
 I agree your suggestion.
 But your patch use ifdef CONFIG_XEN.
 You say we use simple is_running_on_xen() checks, aren't you?
 Is this mistake? or do I mis-understand?
 
 I want to clean up mm/memory.c.
 (This work is for cleanup fedora-xen's warning.)
 I should use is_running_on_xen() in mm/memory.c, shouldn't I?

Hi Akio,

   Without seeing the changes, it's hard to say.  What I mean by simple
checks are that it cannot call functions or declare variables that are
only defined in CONFIG_XEN code.  It's minor cleanup that you may not be
able to use.  Thanks,

Alex

-- 
Alex Williamson HP Open Source  Linux Org.


___
Xen-ia64-devel mailing list
Xen-ia64-devel@lists.xensource.com
http://lists.xensource.com/xen-ia64-devel