[Xenomai-git] Philippe Gerum : net: wire up corectl interface
Module: xenomai-3 Branch: stable-3.0.x Commit: 1b55d73cfa3cc9de1b1e76d30ee36ed973ef4934 URL: http://git.xenomai.org/?p=xenomai-3.git;a=commit;h=1b55d73cfa3cc9de1b1e76d30ee36ed973ef4934 Author: Philippe GerumDate: Mon Dec 4 16:52:24 2017 +0100 net: wire up corectl interface A bug in some Makefile rule caused the corectl support to be wrongly omitted from the object list for building rtnet.ko. As a consequence of this, there is no way the smokey-based RTnet testsuite could have ever worked. Wire up the corectl handler to the Cobalt core as expected. --- kernel/drivers/net/stack/Makefile |3 +-- kernel/drivers/net/stack/corectl.c |9 ++--- kernel/drivers/net/stack/rtnet_module.c |6 ++ 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/kernel/drivers/net/stack/Makefile b/kernel/drivers/net/stack/Makefile index 508d487..d055dc2 100644 --- a/kernel/drivers/net/stack/Makefile +++ b/kernel/drivers/net/stack/Makefile @@ -1,7 +1,5 @@ ccflags-y += -Idrivers/xenomai/net/stack/include -Ikernel/ -obj-y += corectl.o - obj-$(CONFIG_XENO_DRIVERS_NET_RTIPV4) += ipv4/ obj-$(CONFIG_XENO_DRIVERS_NET_RTPACKET) += packet/ @@ -13,6 +11,7 @@ obj-$(CONFIG_XENO_DRIVERS_NET_RTCFG) += rtcfg/ obj-$(CONFIG_XENO_DRIVERS_NET) += rtnet.o rtnet-y := \ + corectl.o \ iovec.o \ rtdev.o \ rtdev_mgr.o \ diff --git a/kernel/drivers/net/stack/corectl.c b/kernel/drivers/net/stack/corectl.c index 2f6f179..c8a9a12 100644 --- a/kernel/drivers/net/stack/corectl.c +++ b/kernel/drivers/net/stack/corectl.c @@ -66,9 +66,12 @@ static struct notifier_block rtnet_corectl_notifier = { .notifier_call = rtnet_corectl_call, }; -static int rtnet_corectl_register(void) +void rtnet_corectl_register(void) { cobalt_add_config_chain(_corectl_notifier); - return 0; } -device_initcall(rtnet_corectl_register); + +void rtnet_corectl_unregister(void) +{ + cobalt_remove_config_chain(_corectl_notifier); +} diff --git a/kernel/drivers/net/stack/rtnet_module.c b/kernel/drivers/net/stack/rtnet_module.c index 1e42558..63ad558 100644 --- a/kernel/drivers/net/stack/rtnet_module.c +++ b/kernel/drivers/net/stack/rtnet_module.c @@ -50,6 +50,8 @@ const char rtnet_rtdm_provider_name[] = EXPORT_SYMBOL_GPL(rtnet_rtdm_provider_name); +void rtnet_corectl_register(void); +void rtnet_corectl_unregister(void); #ifdef CONFIG_XENO_OPT_VFILE /*** @@ -345,6 +347,8 @@ int __init rtnet_init(void) if ((err = rtpc_init()) != 0) goto err_out6; +rtnet_corectl_register(); + return 0; @@ -376,6 +380,8 @@ err_out1: */ void __exit rtnet_release(void) { +rtnet_corectl_unregister(); + rtpc_cleanup(); rtwlan_exit(); ___ Xenomai-git mailing list Xenomai-git@xenomai.org https://xenomai.org/mailman/listinfo/xenomai-git
[Xenomai-git] Philippe Gerum : net: wire up corectl interface
Module: xenomai-3 Branch: wip/rtnet-fixes Commit: 121a66577de900882317759d95b5f52a4aeb7e61 URL: http://git.xenomai.org/?p=xenomai-3.git;a=commit;h=121a66577de900882317759d95b5f52a4aeb7e61 Author: Philippe GerumDate: Mon Dec 4 16:52:24 2017 +0100 net: wire up corectl interface A bug in some Makefile rule caused the corectl support to be wrongly omitted from the object list for building rtnet.ko. As a consequence of this, there is no way the smokey-based RTnet testsuite could have ever worked. Wire up the corectl handler to the Cobalt core as expected. --- kernel/drivers/net/stack/Makefile |3 +-- kernel/drivers/net/stack/corectl.c |9 ++--- kernel/drivers/net/stack/rtnet_module.c |6 ++ 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/kernel/drivers/net/stack/Makefile b/kernel/drivers/net/stack/Makefile index 508d487..d055dc2 100644 --- a/kernel/drivers/net/stack/Makefile +++ b/kernel/drivers/net/stack/Makefile @@ -1,7 +1,5 @@ ccflags-y += -Idrivers/xenomai/net/stack/include -Ikernel/ -obj-y += corectl.o - obj-$(CONFIG_XENO_DRIVERS_NET_RTIPV4) += ipv4/ obj-$(CONFIG_XENO_DRIVERS_NET_RTPACKET) += packet/ @@ -13,6 +11,7 @@ obj-$(CONFIG_XENO_DRIVERS_NET_RTCFG) += rtcfg/ obj-$(CONFIG_XENO_DRIVERS_NET) += rtnet.o rtnet-y := \ + corectl.o \ iovec.o \ rtdev.o \ rtdev_mgr.o \ diff --git a/kernel/drivers/net/stack/corectl.c b/kernel/drivers/net/stack/corectl.c index 2f6f179..c8a9a12 100644 --- a/kernel/drivers/net/stack/corectl.c +++ b/kernel/drivers/net/stack/corectl.c @@ -66,9 +66,12 @@ static struct notifier_block rtnet_corectl_notifier = { .notifier_call = rtnet_corectl_call, }; -static int rtnet_corectl_register(void) +void rtnet_corectl_register(void) { cobalt_add_config_chain(_corectl_notifier); - return 0; } -device_initcall(rtnet_corectl_register); + +void rtnet_corectl_unregister(void) +{ + cobalt_remove_config_chain(_corectl_notifier); +} diff --git a/kernel/drivers/net/stack/rtnet_module.c b/kernel/drivers/net/stack/rtnet_module.c index 1e42558..63ad558 100644 --- a/kernel/drivers/net/stack/rtnet_module.c +++ b/kernel/drivers/net/stack/rtnet_module.c @@ -50,6 +50,8 @@ const char rtnet_rtdm_provider_name[] = EXPORT_SYMBOL_GPL(rtnet_rtdm_provider_name); +void rtnet_corectl_register(void); +void rtnet_corectl_unregister(void); #ifdef CONFIG_XENO_OPT_VFILE /*** @@ -345,6 +347,8 @@ int __init rtnet_init(void) if ((err = rtpc_init()) != 0) goto err_out6; +rtnet_corectl_register(); + return 0; @@ -376,6 +380,8 @@ err_out1: */ void __exit rtnet_release(void) { +rtnet_corectl_unregister(); + rtpc_cleanup(); rtwlan_exit(); ___ Xenomai-git mailing list Xenomai-git@xenomai.org https://xenomai.org/mailman/listinfo/xenomai-git
[Xenomai-git] Philippe Gerum : net: wire up corectl interface
Module: xenomai-3 Branch: next Commit: e442e8fd2862eb48100d3757c69fad45543b6007 URL: http://git.xenomai.org/?p=xenomai-3.git;a=commit;h=e442e8fd2862eb48100d3757c69fad45543b6007 Author: Philippe GerumDate: Mon Dec 4 16:52:24 2017 +0100 net: wire up corectl interface A bug in some Makefile rule caused the corectl support to be wrongly omitted from the object list for building rtnet.ko. As a consequence of this, there is no way the smokey-based RTnet testsuite could have ever worked. Wire up the corectl handler to the Cobalt core as expected. --- kernel/drivers/net/stack/Makefile |3 +-- kernel/drivers/net/stack/corectl.c |9 ++--- kernel/drivers/net/stack/rtnet_module.c |6 ++ 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/kernel/drivers/net/stack/Makefile b/kernel/drivers/net/stack/Makefile index 508d487..d055dc2 100644 --- a/kernel/drivers/net/stack/Makefile +++ b/kernel/drivers/net/stack/Makefile @@ -1,7 +1,5 @@ ccflags-y += -Idrivers/xenomai/net/stack/include -Ikernel/ -obj-y += corectl.o - obj-$(CONFIG_XENO_DRIVERS_NET_RTIPV4) += ipv4/ obj-$(CONFIG_XENO_DRIVERS_NET_RTPACKET) += packet/ @@ -13,6 +11,7 @@ obj-$(CONFIG_XENO_DRIVERS_NET_RTCFG) += rtcfg/ obj-$(CONFIG_XENO_DRIVERS_NET) += rtnet.o rtnet-y := \ + corectl.o \ iovec.o \ rtdev.o \ rtdev_mgr.o \ diff --git a/kernel/drivers/net/stack/corectl.c b/kernel/drivers/net/stack/corectl.c index 2f6f179..c8a9a12 100644 --- a/kernel/drivers/net/stack/corectl.c +++ b/kernel/drivers/net/stack/corectl.c @@ -66,9 +66,12 @@ static struct notifier_block rtnet_corectl_notifier = { .notifier_call = rtnet_corectl_call, }; -static int rtnet_corectl_register(void) +void rtnet_corectl_register(void) { cobalt_add_config_chain(_corectl_notifier); - return 0; } -device_initcall(rtnet_corectl_register); + +void rtnet_corectl_unregister(void) +{ + cobalt_remove_config_chain(_corectl_notifier); +} diff --git a/kernel/drivers/net/stack/rtnet_module.c b/kernel/drivers/net/stack/rtnet_module.c index 1e42558..63ad558 100644 --- a/kernel/drivers/net/stack/rtnet_module.c +++ b/kernel/drivers/net/stack/rtnet_module.c @@ -50,6 +50,8 @@ const char rtnet_rtdm_provider_name[] = EXPORT_SYMBOL_GPL(rtnet_rtdm_provider_name); +void rtnet_corectl_register(void); +void rtnet_corectl_unregister(void); #ifdef CONFIG_XENO_OPT_VFILE /*** @@ -345,6 +347,8 @@ int __init rtnet_init(void) if ((err = rtpc_init()) != 0) goto err_out6; +rtnet_corectl_register(); + return 0; @@ -376,6 +380,8 @@ err_out1: */ void __exit rtnet_release(void) { +rtnet_corectl_unregister(); + rtpc_cleanup(); rtwlan_exit(); ___ Xenomai-git mailing list Xenomai-git@xenomai.org https://xenomai.org/mailman/listinfo/xenomai-git
[Xenomai-git] Philippe Gerum : net: wire up corectl interface
Module: xenomai-3 Branch: next Commit: 1456d168c6b10116a9c72a641bcf0d3c2d6588c6 URL: http://git.xenomai.org/?p=xenomai-3.git;a=commit;h=1456d168c6b10116a9c72a641bcf0d3c2d6588c6 Author: Philippe GerumDate: Mon Dec 4 16:52:24 2017 +0100 net: wire up corectl interface A bug in some Makefile rule caused the corectl support to be wrongly omitted from the object list for building rtnet.ko. As a consequence of this, there is no way the smokey-based RTnet testsuite could have ever worked. Wire up the corectl handler to the Cobalt core as expected. --- kernel/drivers/net/stack/Makefile |3 +-- kernel/drivers/net/stack/corectl.c |9 ++--- kernel/drivers/net/stack/rtnet_module.c |6 ++ 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/kernel/drivers/net/stack/Makefile b/kernel/drivers/net/stack/Makefile index 508d487..d055dc2 100644 --- a/kernel/drivers/net/stack/Makefile +++ b/kernel/drivers/net/stack/Makefile @@ -1,7 +1,5 @@ ccflags-y += -Idrivers/xenomai/net/stack/include -Ikernel/ -obj-y += corectl.o - obj-$(CONFIG_XENO_DRIVERS_NET_RTIPV4) += ipv4/ obj-$(CONFIG_XENO_DRIVERS_NET_RTPACKET) += packet/ @@ -13,6 +11,7 @@ obj-$(CONFIG_XENO_DRIVERS_NET_RTCFG) += rtcfg/ obj-$(CONFIG_XENO_DRIVERS_NET) += rtnet.o rtnet-y := \ + corectl.o \ iovec.o \ rtdev.o \ rtdev_mgr.o \ diff --git a/kernel/drivers/net/stack/corectl.c b/kernel/drivers/net/stack/corectl.c index 2f6f179..c8a9a12 100644 --- a/kernel/drivers/net/stack/corectl.c +++ b/kernel/drivers/net/stack/corectl.c @@ -66,9 +66,12 @@ static struct notifier_block rtnet_corectl_notifier = { .notifier_call = rtnet_corectl_call, }; -static int rtnet_corectl_register(void) +void rtnet_corectl_register(void) { cobalt_add_config_chain(_corectl_notifier); - return 0; } -device_initcall(rtnet_corectl_register); + +void rtnet_corectl_unregister(void) +{ + cobalt_remove_config_chain(_corectl_notifier); +} diff --git a/kernel/drivers/net/stack/rtnet_module.c b/kernel/drivers/net/stack/rtnet_module.c index 1e42558..63ad558 100644 --- a/kernel/drivers/net/stack/rtnet_module.c +++ b/kernel/drivers/net/stack/rtnet_module.c @@ -50,6 +50,8 @@ const char rtnet_rtdm_provider_name[] = EXPORT_SYMBOL_GPL(rtnet_rtdm_provider_name); +void rtnet_corectl_register(void); +void rtnet_corectl_unregister(void); #ifdef CONFIG_XENO_OPT_VFILE /*** @@ -345,6 +347,8 @@ int __init rtnet_init(void) if ((err = rtpc_init()) != 0) goto err_out6; +rtnet_corectl_register(); + return 0; @@ -376,6 +380,8 @@ err_out1: */ void __exit rtnet_release(void) { +rtnet_corectl_unregister(); + rtpc_cleanup(); rtwlan_exit(); ___ Xenomai-git mailing list Xenomai-git@xenomai.org https://xenomai.org/mailman/listinfo/xenomai-git
[Xenomai-git] Philippe Gerum : net: wire up corectl interface
Module: xenomai-3 Branch: next Commit: fd6d1ef285e7f6eb81d70a3a2c65612e4b98dcb6 URL: http://git.xenomai.org/?p=xenomai-3.git;a=commit;h=fd6d1ef285e7f6eb81d70a3a2c65612e4b98dcb6 Author: Philippe GerumDate: Mon Dec 4 16:52:24 2017 +0100 net: wire up corectl interface A bug in some Makefile rule caused the corectl support to be wrongly omitted from the object list for building rtnet.ko. As a consequence of this, there is no way the smokey-based RTnet testsuite could have ever worked. Wire up the corectl handler to the Cobalt core as expected. --- kernel/drivers/net/stack/Makefile |3 +-- kernel/drivers/net/stack/corectl.c |9 ++--- kernel/drivers/net/stack/rtnet_module.c |6 ++ 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/kernel/drivers/net/stack/Makefile b/kernel/drivers/net/stack/Makefile index 508d487..d055dc2 100644 --- a/kernel/drivers/net/stack/Makefile +++ b/kernel/drivers/net/stack/Makefile @@ -1,7 +1,5 @@ ccflags-y += -Idrivers/xenomai/net/stack/include -Ikernel/ -obj-y += corectl.o - obj-$(CONFIG_XENO_DRIVERS_NET_RTIPV4) += ipv4/ obj-$(CONFIG_XENO_DRIVERS_NET_RTPACKET) += packet/ @@ -13,6 +11,7 @@ obj-$(CONFIG_XENO_DRIVERS_NET_RTCFG) += rtcfg/ obj-$(CONFIG_XENO_DRIVERS_NET) += rtnet.o rtnet-y := \ + corectl.o \ iovec.o \ rtdev.o \ rtdev_mgr.o \ diff --git a/kernel/drivers/net/stack/corectl.c b/kernel/drivers/net/stack/corectl.c index 2f6f179..c8a9a12 100644 --- a/kernel/drivers/net/stack/corectl.c +++ b/kernel/drivers/net/stack/corectl.c @@ -66,9 +66,12 @@ static struct notifier_block rtnet_corectl_notifier = { .notifier_call = rtnet_corectl_call, }; -static int rtnet_corectl_register(void) +void rtnet_corectl_register(void) { cobalt_add_config_chain(_corectl_notifier); - return 0; } -device_initcall(rtnet_corectl_register); + +void rtnet_corectl_unregister(void) +{ + cobalt_remove_config_chain(_corectl_notifier); +} diff --git a/kernel/drivers/net/stack/rtnet_module.c b/kernel/drivers/net/stack/rtnet_module.c index 1e42558..63ad558 100644 --- a/kernel/drivers/net/stack/rtnet_module.c +++ b/kernel/drivers/net/stack/rtnet_module.c @@ -50,6 +50,8 @@ const char rtnet_rtdm_provider_name[] = EXPORT_SYMBOL_GPL(rtnet_rtdm_provider_name); +void rtnet_corectl_register(void); +void rtnet_corectl_unregister(void); #ifdef CONFIG_XENO_OPT_VFILE /*** @@ -345,6 +347,8 @@ int __init rtnet_init(void) if ((err = rtpc_init()) != 0) goto err_out6; +rtnet_corectl_register(); + return 0; @@ -376,6 +380,8 @@ err_out1: */ void __exit rtnet_release(void) { +rtnet_corectl_unregister(); + rtpc_cleanup(); rtwlan_exit(); ___ Xenomai-git mailing list Xenomai-git@xenomai.org https://xenomai.org/mailman/listinfo/xenomai-git
[Xenomai-git] Philippe Gerum : net: wire up corectl interface
Module: xenomai-3 Branch: wip/rtnet-fixes Commit: 33a8bcb38b06ff31fe38fa96af5c5619edd82a02 URL: http://git.xenomai.org/?p=xenomai-3.git;a=commit;h=33a8bcb38b06ff31fe38fa96af5c5619edd82a02 Author: Philippe GerumDate: Mon Dec 4 16:52:24 2017 +0100 net: wire up corectl interface A bug in some Makefile rule caused the corectl support to be wrongly omitted from the object list for building rtnet.ko. As a consequence of this, there is no way the smokey-based RTnet testsuite could have ever worked. Wire up the corectl handler to the Cobalt core as expected. --- kernel/drivers/net/stack/Makefile |3 +-- kernel/drivers/net/stack/corectl.c |9 ++--- kernel/drivers/net/stack/rtnet_module.c |6 ++ 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/kernel/drivers/net/stack/Makefile b/kernel/drivers/net/stack/Makefile index 508d487..d055dc2 100644 --- a/kernel/drivers/net/stack/Makefile +++ b/kernel/drivers/net/stack/Makefile @@ -1,7 +1,5 @@ ccflags-y += -Idrivers/xenomai/net/stack/include -Ikernel/ -obj-y += corectl.o - obj-$(CONFIG_XENO_DRIVERS_NET_RTIPV4) += ipv4/ obj-$(CONFIG_XENO_DRIVERS_NET_RTPACKET) += packet/ @@ -13,6 +11,7 @@ obj-$(CONFIG_XENO_DRIVERS_NET_RTCFG) += rtcfg/ obj-$(CONFIG_XENO_DRIVERS_NET) += rtnet.o rtnet-y := \ + corectl.o \ iovec.o \ rtdev.o \ rtdev_mgr.o \ diff --git a/kernel/drivers/net/stack/corectl.c b/kernel/drivers/net/stack/corectl.c index 2f6f179..c8a9a12 100644 --- a/kernel/drivers/net/stack/corectl.c +++ b/kernel/drivers/net/stack/corectl.c @@ -66,9 +66,12 @@ static struct notifier_block rtnet_corectl_notifier = { .notifier_call = rtnet_corectl_call, }; -static int rtnet_corectl_register(void) +void rtnet_corectl_register(void) { cobalt_add_config_chain(_corectl_notifier); - return 0; } -device_initcall(rtnet_corectl_register); + +void rtnet_corectl_unregister(void) +{ + cobalt_remove_config_chain(_corectl_notifier); +} diff --git a/kernel/drivers/net/stack/rtnet_module.c b/kernel/drivers/net/stack/rtnet_module.c index 1e42558..63ad558 100644 --- a/kernel/drivers/net/stack/rtnet_module.c +++ b/kernel/drivers/net/stack/rtnet_module.c @@ -50,6 +50,8 @@ const char rtnet_rtdm_provider_name[] = EXPORT_SYMBOL_GPL(rtnet_rtdm_provider_name); +void rtnet_corectl_register(void); +void rtnet_corectl_unregister(void); #ifdef CONFIG_XENO_OPT_VFILE /*** @@ -345,6 +347,8 @@ int __init rtnet_init(void) if ((err = rtpc_init()) != 0) goto err_out6; +rtnet_corectl_register(); + return 0; @@ -376,6 +380,8 @@ err_out1: */ void __exit rtnet_release(void) { +rtnet_corectl_unregister(); + rtpc_cleanup(); rtwlan_exit(); ___ Xenomai-git mailing list Xenomai-git@xenomai.org https://xenomai.org/mailman/listinfo/xenomai-git
[Xenomai-git] Philippe Gerum : net: wire up corectl interface
Module: xenomai-3 Branch: wip/rtnet-fixes Commit: 0bf599ee63d8b750fef736a130addbe85a585654 URL: http://git.xenomai.org/?p=xenomai-3.git;a=commit;h=0bf599ee63d8b750fef736a130addbe85a585654 Author: Philippe GerumDate: Mon Dec 4 16:52:24 2017 +0100 net: wire up corectl interface A bug in some Makefile rule caused the corectl support to be wrongly omitted from the object list for building rtnet.ko. As a consequence of this, there is no way the smokey-based RTnet testsuite could have ever worked. Wire up the corectl handler to the Cobalt core as expected. --- kernel/drivers/net/stack/Makefile |3 +-- kernel/drivers/net/stack/corectl.c |9 ++--- kernel/drivers/net/stack/rtnet_module.c |6 ++ 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/kernel/drivers/net/stack/Makefile b/kernel/drivers/net/stack/Makefile index 508d487..d055dc2 100644 --- a/kernel/drivers/net/stack/Makefile +++ b/kernel/drivers/net/stack/Makefile @@ -1,7 +1,5 @@ ccflags-y += -Idrivers/xenomai/net/stack/include -Ikernel/ -obj-y += corectl.o - obj-$(CONFIG_XENO_DRIVERS_NET_RTIPV4) += ipv4/ obj-$(CONFIG_XENO_DRIVERS_NET_RTPACKET) += packet/ @@ -13,6 +11,7 @@ obj-$(CONFIG_XENO_DRIVERS_NET_RTCFG) += rtcfg/ obj-$(CONFIG_XENO_DRIVERS_NET) += rtnet.o rtnet-y := \ + corectl.o \ iovec.o \ rtdev.o \ rtdev_mgr.o \ diff --git a/kernel/drivers/net/stack/corectl.c b/kernel/drivers/net/stack/corectl.c index 2f6f179..c8a9a12 100644 --- a/kernel/drivers/net/stack/corectl.c +++ b/kernel/drivers/net/stack/corectl.c @@ -66,9 +66,12 @@ static struct notifier_block rtnet_corectl_notifier = { .notifier_call = rtnet_corectl_call, }; -static int rtnet_corectl_register(void) +void rtnet_corectl_register(void) { cobalt_add_config_chain(_corectl_notifier); - return 0; } -device_initcall(rtnet_corectl_register); + +void rtnet_corectl_unregister(void) +{ + cobalt_remove_config_chain(_corectl_notifier); +} diff --git a/kernel/drivers/net/stack/rtnet_module.c b/kernel/drivers/net/stack/rtnet_module.c index 1e42558..63ad558 100644 --- a/kernel/drivers/net/stack/rtnet_module.c +++ b/kernel/drivers/net/stack/rtnet_module.c @@ -50,6 +50,8 @@ const char rtnet_rtdm_provider_name[] = EXPORT_SYMBOL_GPL(rtnet_rtdm_provider_name); +void rtnet_corectl_register(void); +void rtnet_corectl_unregister(void); #ifdef CONFIG_XENO_OPT_VFILE /*** @@ -345,6 +347,8 @@ int __init rtnet_init(void) if ((err = rtpc_init()) != 0) goto err_out6; +rtnet_corectl_register(); + return 0; @@ -376,6 +380,8 @@ err_out1: */ void __exit rtnet_release(void) { +rtnet_corectl_unregister(); + rtpc_cleanup(); rtwlan_exit(); ___ Xenomai-git mailing list Xenomai-git@xenomai.org https://xenomai.org/mailman/listinfo/xenomai-git
[Xenomai-git] Philippe Gerum : net: wire up corectl interface
Module: xenomai-3 Branch: wip/rtnet-fixes Commit: dfbefb86f3de1e570914d9f8ecc7ef77a5f81088 URL: http://git.xenomai.org/?p=xenomai-3.git;a=commit;h=dfbefb86f3de1e570914d9f8ecc7ef77a5f81088 Author: Philippe GerumDate: Mon Dec 4 16:52:24 2017 +0100 net: wire up corectl interface A bug in some Makefile rule caused the corectl support to be wrongly omitted from the object list for building rtnet.ko. As a consequence of this, there is no way the smokey-based RTnet testsuite could have ever worked. Wire up the corectl handler to the Cobalt core as expected. --- kernel/drivers/net/stack/Makefile |3 +-- kernel/drivers/net/stack/corectl.c |9 ++--- kernel/drivers/net/stack/rtnet_module.c |6 ++ 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/kernel/drivers/net/stack/Makefile b/kernel/drivers/net/stack/Makefile index 508d487..d055dc2 100644 --- a/kernel/drivers/net/stack/Makefile +++ b/kernel/drivers/net/stack/Makefile @@ -1,7 +1,5 @@ ccflags-y += -Idrivers/xenomai/net/stack/include -Ikernel/ -obj-y += corectl.o - obj-$(CONFIG_XENO_DRIVERS_NET_RTIPV4) += ipv4/ obj-$(CONFIG_XENO_DRIVERS_NET_RTPACKET) += packet/ @@ -13,6 +11,7 @@ obj-$(CONFIG_XENO_DRIVERS_NET_RTCFG) += rtcfg/ obj-$(CONFIG_XENO_DRIVERS_NET) += rtnet.o rtnet-y := \ + corectl.o \ iovec.o \ rtdev.o \ rtdev_mgr.o \ diff --git a/kernel/drivers/net/stack/corectl.c b/kernel/drivers/net/stack/corectl.c index 2f6f179..c8a9a12 100644 --- a/kernel/drivers/net/stack/corectl.c +++ b/kernel/drivers/net/stack/corectl.c @@ -66,9 +66,12 @@ static struct notifier_block rtnet_corectl_notifier = { .notifier_call = rtnet_corectl_call, }; -static int rtnet_corectl_register(void) +void rtnet_corectl_register(void) { cobalt_add_config_chain(_corectl_notifier); - return 0; } -device_initcall(rtnet_corectl_register); + +void rtnet_corectl_unregister(void) +{ + cobalt_remove_config_chain(_corectl_notifier); +} diff --git a/kernel/drivers/net/stack/rtnet_module.c b/kernel/drivers/net/stack/rtnet_module.c index 1e42558..63ad558 100644 --- a/kernel/drivers/net/stack/rtnet_module.c +++ b/kernel/drivers/net/stack/rtnet_module.c @@ -50,6 +50,8 @@ const char rtnet_rtdm_provider_name[] = EXPORT_SYMBOL_GPL(rtnet_rtdm_provider_name); +void rtnet_corectl_register(void); +void rtnet_corectl_unregister(void); #ifdef CONFIG_XENO_OPT_VFILE /*** @@ -345,6 +347,8 @@ int __init rtnet_init(void) if ((err = rtpc_init()) != 0) goto err_out6; +rtnet_corectl_register(); + return 0; @@ -376,6 +380,8 @@ err_out1: */ void __exit rtnet_release(void) { +rtnet_corectl_unregister(); + rtpc_cleanup(); rtwlan_exit(); ___ Xenomai-git mailing list Xenomai-git@xenomai.org https://xenomai.org/mailman/listinfo/xenomai-git
[Xenomai-git] Philippe Gerum : net: wire up corectl interface
Module: xenomai-3 Branch: wip/rtnet-fixes Commit: 086f3236002f7c314dcfeeff81b556676470250e URL: http://git.xenomai.org/?p=xenomai-3.git;a=commit;h=086f3236002f7c314dcfeeff81b556676470250e Author: Philippe GerumDate: Mon Dec 4 16:52:24 2017 +0100 net: wire up corectl interface A bug in some Makefile rule caused the corectl support to be wrongly omitted from the object list for building rtnet.ko. As a consequence of this, there is no way the smokey-based RTnet testsuite could have ever worked. Wire up the corectl handler to the Cobalt core as expected. --- kernel/drivers/net/stack/Makefile |3 +-- kernel/drivers/net/stack/corectl.c |9 ++--- kernel/drivers/net/stack/rtnet_module.c |6 ++ 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/kernel/drivers/net/stack/Makefile b/kernel/drivers/net/stack/Makefile index 508d487..d055dc2 100644 --- a/kernel/drivers/net/stack/Makefile +++ b/kernel/drivers/net/stack/Makefile @@ -1,7 +1,5 @@ ccflags-y += -Idrivers/xenomai/net/stack/include -Ikernel/ -obj-y += corectl.o - obj-$(CONFIG_XENO_DRIVERS_NET_RTIPV4) += ipv4/ obj-$(CONFIG_XENO_DRIVERS_NET_RTPACKET) += packet/ @@ -13,6 +11,7 @@ obj-$(CONFIG_XENO_DRIVERS_NET_RTCFG) += rtcfg/ obj-$(CONFIG_XENO_DRIVERS_NET) += rtnet.o rtnet-y := \ + corectl.o \ iovec.o \ rtdev.o \ rtdev_mgr.o \ diff --git a/kernel/drivers/net/stack/corectl.c b/kernel/drivers/net/stack/corectl.c index 2f6f179..c8a9a12 100644 --- a/kernel/drivers/net/stack/corectl.c +++ b/kernel/drivers/net/stack/corectl.c @@ -66,9 +66,12 @@ static struct notifier_block rtnet_corectl_notifier = { .notifier_call = rtnet_corectl_call, }; -static int rtnet_corectl_register(void) +void rtnet_corectl_register(void) { cobalt_add_config_chain(_corectl_notifier); - return 0; } -device_initcall(rtnet_corectl_register); + +void rtnet_corectl_unregister(void) +{ + cobalt_remove_config_chain(_corectl_notifier); +} diff --git a/kernel/drivers/net/stack/rtnet_module.c b/kernel/drivers/net/stack/rtnet_module.c index 1e42558..63ad558 100644 --- a/kernel/drivers/net/stack/rtnet_module.c +++ b/kernel/drivers/net/stack/rtnet_module.c @@ -50,6 +50,8 @@ const char rtnet_rtdm_provider_name[] = EXPORT_SYMBOL_GPL(rtnet_rtdm_provider_name); +void rtnet_corectl_register(void); +void rtnet_corectl_unregister(void); #ifdef CONFIG_XENO_OPT_VFILE /*** @@ -345,6 +347,8 @@ int __init rtnet_init(void) if ((err = rtpc_init()) != 0) goto err_out6; +rtnet_corectl_register(); + return 0; @@ -376,6 +380,8 @@ err_out1: */ void __exit rtnet_release(void) { +rtnet_corectl_unregister(); + rtpc_cleanup(); rtwlan_exit(); ___ Xenomai-git mailing list Xenomai-git@xenomai.org https://xenomai.org/mailman/listinfo/xenomai-git
[Xenomai-git] Philippe Gerum : net: wire up corectl interface
Module: xenomai-3 Branch: wip/rtnet-fixes Commit: 6f9ab1402d5f1345ec3e372326504a99339e218d URL: http://git.xenomai.org/?p=xenomai-3.git;a=commit;h=6f9ab1402d5f1345ec3e372326504a99339e218d Author: Philippe GerumDate: Mon Dec 4 16:52:24 2017 +0100 net: wire up corectl interface A bug in some Makefile rule caused the corectl support to be wrongly omitted from the object list for building rtnet.ko. As a consequence of this, there is no way the smokey-based RTnet testsuite could have ever worked. Wire up the corectl handler to the Cobalt core as expected. --- kernel/drivers/net/stack/Makefile |3 +-- kernel/drivers/net/stack/corectl.c |9 ++--- kernel/drivers/net/stack/rtnet_module.c |6 ++ 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/kernel/drivers/net/stack/Makefile b/kernel/drivers/net/stack/Makefile index 508d487..d055dc2 100644 --- a/kernel/drivers/net/stack/Makefile +++ b/kernel/drivers/net/stack/Makefile @@ -1,7 +1,5 @@ ccflags-y += -Idrivers/xenomai/net/stack/include -Ikernel/ -obj-y += corectl.o - obj-$(CONFIG_XENO_DRIVERS_NET_RTIPV4) += ipv4/ obj-$(CONFIG_XENO_DRIVERS_NET_RTPACKET) += packet/ @@ -13,6 +11,7 @@ obj-$(CONFIG_XENO_DRIVERS_NET_RTCFG) += rtcfg/ obj-$(CONFIG_XENO_DRIVERS_NET) += rtnet.o rtnet-y := \ + corectl.o \ iovec.o \ rtdev.o \ rtdev_mgr.o \ diff --git a/kernel/drivers/net/stack/corectl.c b/kernel/drivers/net/stack/corectl.c index 2f6f179..c8a9a12 100644 --- a/kernel/drivers/net/stack/corectl.c +++ b/kernel/drivers/net/stack/corectl.c @@ -66,9 +66,12 @@ static struct notifier_block rtnet_corectl_notifier = { .notifier_call = rtnet_corectl_call, }; -static int rtnet_corectl_register(void) +void rtnet_corectl_register(void) { cobalt_add_config_chain(_corectl_notifier); - return 0; } -device_initcall(rtnet_corectl_register); + +void rtnet_corectl_unregister(void) +{ + cobalt_remove_config_chain(_corectl_notifier); +} diff --git a/kernel/drivers/net/stack/rtnet_module.c b/kernel/drivers/net/stack/rtnet_module.c index 1e42558..63ad558 100644 --- a/kernel/drivers/net/stack/rtnet_module.c +++ b/kernel/drivers/net/stack/rtnet_module.c @@ -50,6 +50,8 @@ const char rtnet_rtdm_provider_name[] = EXPORT_SYMBOL_GPL(rtnet_rtdm_provider_name); +void rtnet_corectl_register(void); +void rtnet_corectl_unregister(void); #ifdef CONFIG_XENO_OPT_VFILE /*** @@ -345,6 +347,8 @@ int __init rtnet_init(void) if ((err = rtpc_init()) != 0) goto err_out6; +rtnet_corectl_register(); + return 0; @@ -376,6 +380,8 @@ err_out1: */ void __exit rtnet_release(void) { +rtnet_corectl_unregister(); + rtpc_cleanup(); rtwlan_exit(); ___ Xenomai-git mailing list Xenomai-git@xenomai.org https://xenomai.org/mailman/listinfo/xenomai-git