Re: [PATCHES] fix build on GNU/Hurd with GCC 4.8
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thanks Chris. On 09/19/2013 01:18 AM, Chris Clayton wrote: On 09/18/13 13:29, Chris Clayton wrote: Hi Matt, On 09/18/13 05:50, Matt Dew wrote: Chris, I'm guessing this won't affect you but can you verify that? I don't want a nasty loop where fixing one things breaks another. From the names of the directory that contains the files affected by the inclusion of hurd.h, I can't imagine how that patch would affect a build on linux. Still, a 32-year career in IT taught me to expect the unexpected, so I cloned the 1.14 branch, applied that patch (by hand - it's been mangled by someone's mailer) and did a simple autogen.sh / configure / make. As expected, the build completed successfully. The other patch, which Pino said affected other unix systems, is not included in the mail that arrived here, so, obviously, I haven't built with that applied. Why I didn't do this simple thing yesterday, I can't explain! I got this missing patch from the xorg-devel mail archive and applied it to the 1.14 branch. A build finished finished successfully, so from here, the patches look good. Chris Cheers, Chris thanks, Matt On 09/17/2013 12:02 PM, Samuel Thibault wrote: Hello, Pino Toscano, le Wed 28 Aug 2013 17:36:26 +0200, a écrit : with GCC 4.8, few implicit declaration of function warnings become errors, breaking the build of xserver on the Hurd. Attached there are two patches, which apply fine in both master and server-1.14-branch branches, which fix the errors providing the right includes: * the inclusion of hurd.h in Hurd parts should be straightforward * the move of the arpa/inet.h (which is POSIX) to a move general location affects any other Unix system with IPv6 support, I hope it is not a problem for all the supported platforms Acked-by: Samuel Thibault samuel.thiba...@ens-lyon.org Could somebody push that to the server? We really need it. Thanks, Samuel From ef6a236cf9b795017c9c8c4447a6735fa04bb061 Mon Sep 17 00:00:00 2001 From: Pino Toscano toscano.p...@tiscali.it Date: Wed, 28 Aug 2013 17:04:48 +0200 Subject: [PATCH] xfree86/hurd: include hurd.h Needed for using get_privileged_port. Signed-off-by: Pino Toscano toscano.p...@tiscali.it --- hw/xfree86/os-support/hurd/hurd_init.c |1 + hw/xfree86/os-support/hurd/hurd_mmap.c |1 + hw/xfree86/os-support/hurd/hurd_video.c |1 + 3 files changed, 3 insertions(+) diff --git a/hw/xfree86/os-support/hurd/hurd_init.c b/hw/xfree86/os-support/hurd/hurd_init.c index 185b2b9..fe1a764 100644 --- a/hw/xfree86/os-support/hurd/hurd_init.c +++ b/hw/xfree86/os-support/hurd/hurd_init.c @@ -42,6 +42,7 @@ #include sys/file.h #include assert.h #include mach.h +#include hurd.h int xf86ProcessArgument(int argc, char **argv, int i) diff --git a/hw/xfree86/os-support/hurd/hurd_mmap.c b/hw/xfree86/os-support/hurd/hurd_mmap.c index 6ac9efd..8e089ca 100644 --- a/hw/xfree86/os-support/hurd/hurd_mmap.c +++ b/hw/xfree86/os-support/hurd/hurd_mmap.c @@ -27,6 +27,7 @@ #includemach.h #includedevice/device.h #includemach/machine/mach_i386.h +#include hurd.h #include X11/X.h diff --git a/hw/xfree86/os-support/hurd/hurd_video.c b/hw/xfree86/os-support/hurd/hurd_video.c index 72474ba..b3b94c9 100644 --- a/hw/xfree86/os-support/hurd/hurd_video.c +++ b/hw/xfree86/os-support/hurd/hurd_video.c @@ -28,6 +28,7 @@ #include mach.h #include device/device.h #include mach/machine/mach_i386.h +#include hurd.h #include X11/X.h #include input.h - -- Matt DewKey signature: 0xF7C3 BEC3 Fingerprint: FDB1 9D94 C573 DC29 BCCB 2F9F A6BF 3771 F7C3 BEC3 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJSO8R1AAoJEKa/N3H3w77DsHoH/15H/9uRcXSSUQhfA7mKwYG1 QF1qPAvBW6tKyT/kdVXS9tnvvxHOxaF41FioF4JFo91z3O14JTsCO0hUsfIgAG4B v/IzbSA5XmKW+fd4OdYTd1LDYg6NPp2qhsWaQvLG7DLirA6X2wRM2ypL5L8ELcOW MvixnpoVqjUBM6bbTyjhvsmAg3jHW79KRkzPiHDnLUjj+4d8ksZfYgG9Giuh67P3 XmCEjx4bPk8wcvz42SoIzHTmd/fN7yH0zPiPMAQBXLuYIYRMRwRNU8YOdvhtLnkA GzVij4ggI5gXMJaZk9ijE5jSCvimYBvOz7RjQLMeT2KusjZ7a8ITQJ6j7WHRI7g= =SdTF -END PGP SIGNATURE- ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCHES] fix build on GNU/Hurd with GCC 4.8
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/18/2013 02:43 AM, Julien Cristau wrote: On Tue, Sep 17, 2013 at 22:50:46 -0600, Matt Dew wrote: Chris, I'm guessing this won't affect you but can you verify that? I don't want a nasty loop where fixing one things breaks another. Err, what are you talking about? Hi Julien, You know, when one person's bugfix causes a bug for another person. Then fixing that bug causes another bug, and so on. Very unlikely I know, but ... - -- Matt DewKey signature: 0xF7C3 BEC3 Fingerprint: FDB1 9D94 C573 DC29 BCCB 2F9F A6BF 3771 F7C3 BEC3 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJSO8RDAAoJEKa/N3H3w77Dm9MH/2aKVMaqwHaWNPQCCRQCFdLM Qzgt/VVhbZsF0kwD1vkW2O2obIGH8rKPouVz7E9Bmo5pSwmQeya+ceWtw5dmM5xK f21gw8zyS/aYXvV8xkXd3qyHL0UuMfYJ1AhHCiD4toFPST5GdTPlMJlWINRcECor yXF5ZAU7BflWLCFg7MnNper6+Bcl+Pm9nWzTYy9/LaQN6Erj+Bm0LgL2zrD28FIz lT708mpeXQtd54ruYYDSx+E9DyDkQZUE1rXejsrL/tzjGNenx2Qd+y8aoqzuxZq/ 0blbEKJZ6J7eImtSUUT3eMrLa/Fb5NgDuRi1hhGxwHAee1ZxjXECVVcx0kev8Ls= =2sqM -END PGP SIGNATURE- ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCHES] fix build on GNU/Hurd with GCC 4.8
On Thu, Sep 19, 2013 at 21:43:02 -0600, Matt Dew wrote: On 09/18/2013 02:43 AM, Julien Cristau wrote: On Tue, Sep 17, 2013 at 22:50:46 -0600, Matt Dew wrote: Chris, I'm guessing this won't affect you but can you verify that? I don't want a nasty loop where fixing one things breaks another. Err, what are you talking about? Hi Julien, You know, when one person's bugfix causes a bug for another person. Then fixing that bug causes another bug, and so on. Very unlikely I know, but ... Hi Matt, You're not going to ask every single bug reporter ever to test every single patch that comes in, though, so I'm wondering what's special about this one... Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH] damage: Must translate initial window damage by window offset
Damage is reported relative to the drawable origin, but the window
borderClip is absolute. Translate the region by the window position
before reporting damage to adjust.
Reported-by: Adam Jackson a...@redhat.com
Signed-off-by: Keith Packard kei...@keithp.com
---
damageext/damageext.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/damageext/damageext.c b/damageext/damageext.c
index a942ffa..cf6b63b 100644
--- a/damageext/damageext.c
+++ b/damageext/damageext.c
@@ -223,7 +223,9 @@ ProcDamageCreate(ClientPtr client)
if (pDrawable-type == DRAWABLE_WINDOW) {
pRegion = ((WindowPtr) pDrawable)-borderClip;
+RegionTranslate(pRegion, -pDrawable-x, -pDrawable-y);
DamageReportDamage(pDamageExt-pDamage, pRegion);
+RegionTranslate(pRegion, pDrawable-x, pDrawable-y);
}
return Success;
--
1.8.4.rc3
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
XDC schedule published
Final schedule is now available: http://www.x.org/wiki/Events/XDC2013/Program/ ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] damage: Must translate initial window damage by window offset
Keith Packard kei...@keithp.com writes: Damage is reported relative to the drawable origin, but the window borderClip is absolute. Translate the region by the window position before reporting damage to adjust. Merged. 8010d3a..7d3d4ae master - master -- keith.pack...@intel.com pgpqx64mU5_c2.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] damage: Must translate initial window damage by window offset
On Fri, 2013-09-20 at 14:45 -0500, Keith Packard wrote:
Damage is reported relative to the drawable origin, but the window
borderClip is absolute. Translate the region by the window position
before reporting damage to adjust.
This makes initial window damage reports match subsequent damage reports
for the non-Xinerama case. It breaks my current Xinerama patch, but
that's my doing, which I'll correct before sending v3. Tested on Xvfb
plus a trivial hack to do right-of placement for screens (since
otherwise Xvfb's screens all end up with +0+0 for origin):
--- a/hw/vfb/InitOutput.c
+++ b/hw/vfb/InitOutput.c
@@ -881,6 +881,13 @@ vfbScreenInit(ScreenPtr pScreen, int argc, char **argv)
pvfb-closeScreen = pScreen-CloseScreen;
pScreen-CloseScreen = vfbCloseScreen;
+/* gross */
+{
+int i;
+for (i = 0; i pScreen-myNum; i++)
+pScreen-x += screenInfo.screens[i]-width;
+}
+
return ret;
} /* end vfbScreenInit */
Reviewed-by: Adam Jackson a...@redhat.com
- ajax
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCHES] fix build on GNU/Hurd with GCC 4.8
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/20/2013 12:45 AM, Julien Cristau wrote: On Thu, Sep 19, 2013 at 21:43:02 -0600, Matt Dew wrote: On 09/18/2013 02:43 AM, Julien Cristau wrote: On Tue, Sep 17, 2013 at 22:50:46 -0600, Matt Dew wrote: Chris, I'm guessing this won't affect you but can you verify that? I don't want a nasty loop where fixing one things breaks another. Err, what are you talking about? Hi Julien, You know, when one person's bugfix causes a bug for another person. Then fixing that bug causes another bug, and so on. Very unlikely I know, but ... Hi Matt, You're not going to ask every single bug reporter ever to test every single patch that comes in, though, so I'm wondering what's special about this one... Hi Julien, Oh heck no.Just that the gcc 4.8 patch was a bit of a pain and that final week's hold up was for it. Then only a few days later there was another patch for gcc 4.8. I got paranoid. It's was a special case, and unnecessary as it turns out. Matt - -- Matt Dew mar...@osource.org Key signature: 0xF7C3 BEC3 Fingerprint: FDB1 9D94 C573 DC29 BCCB 2F9F A6BF 3771 F7C3 BEC3 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJSPSNqAAoJEKa/N3H3w77Da6sH/0wnWklSLOrNa+KX15dRBW/6 HOija+ZbDvQ6EIxbutYyaOAl7f30II2rcxs5BK2h3FY2sSn2lTFlgiPDxCaZQ8RZ bSwndnQnVL3TUZcrBvMsuc2faQCrCOr7FOQCNF9GUynifpcc4swkrvLlVI5J2Kl9 +DsDcXBWhUfnqJ57gQuaLRce/hT46pEHtP3DckirGOnet0zGQeqZtYwD8x4+Z0y9 Z+5Sdq+SbGmA6R4jhFIBXgfnhI1czHn9vuzTdMrqvk2pxr2nu6Iy1y/VCxAQ6A1f qQgO48tmuXXlEOCj+e2/0mTdt715tKGBJk3dUf8oyl8LX03fHtW08N4+cRFWdFo= =jjMo -END PGP SIGNATURE- ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
