Re: [RFC] DeepColor Visual Class Extension
> > If we left them out of the connection setup block and relied on a separate > request to get a list of DeepColor visuals it would alleviate that issue, but > then we run into the same issue Aaron pointed out with XGetWindowAttributes. > Non-HDR clients would get what appears to be a bogus visual when querying the > visual of an HDR window because xlib would be unaware of it. > > If you keep track of whether clients support HDR per-connection, you could fake the HDR windows' visual id for the non-HDR clients, returning a TrueColor visual id instead. This will avoid the problem of the client thinking that the visual id is bogus. Jacob Lifshay ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [RFC dri3proto v2 1/10] Add modifier/multi-plane requests, bump to v1.1
Hi, On Wednesday, August 30, 2017 02:26 EDT, Michel Dänzer wrote: > It doesn't seem to get assigned by the xserver code either. A leftover? > (I just happened to notice this, there might be other similar issues) It was indeed a leftover, it is now fixed in the repository. -- Louis-Francis ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [RFC xserver 06/12] present: Check the whole exec queue on event
Hi, On Wednesday, August 30, 2017 03:19 EDT, Michel Dänzer wrote: > On 30/08/17 02:16 PM, Louis-Francis Ratté-Boulianne wrote: > > Later events are sometimes added in front of the queue (e.g. > > if page flipping fails) so we need to check the whole queue > > on event. > > > Hmm, I guess this can happen if present_flip() fails in > present_execute()? Do you have a reproducible way to trigger a problem > without this change? I was able to reproduce the problem because at some point I broke page flipping while rebasing. > Should the same code in present_abort_vblank() be removed as well? Indeed, thanks! -- Louis-Francis ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH libpciaccess] linux: support 32 bit PCI domains (v3)
On Wed, 20 Sep 2017 13:31:17 -0400 Adam Jackson wrote: > On Mon, 2017-09-18 at 21:33 +0100, Emil Velikov wrote: > > Hi Adam, > > > > A couple of question about the v3 changes. Hope I'm not loosing my marbles. > > > > On 18 September 2017 at 18:17, Adam Jackson wrote: > > > > > --- a/src/netbsd_pci.c > > > +++ b/src/netbsd_pci.c > > > @@ -959,6 +959,10 @@ pci_system_netbsd_create(void) > > > continue; > > > > > > device->base.domain = domain; > > > + if (domain > 0x) > > > + device->base.domain_16 = 0x; > > > + else > > > + device->base.domain_16 = domain & > > > 0x; > > > > In the else case domain is within [0..0x] thus the "& 0x" is a > > noop. Right? > > Yeah, pretty sure I just typed that without thinking to be clear that > it was being clamped, any remotely reasonable compiler is going to > optimize it out of existence. > > - ajax Not only that since domain_16 is a uint16_t compiler would have to fold it no matter the value. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver 2/2] meson: Use dependency version_compare()
Daniel Stone writes:
> We can check the version on an existing dependency, rather than spinning
> up pkg-config again just to check the right version.
>
> Signed-off-by: Daniel Stone
> ---
> include/meson.build | 7 +++
> meson.build | 3 ---
> 2 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/include/meson.build b/include/meson.build
> index 05ef76930..5eefc5f07 100644
> --- a/include/meson.build
> +++ b/include/meson.build
> @@ -72,13 +72,12 @@ conf_data.set_quoted('SHMDIR', '/tmp')
> conf_data.set('HAVE_XSHMFENCE', xshmfence_dep.found())
> conf_data.set('WITH_LIBDRM', libdrm_dep.found())
> conf_data.set('GLAMOR_HAS_DRM_NAME_FROM_FD_2',
> - dependency('libdrm', version: '>= 2.4.74', required:
> false).found())
> + libdrm_dep.found() and
> libdrm_dep.version().version_compare('>= 2.4.74'))
nirbheek says there's a meson patch to be merged soon that handles the
caching of pkg-config outputs automatically so you don't need to do this
dep.found() and dep.version().version_compare() dance. That said,
you've reduced the build system complexity with the rest of this patch,
so:
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver 1/2] Build: Use dri3proto/libdrm CFLAGS
Daniel Stone writes: > Make sure we get the CFLAGS required for building DRI3 into the > command line. > > Signed-off-by: Daniel Stone Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH libpciaccess] linux: support 32 bit PCI domains (v3)
On Mon, 2017-09-18 at 21:33 +0100, Emil Velikov wrote: > Hi Adam, > > A couple of question about the v3 changes. Hope I'm not loosing my marbles. > > On 18 September 2017 at 18:17, Adam Jackson wrote: > > > --- a/src/netbsd_pci.c > > +++ b/src/netbsd_pci.c > > @@ -959,6 +959,10 @@ pci_system_netbsd_create(void) > > continue; > > > > device->base.domain = domain; > > + if (domain > 0x) > > + device->base.domain_16 = 0x; > > + else > > + device->base.domain_16 = domain & > > 0x; > > In the else case domain is within [0..0x] thus the "& 0x" is a > noop. Right? Yeah, pretty sure I just typed that without thinking to be clear that it was being clamped, any remotely reasonable compiler is going to optimize it out of existence. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver 2/2] meson: Use dependency version_compare()
On Wed, 2017-09-20 at 07:22 -0700, Daniel Stone wrote: > We can check the version on an existing dependency, rather than spinning > up pkg-config again just to check the right version. Merged, thanks: remote: I: patch #177948 updated using rev 86a89dd6020f59964c0e924acbfae9d5a51e3148. remote: I: patch #177949 updated using rev d770f9293296d2d3c4e49e94130ff68c0890f625. remote: I: 2 patch(es) updated to state Accepted. To ssh://git.freedesktop.org/git/xorg/xserver 294670682..d770f9293 master -> master - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH RESEND xserver 0/6] sync int64 series resend
On Mon, 2017-09-18 at 17:34 -0700, Eric Anholt wrote: > I've squashed in the fixes and I'm resending, since some of the early > patches never got reviewed. I suspect they got lost in all the noise > about casting. Still passes the tests locally and on Travis. Thanks for resending this, I was having trouble untangling what the final version of each patch was. Merged: remote: I: patch #170208 updated using rev a09743c9300f805d6527368ddcf44f5dccd4b366. remote: I: patch #177590 updated using rev a8eeb332ccf4d13b3fdcc382397bd3ea45e76212. remote: I: patch #173354 updated using rev 3336291fc68444ee65b48ba675ec947e505fed57. remote: I: patch #177589 updated using rev 5cbfa276541e6a621cf9c4b44b75323e90a5bd4c. remote: I: patch #177593 updated using rev e0f872207aa203adb85e825c311ed50fe3a3af60. remote: I: patch #177591 updated using rev 294670682120c65001b36369d6395003704f4ac1. remote: I: 6 patch(es) updated to state Accepted. To ssh://git.freedesktop.org/git/xorg/xserver de3b61869..294670682 master -> master - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
[PATCH xserver 2/2] meson: Use dependency version_compare()
We can check the version on an existing dependency, rather than spinning
up pkg-config again just to check the right version.
Signed-off-by: Daniel Stone
---
include/meson.build | 7 +++
meson.build | 3 ---
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/include/meson.build b/include/meson.build
index 05ef76930..5eefc5f07 100644
--- a/include/meson.build
+++ b/include/meson.build
@@ -72,13 +72,12 @@ conf_data.set_quoted('SHMDIR', '/tmp')
conf_data.set('HAVE_XSHMFENCE', xshmfence_dep.found())
conf_data.set('WITH_LIBDRM', libdrm_dep.found())
conf_data.set('GLAMOR_HAS_DRM_NAME_FROM_FD_2',
- dependency('libdrm', version: '>= 2.4.74', required:
false).found())
+ libdrm_dep.found() and libdrm_dep.version().version_compare('>=
2.4.74'))
conf_data.set('GLXEXT', build_glx)
conf_data.set('GLAMOR', build_glamor)
conf_data.set('GLAMOR_HAS_GBM', gbm_dep.found())
-if gbm_dep.found() and dependency('gbm', version: '>= 10.6', required:
false).found()
-conf_data.set('GLAMOR_HAS_GBM_LINEAR', build_glamor)
-endif
+conf_data.set('GLAMOR_HAS_GBM_LINEAR',
+ gbm_dep.found() and gbm_dep.version().version_compare('>= 10.6'))
conf_data.set_quoted('SERVER_MISC_CONFIG_PATH', serverconfigdir)
conf_data.set_quoted('PROJECTROOT', get_option('prefix'))
diff --git a/meson.build b/meson.build
index 3efec0def..4bfe9ee5e 100644
--- a/meson.build
+++ b/meson.build
@@ -210,9 +210,6 @@ endif
gbm_dep = dependency('', required:false)
if build_glamor
gbm_dep = dependency('gbm', version: '>= 10.2', required: false)
-if gbm_dep.found()
-gbm_linear_dep = dependency('gbm', version: '>= 10.6', required: false)
-endif
endif
# XXX: Add more sha1 options, because Linux is about choice
--
2.14.1
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
[PATCH xserver 1/2] Build: Use dri3proto/libdrm CFLAGS
Make sure we get the CFLAGS required for building DRI3 into the
command line.
Signed-off-by: Daniel Stone
---
configure.ac | 1 +
dri3/meson.build | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index f13a54ab9..ec98f52c0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1197,6 +1197,7 @@ PKG_CHECK_MODULES([DRI3PROTO], $DRI3PROTO,
case "$DRI3,$HAVE_DRI3PROTO" in
yes,yes | auto,yes)
+ REQUIRED_MODULES="$REQUIRED_MODULES dri3proto"
;;
yes,no)
AC_MSG_ERROR([DRI3 requested, but dri3proto not found.])
diff --git a/dri3/meson.build b/dri3/meson.build
index 3d05020e6..0deec32aa 100644
--- a/dri3/meson.build
+++ b/dri3/meson.build
@@ -9,7 +9,7 @@ if build_dri3
libxserver_dri3 = static_library('libxserver_dri3',
srcs_dri3,
include_directories: inc,
-dependencies: common_dep,
+dependencies: [ common_dep, libdrm_dep ],
c_args: '-DHAVE_XORG_CONFIG_H'
)
endif
--
2.14.1
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
