Re: [PATCH xserver 3/3] glx: Implement GLX_EXT_no_config_context (v2)

2017-11-16 Thread Eric Anholt 
Adam Jackson  writes:

> Only enabled for the DRI backends at the moment. In principle WGL/CGL
> could support this - it's sort of implied by GL 3.0 support - but in
> practice I don't know that it would actually work.
>
> This is currently a draft extension, under review at:
>
> https://github.com/KhronosGroup/OpenGL-Registry/pull/102
>
> v2: Require that the two screen numbers match, per v4 of spec.

Once the spec is accepted, 2-3 are:

Reviewed-by: Eric Anholt 


signature.asc
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver 1/3] glx: Fix glXQueryContext for GLX_FBCONFIG_ID and GLX_RENDER_TYPE (v2)

2017-11-16 Thread Eric Anholt 
Adam Jackson  writes:

> Just never filled in, oops. Seems to have gone unnoticed because
> normally glXQueryContext simply returns the values filled in by the
> client library when the context was created. The only path by which you
> normally get to a GLXQueryContext request is glXImportContext, and then
> only if the context is already indirect.
>
> However, that's a statement about Mesa's libGL (and anything else that
> inherited that bit of the SGI SI more or less intact). Nothing prevents
> a mischeivous client from issuing that request of a direct context, and
> if they did we'd be in trouble because we never bothered to preserve the
> associated fbconfig in the context state, so we'd crash looking up
> GLX_VISUAL_ID_EXT. So let's fix that too.
>
> v2: Fixed missing preservation of the config in DRI2 (Eric Anholt)

This one had my

Reviewed-by: Eric Anholt 


signature.asc
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [RFC PATCH xserver] xwayland: Fix non-argb cursor conversion

2017-11-16 Thread Emil Velikov 
Hi Olivier,

On 27 September 2017 at 17:01, Olivier Fourdan  wrote:
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=103012
> Signed-off-by: Olivier Fourdan 
> ---
>  Note: I am not familiar with this so I have no idea whether or not the
>  fix is correct (thus the RFC), but it does fix the test case provided
>  in bug 103012.
>
>  hw/xwayland/xwayland-cursor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/xwayland/xwayland-cursor.c b/hw/xwayland/xwayland-cursor.c
> index c95f4e830..cf8395f1d 100644
> --- a/hw/xwayland/xwayland-cursor.c
> +++ b/hw/xwayland/xwayland-cursor.c
> @@ -42,7 +42,7 @@ expand_source_and_mask(CursorPtr cursor, CARD32 *data)
>  (cursor->foreGreen & 0xff00) | (cursor->foreGreen >> 8);
>  bg = ((cursor->backRed & 0xff00) << 8) |
>  (cursor->backGreen & 0xff00) | (cursor->backGreen >> 8);
> -stride = (bits->width / 8 + 3) & ~3;
> +stride = BitmapBytePad(bits->width);

Bit of a disclaimer - I'm far from expert in the area.

The pattern seems like a common mistake, where one would align after
the division instead of the other way around.
As width is != 32 the code will provide larger than needed stride,
which seems to be exactly what the commit summary says.

One might mention exactly what's happening the commit message, since
it's not immediately obvious.

With the above disclaimer in mind, patch is
Reviewed-by: Emil Velikov 

-Emil
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [RFC PATCH xserver] xwayland: Fix non-argb cursor conversion

2017-11-16 Thread Olivier Fourdan 
Hi all,

Anyone to review/comment on this patch below?

It seems to fix the issue wit hte reproducer from the bug, but I dunno if this 
is right fix...

Thanks
Olivier

> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=103012
> Signed-off-by: Olivier Fourdan 
> ---
>  Note: I am not familiar with this so I have no idea whether or not the
>  fix is correct (thus the RFC), but it does fix the test case provided
>  in bug 103012.
> 
>  hw/xwayland/xwayland-cursor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/xwayland/xwayland-cursor.c b/hw/xwayland/xwayland-cursor.c
> index c95f4e830..cf8395f1d 100644
> --- a/hw/xwayland/xwayland-cursor.c
> +++ b/hw/xwayland/xwayland-cursor.c
> @@ -42,7 +42,7 @@ expand_source_and_mask(CursorPtr cursor, CARD32 *data)
>  (cursor->foreGreen & 0xff00) | (cursor->foreGreen >> 8);
>  bg = ((cursor->backRed & 0xff00) << 8) |
>  (cursor->backGreen & 0xff00) | (cursor->backGreen >> 8);
> -stride = (bits->width / 8 + 3) & ~3;
> +stride = BitmapBytePad(bits->width);
>  for (y = 0; y < bits->height; y++)
>  for (x = 0; x < bits->width; x++) {
>  i = y * stride + x / 8;
> --
> 2.13.5
> 
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel