Re: Obtaining Xorg DDX commit privilege
On 2018-06-10 07:15 PM, Kevin Brace wrote: >> Sent: Tuesday, June 05, 2018 at 8:16 PM >> From: "Connor Behan" >> To: "Michel Dänzer" , "Kevin Brace" >> Cc: xorg-devel@lists.x.org >> Subject: Re: Obtaining Xorg DDX commit privilege >> >> >> On 2018-06-05 05:33 AM, Michel Dänzer wrote: >>> On 2018-06-05 05:00 AM, Kevin Brace wrote: I do have OpenChrome related commit privilege and I wanted to extend it to other xf86-video-* DDXs. I did post several patches over at xorg-driver-ati mailing list if that is what is needed to earn this privilege. >>> Connor Behan has been looking after xf86-video-r128. >> Thanks. I've been meaning to test your patches Kevin. The only one I'm >> nervous about so far is #5 which removes DDC. >> >> > Hi Connor, > > Can you commit the patches as soon as possible? > I feel like you are bottlenecking the process by not really doing anything > with the patches for about a week. > As far as I am concerned, that's taking too much time. > I have tested the code on ATI Technologies Xpert 2000 (RAGE 128, 32 MB), and > they appear to work fine. > While there is this issue of GitLab migration, I will also like you to > recommend to the freedesktop.org administrators that I obtain commit > privilege so that I can commit code changes myself. > There is a lot of work to be done to improve the reliability of r128 DDX, and > I am willing to invest time in it. There are some mailing lists where I would kill to have the turnaround time only be a week. It was also not clear to me whether you wanted these patches pushed before or after the privilege upgrade. For what it's worth, I think it's clear that you care about this DDX. So if the two admins who have entered the discussion here are still reading, let this serve as my recommendation. signature.asc Description: OpenPGP digital signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: Obtaining Xorg DDX commit privilege
Hi Connor, Can you commit the patches as soon as possible? I feel like you are bottlenecking the process by not really doing anything with the patches for about a week. As far as I am concerned, that's taking too much time. I have tested the code on ATI Technologies Xpert 2000 (RAGE 128, 32 MB), and they appear to work fine. While there is this issue of GitLab migration, I will also like you to recommend to the freedesktop.org administrators that I obtain commit privilege so that I can commit code changes myself. There is a lot of work to be done to improve the reliability of r128 DDX, and I am willing to invest time in it. Kevin Brace Brace Computer Laboratory blog https://bracecomputerlab.com > Sent: Tuesday, June 05, 2018 at 8:16 PM > From: "Connor Behan" > To: "Michel Dänzer" , "Kevin Brace" > Cc: xorg-devel@lists.x.org > Subject: Re: Obtaining Xorg DDX commit privilege > > On 2018-06-05 05:33 AM, Michel Dänzer wrote: > > On 2018-06-05 05:00 AM, Kevin Brace wrote: > >> I do have OpenChrome related commit privilege and I wanted to extend it to > >> other xf86-video-* DDXs. > >> I did post several patches over at xorg-driver-ati mailing list if that is > >> what is needed to earn this privilege. > > Connor Behan has been looking after xf86-video-r128. > > Thanks. I've been meaning to test your patches Kevin. The only one I'm > nervous about so far is #5 which removes DDC. > > ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
[PATCH xserver] xwayland: add "tablet" into the tablet device names
Changes the device name from "xwayland-stylus" to "xwayland-tablet stylus".
This doesn't fully address #26 but it goes a little step into making it more
human-readable.
https://gitlab.freedesktop.org/wayland/wayland/issues/26
Signed-off-by: Peter Hutterer
---
hw/xwayland/xwayland-input.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/xwayland/xwayland-input.c b/hw/xwayland/xwayland-input.c
index 0a37f97bd..a602f0887 100644
--- a/hw/xwayland/xwayland-input.c
+++ b/hw/xwayland/xwayland-input.c
@@ -1389,19 +1389,19 @@ tablet_handle_done(void *data, struct zwp_tablet_v2
*tablet)
struct xwl_seat *xwl_seat = xwl_tablet->seat;
if (xwl_seat->stylus == NULL) {
-xwl_seat->stylus = add_device(xwl_seat, "xwayland-stylus",
xwl_tablet_proc);
+xwl_seat->stylus = add_device(xwl_seat, "xwayland-tablet stylus",
xwl_tablet_proc);
ActivateDevice(xwl_seat->stylus, TRUE);
}
EnableDevice(xwl_seat->stylus, TRUE);
if (xwl_seat->eraser == NULL) {
-xwl_seat->eraser = add_device(xwl_seat, "xwayland-eraser",
xwl_tablet_proc);
+xwl_seat->eraser = add_device(xwl_seat, "xwayland-tablet eraser",
xwl_tablet_proc);
ActivateDevice(xwl_seat->eraser, TRUE);
}
EnableDevice(xwl_seat->eraser, TRUE);
if (xwl_seat->puck == NULL) {
-xwl_seat->puck = add_device(xwl_seat, "xwayland-cursor",
xwl_tablet_proc);
+xwl_seat->puck = add_device(xwl_seat, "xwayland-tablet cursor",
xwl_tablet_proc);
ActivateDevice(xwl_seat->puck, TRUE);
}
EnableDevice(xwl_seat->puck, TRUE);
@@ -2147,7 +2147,7 @@ tablet_pad_done(void *data,
{
struct xwl_tablet_pad *pad = data;
-pad->xdevice = add_device(pad->seat, "xwayland-pad",
+pad->xdevice = add_device(pad->seat, "xwayland-tablet-pad",
xwl_tablet_pad_proc);
pad->xdevice->public.devicePrivate = pad;
ActivateDevice(pad->xdevice, TRUE);
--
2.14.4
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver v3] xwayland: use pixmap size on present flip
The only question open to me is how the window and pixmap size can be different at all at this point. But taking the Pixmap size is in any case better. I reviewed v3 on patchworks. Reviewed-by: Roman Gilg ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
