Re: [PATCH xserver] xwayland: Enable DRI3 for glamor

2018-07-20 Thread Michel Dänzer
On 2018-07-20 09:51 AM, Olivier Fourdan wrote:
> glamor_fds_from_pixmap() will bail out early if DRI3 is not enabled,
> unfortunately Xwayland's glamor code would not set it as enabled which
> would lead to blank pixmaps when using texture from pixmap.
> 
> Make sure to mark DRI3 as enabled from glamor_egl_screen_init() in
> Xwayland.
> 
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=107287

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107287

The Fixes tag is for referencing another commit which is fixed by this one.


> Signed-off-by: Olivier Fourdan 
> ---
>  hw/xwayland/xwayland-glamor.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/xwayland/xwayland-glamor.c b/hw/xwayland/xwayland-glamor.c
> index f17914344..7ea6def61 100644
> --- a/hw/xwayland/xwayland-glamor.c
> +++ b/hw/xwayland/xwayland-glamor.c
> @@ -57,6 +57,7 @@ glamor_egl_screen_init(ScreenPtr screen, struct 
> glamor_context *glamor_ctx)
>  {
>  struct xwl_screen *xwl_screen = xwl_screen_get(screen);
>  
> +glamor_enable_dri3(screen);
>  glamor_ctx->ctx = xwl_screen->egl_context;
>  glamor_ctx->display = xwl_screen->egl_display;
>  
> 

With the above fixed,

Reviewed-by: Michel Dänzer 


-- 
Earthling Michel Dänzer   |   http://www.amd.com
Libre software enthusiast | Mesa and X developer
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xserver] xwayland: Enable DRI3 for glamor

2018-07-20 Thread Olivier Fourdan
glamor_fds_from_pixmap() will bail out early if DRI3 is not enabled,
unfortunately Xwayland's glamor code would not set it as enabled which
would lead to blank pixmaps when using texture from pixmap.

Make sure to mark DRI3 as enabled from glamor_egl_screen_init() in
Xwayland.

Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=107287
Signed-off-by: Olivier Fourdan 
---
 hw/xwayland/xwayland-glamor.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/xwayland/xwayland-glamor.c b/hw/xwayland/xwayland-glamor.c
index f17914344..7ea6def61 100644
--- a/hw/xwayland/xwayland-glamor.c
+++ b/hw/xwayland/xwayland-glamor.c
@@ -57,6 +57,7 @@ glamor_egl_screen_init(ScreenPtr screen, struct 
glamor_context *glamor_ctx)
 {
 struct xwl_screen *xwl_screen = xwl_screen_get(screen);
 
+glamor_enable_dri3(screen);
 glamor_ctx->ctx = xwl_screen->egl_context;
 glamor_ctx->display = xwl_screen->egl_display;
 
-- 
2.17.1

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel