Re: [PATCH app/xcursorgen v3] Update README for gitlab migration
On Mon, Nov 12, 2018 at 11:55:18AM -0800, Alan Coopersmith wrote: > Signed-off-by: Alan Coopersmith Reviewed-by: Peter Hutterer > --- > > v2: Moved to README.md and reduced whitespace in front of URLs so that > gitlab renders them as links instead of code fragements - see > https://gitlab.freedesktop.org/alanc/xcursorgen for formatted view > Restored link to Submitting Patches page so that we have a place to > provide instructions on how we use gitlab. > Removed GitPage link. > Changed mailman link from fd.o to x.org URL > v3: Change remaining http URLs to https > > README| 25 - > README.md | 17 + > 2 files changed, 17 insertions(+), 25 deletions(-) > delete mode 100644 README > create mode 100644 README.md > > diff --git a/README b/README > deleted file mode 100644 > index 6e46f96..000 > --- a/README > +++ /dev/null > @@ -1,25 +0,0 @@ > -xcursorgen prepares X11 cursor sets for use with libXcursor. > - > -All questions regarding this software should be directed at the > -Xorg mailing list: > - > -http://lists.freedesktop.org/mailman/listinfo/xorg > - > -Please submit bug reports to the Xorg bugzilla: > - > -https://bugs.freedesktop.org/enter_bug.cgi?product=xorg > - > -The master development code repository can be found at: > - > -git://anongit.freedesktop.org/git/xorg/app/xcursorgen > - > -http://cgit.freedesktop.org/xorg/app/xcursorgen > - > -For patch submission instructions, see: > - > - http://www.x.org/wiki/Development/Documentation/SubmittingPatches > - > -For more information on the git code manager, see: > - > -http://wiki.x.org/wiki/GitPage > - > diff --git a/README.md b/README.md > new file mode 100644 > index 000..a935f4e > --- /dev/null > +++ b/README.md > @@ -0,0 +1,17 @@ > +xcursorgen prepares X11 cursor sets for use with libXcursor. > + > +All questions regarding this software should be directed at the > +Xorg mailing list: > + > + https://lists.x.org/mailman/listinfo/xorg > + > +The master development code repository can be found at: > + > + https://gitlab.freedesktop.org/xorg/app/xcursorgen > + > +Please submit bug reports and requests to merge patches there. > + > +For patch submission instructions, see: > + > + https://www.x.org/wiki/Development/Documentation/SubmittingPatches > + > -- > 2.15.2 > > ___ > xorg-devel@lists.x.org: X.Org development > Archives: http://lists.x.org/archives/xorg-devel > Info: https://lists.x.org/mailman/listinfo/xorg-devel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
[QXL PATCH 0/2] Minor QXL patches
These QXL patches were both reviewed and ACKed by Frediano, but apparently neither of us has commit rights to the xf86-video-qxl repository. I'm not sure if this is since the move to gitlab or if we never had commit rights to this repository. In any case, it looks like we'll need an Xorg developer to review and/or push the patches upstream. Thanks, Jonathon Jonathon Jongsma (2): Make output name numbering 0-based Make output names match modesetting driver src/qxl_drmmode.c | 38 -- 1 file changed, 20 insertions(+), 18 deletions(-) -- 2.17.2 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
[PATCH 1/2] Make output name numbering 0-based
The QXL driver names its outputs starting at 0 (e.g. Virtual-0, Virtual-1, etc). This code was presumably copy/pasted from a different driver, and is not necessary for the QXL driver. Other drivers simply use the kernel connector_type_id which starts at 1. For example, the modesetting driver changed from 1-based names to 1-based names for the same reason in xserver commit 139e36dd. This will help to make it easier to identify which xrandr outputs belong to which drm connector without requiring as many driver-specific special-cases. This change might effect custom xorg configurations that references a specific output name. But the same change was made in modesetting driver despite that possibility. Signed-off-by: Jonathon Jongsma Acked-by: Frediano Ziglio --- src/qxl_drmmode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qxl_drmmode.c b/src/qxl_drmmode.c index a2f84b1..a814859 100644 --- a/src/qxl_drmmode.c +++ b/src/qxl_drmmode.c @@ -765,8 +765,7 @@ drmmode_output_init(ScrnInfoPtr pScrn, drmmode_ptr drmmode, int num) } } - /* need to do smart conversion here for compat with non-kms ATI driver */ - snprintf(name, 32, "%s-%d", output_names[koutput->connector_type], koutput->connector_type_id - 1); + snprintf(name, 32, "%s-%d", output_names[koutput->connector_type], koutput->connector_type_id); output = xf86OutputCreate (pScrn, &drmmode_output_funcs, name); -- 2.17.2 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
[PATCH 2/2] Make output names match modesetting driver
The xrandr output name used by the QXL driver is based on the drm
connector type, but the names do not match the kernel names (see
/drivers/gpu/drm/drm_connector.c) or the modesetting driver names (see
hw/xfree86/drivers/modesetting/drmmode_display.c). Making these more
consistent will require less driver-specific special-case code if a user
wants to match an xrandr output to a drm connector.
Note that this patch should not actually change any behavior, since the
QXL driver only uses the 'Virtual' connector type, so this is done only
for consistency.
Signed-off-by: Jonathon Jongsma
Acked-by: Frediano Ziglio
---
src/qxl_drmmode.c | 35 +++
1 file changed, 19 insertions(+), 16 deletions(-)
diff --git a/src/qxl_drmmode.c b/src/qxl_drmmode.c
index a814859..8ebc708 100644
--- a/src/qxl_drmmode.c
+++ b/src/qxl_drmmode.c
@@ -720,22 +720,25 @@ static int subpixel_conv_table[7] = { 0, SubPixelUnknown,
SubPixelVerticalBGR,
SubPixelNone };
-const char *output_names[] = { "None",
- "VGA",
- "DVI",
- "DVI",
- "DVI",
- "Composite",
- "S-video",
- "LVDS",
- "CTV",
- "DIN",
- "DisplayPort",
- "HDMI",
- "HDMI",
- "TV",
- "eDP",
- "Virtual"
+const char *output_names[] = {
+"None",
+"VGA",
+"DVI-I",
+"DVI-D",
+"DVI-A",
+"Composite",
+"SVIDEO",
+"LVDS",
+"Component",
+"DIN",
+"DP",
+"HDMI",
+"HDMI-B",
+"TV",
+"eDP",
+"Virtual",
+"DSI",
+"DPI",
};
static void
--
2.17.2
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
[PATCH app/xcursorgen v3] Update README for gitlab migration
Signed-off-by: Alan Coopersmith --- v2: Moved to README.md and reduced whitespace in front of URLs so that gitlab renders them as links instead of code fragements - see https://gitlab.freedesktop.org/alanc/xcursorgen for formatted view Restored link to Submitting Patches page so that we have a place to provide instructions on how we use gitlab. Removed GitPage link. Changed mailman link from fd.o to x.org URL v3: Change remaining http URLs to https README| 25 - README.md | 17 + 2 files changed, 17 insertions(+), 25 deletions(-) delete mode 100644 README create mode 100644 README.md diff --git a/README b/README deleted file mode 100644 index 6e46f96..000 --- a/README +++ /dev/null @@ -1,25 +0,0 @@ -xcursorgen prepares X11 cursor sets for use with libXcursor. - -All questions regarding this software should be directed at the -Xorg mailing list: - -http://lists.freedesktop.org/mailman/listinfo/xorg - -Please submit bug reports to the Xorg bugzilla: - -https://bugs.freedesktop.org/enter_bug.cgi?product=xorg - -The master development code repository can be found at: - -git://anongit.freedesktop.org/git/xorg/app/xcursorgen - -http://cgit.freedesktop.org/xorg/app/xcursorgen - -For patch submission instructions, see: - - http://www.x.org/wiki/Development/Documentation/SubmittingPatches - -For more information on the git code manager, see: - -http://wiki.x.org/wiki/GitPage - diff --git a/README.md b/README.md new file mode 100644 index 000..a935f4e --- /dev/null +++ b/README.md @@ -0,0 +1,17 @@ +xcursorgen prepares X11 cursor sets for use with libXcursor. + +All questions regarding this software should be directed at the +Xorg mailing list: + + https://lists.x.org/mailman/listinfo/xorg + +The master development code repository can be found at: + + https://gitlab.freedesktop.org/xorg/app/xcursorgen + +Please submit bug reports and requests to merge patches there. + +For patch submission instructions, see: + + https://www.x.org/wiki/Development/Documentation/SubmittingPatches + -- 2.15.2 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH app/xlsatoms 1/3] Support xcb_atom_t in range specification.
Thanks - I've pushed all four patches to git master now: https://gitlab.freedesktop.org/xorg/app/xlsatoms/commits/master -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - https://blogs.oracle.com/alanc ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
[PATCH] dix/window: Use ConfigureWindow instead of MoveWindow
The screensaver can regularly move its window to random offsets. It should
use the ConfigureWindow function instead of calling the Screen's MoveWindow
directly. Some MoveWindow implementations, such as compMoveWindow, rely on
Screen's ConfigNotify being called first as it happens in ConfigureWindow.
---
This fixes abort from assertion failure if compositing is used together with
screensaver configured using "xset s 2 1 s noblank" command.
The compCopyWindow function would abort because of:
assert(cw->oldx != COMP_ORIGIN_INVALID);
Because the cw->oldx is set from compReallocPixmap which is only called
from compConfigNotify.
Alternatively, if the MoveWindow is supposed to work independently, the
compMoveWindow must be adapted to handle the case when oldx/oldy is
set to COMP_ORIGIN_INVALID.
dix/window.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/dix/window.c b/dix/window.c
index 2b599e788..f4ace76c7 100644
--- a/dix/window.c
+++ b/dix/window.c
@@ -3094,6 +3094,7 @@ int
dixSaveScreens(ClientPtr client, int on, int mode)
{
int rc, i, what, type;
+XID vlist[2];
if (on == SCREEN_SAVER_FORCER) {
if (mode == ScreenSaverReset)
@@ -3146,14 +3147,11 @@ dixSaveScreens(ClientPtr client, int on, int mode)
* for the root window, so PaintWindow works
*/
screenIsSaved = SCREEN_SAVER_OFF;
-(*pWin->drawable.pScreen->MoveWindow) (pWin,
- (short) (-
-(rand() %
-
RANDOM_WIDTH)),
- (short) (-
-(rand() %
-
RANDOM_WIDTH)),
- pWin->nextSib, VTMove);
+
+vlist[0] = -(rand() % RANDOM_WIDTH);
+vlist[1] = -(rand() % RANDOM_WIDTH);
+ConfigureWindow(pWin, CWX | CWY, vlist, client);
+
screenIsSaved = SCREEN_SAVER_ON;
}
/*
--
2.16.4
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xf86-video-vmware] Remove obsolete B16 & B32 tags in struct definitions
Hi, On Sat, 2018-11-10 at 13:12 -0800, Alan Coopersmith wrote: > They were defined as empty strings on all platforms except for the > long unsupported Cray systems which needed to use bitfields to define > any type smaller than 64-bits. > > Signed-off-by: Alan Coopersmith > Thanks, Alan. Reviewed and pushed. /Thomas ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
