Re: [PATCH xf86-video-trident 1/3] Tab to spaces conversion for blade_accel.c

2019-02-22 Thread Kevin Brace
Hi Walter,

I am keeping the dead code for reference purpose only.

Regards,

Kevin Brace
Brace Computer Laboratory blog
https://bracecomputerlab.com


> Sent: Thursday, February 21, 2019 at 12:15 PM
> From: "Walter Harms" 
> To: "Kevin Brace" , xorg-devel@lists.x.org
> Subject: Re: [PATCH xf86-video-trident 1/3] Tab to spaces conversion for 
> blade_accel.c
>
> maybe it is cheaper to kill the dead code instead of fixing white space ?
> 
> re,
>  wh 
> 
> 
> > Kevin Brace  hat am 21. Februar 2019 um 20:55 
> > geschrieben:
> > 
> > 
> > Signed-off-by: Kevin Brace 
> > ---
> >  src/blade_accel.c | 491
> > +++---
> >  1 file changed, 244 insertions(+), 247 deletions(-)
> > 
> > diff --git a/src/blade_accel.c b/src/blade_accel.c
> > index 1645e1d..86a67a2 100644
> > --- a/src/blade_accel.c
> > +++ b/src/blade_accel.c
> > @@ -45,72 +45,72 @@
> >  static void BladeSync(ScrnInfoPtr pScrn);
> >  #if 0
> >  static void BladeSetupForSolidLine(ScrnInfoPtr pScrn, int color,
> > -   int rop, unsigned int planemask);
> > +int rop, unsigned int planemask);
> >  static void BladeSubsequentSolidBresenhamLine(ScrnInfoPtr pScrn,
> > -   int x, int y, int dmaj, int dmin, int e, 
> > -   int len, int octant);
> > +int x, int y, int dmaj, int dmin, int e,
> > +int len, int octant);
> >  static void BladeSubsequentSolidTwoPointLine( ScrnInfoPtr pScrn,
> > -   int x1, int y1, int x2, int y2, int flags); 
> > +int x1, int y1, int x2, int y2, int flags);
> >  static void BladeSetupForDashedLine(ScrnInfoPtr pScrn, int fg, int bg,
> > -   int rop, unsigned int planemask, int length,
> > -   unsigned char *pattern);
> > +int rop, unsigned int planemask, int length,
> > +unsigned char *pattern);
> >  static void BladeSubsequentDashedTwoPointLine( ScrnInfoPtr pScrn,
> > -   int x1, int y1, int x2, int y2, int flags,
> > -   int phase); 
> > +int x1, int y1, int x2, int y2, int flags,
> > +int phase);
> >  #endif
> >  static void BladeSetupForFillRectSolid(ScrnInfoPtr pScrn, int color,
> > -   int rop, unsigned int planemask);
> > +int rop, unsigned int planemask);
> >  static void BladeSubsequentFillRectSolid(ScrnInfoPtr pScrn, int x,
> > -   int y, int w, int h);
> > +int y, int w, int h);
> >  static void BladeSubsequentScreenToScreenCopy(ScrnInfoPtr pScrn,
> > -   int x1, int y1, int x2,
> > -   int y2, int w, int h);
> > +int x1, int y1, int x2,
> > +int y2, int w, int h);
> >  static void BladeSetupForScreenToScreenCopy(ScrnInfoPtr pScrn,
> > -   int xdir, int ydir, int rop, 
> > -unsigned int planemask,
> > -   int transparency_color);
> > +int xdir, int ydir, int rop,
> > +unsigned int planemask,
> > +int transparency_color);
> >  #if 0
> >  static void BladeSetupForScreenToScreenColorExpand(ScrnInfoPtr pScrn,
> > -   int fg, int bg, int rop,
> > -   unsigned int planemask);
> > +int fg, int bg, int rop,
> > +unsigned int planemask);
> >  static void BladeSubsequentScreenToScreenColorExpand(ScrnInfoPtr pScrn,
> > -   int x, int y, int w, int h, int srcx, 
> > int srcy,
> > -   int offset);
> > +int x, int y, int w, int h, int srcx, int srcy,
> > +int offset);
> >  #endif
> >  static void BladeSetupForCPUToScreenColorExpand(ScrnInfoPtr pScrn,
> > -   int fg, int bg, int rop,
> > -   unsigned int planemask);
> > +int fg, int bg, int rop,
> > +unsigned int planemask);
> >  static void BladeSubsequentCPUToScreenColorExpand(ScrnInfoPtr pScrn,
> > -   int x, int y, int w, int h, int skipleft);
> > -static void BladeSetClippingRectangle(ScrnInfoPtr pScrn, int x1, int y1, 
> > -   int x2, int y2);
> > +int x, int y, int w, int h, int skipleft);
> > +static void BladeSetClippingRectangle(ScrnInfoPtr pScrn, int x1, int y1,
> > +int x2, int y2);
> >  static void BladeDisableClipping(ScrnInfoPtr pScrn);
> > -static void BladeSetupForMono8x8PatternFill(ScrnInfoPtr pScrn, 
> > -   int patternx, int patterny, int fg, int bg, 
> > -   int rop, unsigned int planemask);
> > -static void BladeSubsequentMono8x8PatternFillRect(ScrnInfoPtr pScrn, 
> > -   int patternx, int patterny, int x, int y, 
> > -   int w, int h);
> > +static void 

Re: Maintainer / Owner privileges at xf86-video-vmware

2019-02-22 Thread Daniel Stone
Hi Thomas,

On Fri, 22 Feb 2019 at 13:18, Thomas Hellstrom  wrote:
> I was trying to add Deepak Rawat as a member on the xf86-video-vmware
> project on fdo gitlab. Turns out I have only developer privileges
> there. Could someone please raise that to maintainer or owner?

Bouncing this over to xorg-devel; since moving to GitLab, the admins
are no longer involved in permission changes, but each project can do
that themselves.

Cheers,
Daniel
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: xserver 1.20.4 maintenance release

2019-02-22 Thread Michel Dänzer
On 2019-02-20 10:47 p.m., Adam Jackson wrote:
> Hey, I need one of these, so I've got a merge request posted with some
> bugfixes from master backported:
> 
> https://gitlab.freedesktop.org/xorg/xserver/merge_requests/125
> 
> If there's anything in there you hate, or anything not in there that
> should be, give a shout.

I just wanted to cherry pick another Present fix, but ended up having to
pull in the GitLab CI changes as well:
https://gitlab.freedesktop.org/xorg/xserver/merge_requests/128


> I'd like to push this out sometime this week.

It's great that you're making a 1.20.4 release!

FWIW, might be worth pulling in
https://gitlab.freedesktop.org/xorg/xserver/merge_requests/127 as well,
so you can use make distcheck.


-- 
Earthling Michel Dänzer   |   http://www.amd.com
Libre software enthusiast | Mesa and X developer
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel