Re: X.Org modules which could use some help to release
Oh, forgot one diff, attached now.
Thomas
On Fri, Jul 19, 2019 at 11:26:06PM +0200, Thomas Klausner wrote:
> On Mon, Jul 15, 2019 at 02:31:13PM -0700, Alan Coopersmith wrote:
> > On 7/15/19 4:02 AM, Thomas Klausner wrote:
> > > As a datapoint:
> >
> > Thanks for the info.
> >
> > > Of these, the following have packages in pkgsrc:
> > >
> > > libWindowsWM
> >
> > This is supposed to only be useful on Cygwin, but a Cygwin package search
> > says they don't ship it, and it hasn't had a release since 2009, so I
> > wonder if anyone uses it, or just keeps building it because no one ever
> > said "stop".
> >
> > > libXTrap
> >
> > Similarly, this just seems like something build because they never knew
> > what it was for - do they really have much software that adopted a
> > proposed extension for X11R5, that's been deprecated since XTEST &
> > RECORD came out in X11R6 in 1994? (Oh, hey, time to change 15 -> 25 in
> > https://gitlab.freedesktop.org/xorg/lib/libxtrap/blob/master/README.md )
> >
> > > rstart
> >
> > We dropped this with a note to use ssh X-forwarding instead.
>
> Thanks. I removed these three and xtrap from pkgsrc.
>
> > > and the following:
> > >
> > > beforelight
>
> No local changes.
>
> > > xf86-video-ark
>
> Adaptation to latest xorg-server.
>
> > > xf86-video-newport
>
> Bigger diff, see attachment.
>
> > > xf86-video-tga
>
> Adaptation to latest xorg-server.
>
> > > xf86-video-tseng
>
> Adaptation to latest xorg-server, and some small diffs.
>
> > > xf86-video-xgi
>
> Big diff, see attachment.
>
> > > xf86dga
>
> No local changes.
>
> > > xfwp
>
> No local changes.
>
> > > xvidtune
>
> No changes.
>
> > > are included in NetBSD's xsrc, probably some with patches.
> > >
> > > I can't tell if they are there for historic reasons or if anyone is
> > > actually still using them.
> >
> > Well, NetBSD still claims to support some of the ancient platforms for
> > those drivers, so they might be:
> >
> > - xf86-video-tga - DEC Alpha graphics, for mid-90's systems such as:
> >https://en.wikipedia.org/wiki/DEC_Multia
> >
> > - xf86-video-newport - SGI MIPS workstation graphics:
> >https://en.wikipedia.org/wiki/SGI_Indy#Graphics
> >
> > but those drivers don't seem to be getting all the API/ABI updates, and
> > haven't had releases to make them compatible with any recent X server,
> > so they'd have to be patching them to make them work. Perhaps NetBSD
> > folks who support those platforms should become their maintainers?
>
> I usually can't even get NetBSD committers to send their diffs
> upstream to you, so making them maintainer is even less likely to have
> positive results.
>
> I don't know what the best solution is.
>
> Should we try getting the diffs merged? (See attachments, I can try to
> group them in commits with messages if someone will apply them.)
>
> Cheers,
> Thomas
> mibstore.h and its miInitializeBackingStore() have been otherwise empty
> since at least xorg-server 1.10. remove all reference to them as the
> header is gone in xorg-server 1.18.
>
> Index: dist/src/ark_driver.c
> ===
> RCS file: /cvsroot/xsrc/external/mit/xf86-video-ark/dist/src/ark_driver.c,v
> retrieving revision 1.1.1.4
> retrieving revision 1.2
> diff -u -r1.1.1.4 -r1.2
> --- dist/src/ark_driver.c 23 Jul 2015 01:15:49 - 1.1.1.4
> +++ dist/src/ark_driver.c 16 Aug 2016 01:27:46 - 1.2
> @@ -39,7 +39,6 @@
> #include "compiler.h"
> #include "mipointer.h"
> #include "micmap.h"
> -#include "mibstore.h"
> #include "fb.h"
> #include "ark.h"
>
> @@ -538,7 +537,6 @@
>
> fbPictureInit (pScreen, 0, 0);
>
> - miInitializeBackingStore(pScreen);
> xf86SetBackingStore(pScreen);
>
> if (!pARK->NoAccel) {
> Index: dist/src/newport.h
> ===
> RCS file: /cvsroot/xsrc/external/mit/xf86-video-newport/dist/src/newport.h,v
> retrieving revision 1.1.1.2
> retrieving revision 1.4
> diff -u -r1.1.1.2 -r1.4
> --- dist/src/newport.h23 Jul 2015 01:15:59 - 1.1.1.2
> +++ dist/src/newport.h23 Jul 2015 01:19:16 - 1.4
> @@ -38,6 +38,7 @@
> /* register definitions of the Newport card */
> #include "newport_regs.h"
>
> +#define NEWPORT_REGISTERS 0xf
> #define NEWPORT_BASE_ADDR0 0x1f0f
> #define NEWPORT_BASE_OFFSET 0x0040
> #define NEWPORT_MAX_BOARDS 4
> Index: dist/src/newport_cmap.c
> ===
> RCS file:
> /cvsroot/xsrc/external/mit/xf86-video-newport/dist/src/newport_cmap.c,v
> retrieving revision 1.1.1.1
> retrieving revision 1.2
> diff -u -r1.1.1.1 -r1.2
> --- dist/src/newport_cmap.c 14 Feb 2009 03:04:46 - 1.1.1.1
> +++ dist/src/newport_cmap.c 6 Oct 2009 20:28:14 - 1.2
> @@ -71,7 +71,8 @@
> }
> #endif
> for(i = 0; i < 256; i++) {
> -
Re: X.Org modules which could use some help to release
On Mon, Jul 15, 2019 at 02:31:13PM -0700, Alan Coopersmith wrote:
> On 7/15/19 4:02 AM, Thomas Klausner wrote:
> > As a datapoint:
>
> Thanks for the info.
>
> > Of these, the following have packages in pkgsrc:
> >
> > libWindowsWM
>
> This is supposed to only be useful on Cygwin, but a Cygwin package search
> says they don't ship it, and it hasn't had a release since 2009, so I
> wonder if anyone uses it, or just keeps building it because no one ever
> said "stop".
>
> > libXTrap
>
> Similarly, this just seems like something build because they never knew
> what it was for - do they really have much software that adopted a
> proposed extension for X11R5, that's been deprecated since XTEST &
> RECORD came out in X11R6 in 1994? (Oh, hey, time to change 15 -> 25 in
> https://gitlab.freedesktop.org/xorg/lib/libxtrap/blob/master/README.md )
>
> > rstart
>
> We dropped this with a note to use ssh X-forwarding instead.
Thanks. I removed these three and xtrap from pkgsrc.
> > and the following:
> >
> > beforelight
No local changes.
> > xf86-video-ark
Adaptation to latest xorg-server.
> > xf86-video-newport
Bigger diff, see attachment.
> > xf86-video-tga
Adaptation to latest xorg-server.
> > xf86-video-tseng
Adaptation to latest xorg-server, and some small diffs.
> > xf86-video-xgi
Big diff, see attachment.
> > xf86dga
No local changes.
> > xfwp
No local changes.
> > xvidtune
No changes.
> > are included in NetBSD's xsrc, probably some with patches.
> >
> > I can't tell if they are there for historic reasons or if anyone is
> > actually still using them.
>
> Well, NetBSD still claims to support some of the ancient platforms for
> those drivers, so they might be:
>
> - xf86-video-tga - DEC Alpha graphics, for mid-90's systems such as:
>https://en.wikipedia.org/wiki/DEC_Multia
>
> - xf86-video-newport - SGI MIPS workstation graphics:
>https://en.wikipedia.org/wiki/SGI_Indy#Graphics
>
> but those drivers don't seem to be getting all the API/ABI updates, and
> haven't had releases to make them compatible with any recent X server,
> so they'd have to be patching them to make them work. Perhaps NetBSD
> folks who support those platforms should become their maintainers?
I usually can't even get NetBSD committers to send their diffs
upstream to you, so making them maintainer is even less likely to have
positive results.
I don't know what the best solution is.
Should we try getting the diffs merged? (See attachments, I can try to
group them in commits with messages if someone will apply them.)
Cheers,
Thomas
mibstore.h and its miInitializeBackingStore() have been otherwise empty
since at least xorg-server 1.10. remove all reference to them as the
header is gone in xorg-server 1.18.
Index: dist/src/ark_driver.c
===
RCS file: /cvsroot/xsrc/external/mit/xf86-video-ark/dist/src/ark_driver.c,v
retrieving revision 1.1.1.4
retrieving revision 1.2
diff -u -r1.1.1.4 -r1.2
--- dist/src/ark_driver.c 23 Jul 2015 01:15:49 - 1.1.1.4
+++ dist/src/ark_driver.c 16 Aug 2016 01:27:46 - 1.2
@@ -39,7 +39,6 @@
#include "compiler.h"
#include "mipointer.h"
#include "micmap.h"
-#include "mibstore.h"
#include "fb.h"
#include "ark.h"
@@ -538,7 +537,6 @@
fbPictureInit (pScreen, 0, 0);
- miInitializeBackingStore(pScreen);
xf86SetBackingStore(pScreen);
if (!pARK->NoAccel) {
Index: dist/src/newport.h
===
RCS file: /cvsroot/xsrc/external/mit/xf86-video-newport/dist/src/newport.h,v
retrieving revision 1.1.1.2
retrieving revision 1.4
diff -u -r1.1.1.2 -r1.4
--- dist/src/newport.h 23 Jul 2015 01:15:59 - 1.1.1.2
+++ dist/src/newport.h 23 Jul 2015 01:19:16 - 1.4
@@ -38,6 +38,7 @@
/* register definitions of the Newport card */
#include "newport_regs.h"
+#define NEWPORT_REGISTERS 0xf
#define NEWPORT_BASE_ADDR0 0x1f0f
#define NEWPORT_BASE_OFFSET 0x0040
#define NEWPORT_MAX_BOARDS 4
Index: dist/src/newport_cmap.c
===
RCS file:
/cvsroot/xsrc/external/mit/xf86-video-newport/dist/src/newport_cmap.c,v
retrieving revision 1.1.1.1
retrieving revision 1.2
diff -u -r1.1.1.1 -r1.2
--- dist/src/newport_cmap.c 14 Feb 2009 03:04:46 - 1.1.1.1
+++ dist/src/newport_cmap.c 6 Oct 2009 20:28:14 - 1.2
@@ -71,7 +71,8 @@
}
#endif
for(i = 0; i < 256; i++) {
- NewportCmapSetRGB(pNewport->pNewportRegs, i,
pNewport->txt_colormap[i]);
+ NewportCmapSetRGB(pNewport->pNewportRegs, i,
+ pNewport->txt_colormap[i]);
}
}
@@ -80,8 +81,8 @@
static void NewportCmapFifoWait(NewportRegsPtr pNewportRegs)
{
while(1) {
- pNewportRegs->set.dcbmode = (NPORT_DMODE_ACM0 | NCMAP_PROTOCOL
|
-
Re: [PATCH xf86-video-cirrus] Declare an I2C bus name string as a static type for alp_i2c.c (walter harms)
Am 19.07.2019 01:37, schrieb Kevin Brace: > Hi Walter, > > I am attempting to eliminate compilation warnings from the code. > The previous code causes "const char*" to "char*" compilation warnings. > That's all. > ok, i understand please add this to your patch, it will show up in the log and a seconde person has a chance to figure out what was going on. re, wh > Regards, > > Kevin Brace > Brace Computer Laboratory blog > https://bracecomputerlab.com > > >> Date: Thu, 18 Jul 2019 09:02:52 +0200 >> From: walter harms >> To: xorg-devel@lists.x.org >> Subject: Re: [PATCH xf86-video-cirrus] Declare an I2C bus name string >> as a static type for alp_i2c.c >> Message-ID: <5d30199c.6060...@bfs.de> >> Content-Type: text/plain; charset=UTF-8 >> >> HI, >> thx for your patch, >> would you like to explain why ? >> what problem do you try to solve ? >> >> >> re, >> wh >> >> Am 18.07.2019 04:55, schrieb Kevin Brace: >>> Signed-off-by: Kevin Brace >>> --- >>> src/alp_i2c.c | 9 +++-- >>> 1 file changed, 7 insertions(+), 2 deletions(-) >>> >>> diff --git a/src/alp_i2c.c b/src/alp_i2c.c >>> index 9341543..b52f2c8 100644 >>> --- a/src/alp_i2c.c >>> +++ b/src/alp_i2c.c >>> @@ -16,6 +16,11 @@ >>> #define _ALP_PRIVATE_ >>> #include "alp.h" >>> >>> + >>> +static char strI2CBus1[] = "I2C bus 1"; >>> +static char strI2CBus2[] = "I2C bus 2"; >>> + >>> + >>> /* >>> * Switch between internal I2C bus and external (DDC) bus. >>> * There is one I2C port controlled bu SR08 and the programmable >>> @@ -99,7 +104,7 @@ AlpI2CInit(ScrnInfoPtr pScrn) >>> >>> pCir->I2CPtr1 = I2CPtr; >>> >>> - I2CPtr->BusName= "I2C bus 1"; >>> + I2CPtr->BusName= strI2CBus1; >>> I2CPtr->scrnIndex = pScrn->scrnIndex; >>> I2CPtr->I2CPutBits = AlpI2CPutBits; >>> I2CPtr->I2CGetBits = AlpI2CGetBits; >>> @@ -113,7 +118,7 @@ AlpI2CInit(ScrnInfoPtr pScrn) >>> >>> pCir->I2CPtr2 = I2CPtr; >>> >>> - I2CPtr->BusName= "I2C bus 2"; >>> + I2CPtr->BusName= strI2CBus2; >>> I2CPtr->scrnIndex = pScrn->scrnIndex; >>> I2CPtr->I2CPutBits = AlpI2CPutBits; >>> I2CPtr->I2CGetBits = AlpI2CGetBits; >>> -- >>> 2.17.1 >>> >>> ___ >>> xorg-devel@lists.x.org: X.Org development >>> Archives: http://lists.x.org/archives/xorg-devel >>> Info: https://lists.x.org/mailman/listinfo/xorg-devel >> >> >> -- >> >> Subject: Digest Footer >> >> ___ >> xorg-devel mailing list >> xorg-devel@lists.x.org >> https://lists.x.org/mailman/listinfo/xorg-devel >> >> -- >> >> End of xorg-devel Digest, Vol 126, Issue 8 >> ** >> > ___ > xorg-devel@lists.x.org: X.Org development > Archives: http://lists.x.org/archives/xorg-devel > Info: https://lists.x.org/mailman/listinfo/xorg-devel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
