Re: [RFC PATCH 2/2] Add official support for SiS[M]662[MX] integrated graphics

2020-01-07 Thread Kevin Brace
Hi Adam,

I am the sole author of the SiS[M]662[MX] (SiS662 from hereon) support addition 
patch.
I did not do much with the code since all I did was to treat SiS662 like SiS761 
without the special memory bandwidth check meant for AMD platform's relatively 
high memory access latency. (Thomas Winischhofer put in such code to cope with 
Xv issues.)
SiS761 is PCIe based, and I assume SiS662 works similarly since it is also PCIe 
based.
The only thing is, I do not own a "functioning" mainboard with SiS662, so I 
need someone else to test patch.
I do own SiS662 based ABIT SG-95 mainboard, but the integrated graphics never 
worked in the first place, and the mainboard completely stopped working several 
years ago.
I still have not obtained any feedback regarding if the patches work in the 
first place.
The motivation behind SiS662 support is the eventual merging of iMedia 
Embedded Linux derived SiS iMedia DDX's SiS671/672 support code into the 
upstream SiS DDX.

http://www.linuxconsulting.ro/xorg-drivers/

I used SiS iMedia DDX from Arch Linux AUR as a starting point rather than the 
original SiS iMedia DDX code.

https://aur.archlinux.org/packages/xf86-video-sisimedia/

It took about 2 weeks, but I got SiS iMedia DDX from Arch Linux AUR to boot X 
Server 1.20.
For testing I used Dell OptiPlex FX160.
VGA works, but DVI does not work currently.
I have spoken with one person who semi-maintains SiS DDX Arch Linux AUR about 
donating 30+ patches needed to get SiS iMedia DDX from Arch Linux AUR to 
compile on X Serve 1.20.
They need additional work, but I should be able to get them cleaned up in about 
a week.
That being said, merging SiS iMedia DDX's SiS671/672 support code into the 
upstream SiS DDX will require some effort since there is some code deviation 
between the two.
Adam, since you mentioned the existence of other SiS 662/671/672 patches 
for SiS DDX, let me know where I can find them.
I will like to at least take a look at them.

Regards,

Kevin Brace
Brace Computer Laboratory blog
https://bracecomputerlab.com


> Sent: Tuesday, January 07, 2020 at 2:13 PM
> From: "Adam Jackson" 
> To: "Kevin Brace" , xorg-devel@lists.x.org
> Cc: "Kevin Brace" 
> Subject: Re: [RFC PATCH 2/2] Add official support for SiS[M]662[MX] 
> integrated graphics
>
> On Wed, 2019-12-25 at 12:52 -0600, Kevin Brace wrote:
> > From: Kevin Brace 
> >
> > Signed-off-by: Kevin Brace 
>
> What's the provenance of these changes? I've seen some hacked packages
> for additional SiS device support but never got around to merging them
> all up, would be good to know where this came from.
>
> > -#define IS_SIS661741760761 (IS_SIS661 || IS_SIS741 || IS_SIS760 || 
> > IS_SIS761)
> > +#define IS_SIS661662741760761   (IS_SIS661 || IS_SIS662 || IS_SIS741 || 
> > IS_SIS760 || IS_SIS761)
> >  #define IS_SIS650740((SiS_Pr->ChipType >= SIS_650) && 
> > (SiS_Pr->ChipType < SIS_330))
> >  #define IS_SIS550650740 (IS_SIS550 || IS_SIS650740)
> > -#define IS_SIS650740661741760761(IS_SIS650 || IS_SIS740 || 
> > IS_SIS661741760761)
> > -#define IS_SIS550650740661741760761 (IS_SIS550 || IS_SIS650740661741760761)
> > +#define IS_SIS650740661662741760761 (IS_SIS650 || IS_SIS740 || 
> > IS_SIS661662741760761)
> > +#define IS_SIS550650740661662741760761  (IS_SIS550 || 
> > IS_SIS650740661662741760761)
>
> Ew.
>
> - ajax
>
>
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel


Re: [RFC PATCH 2/2] Add official support for SiS[M]662[MX] integrated graphics

2020-01-07 Thread Adam Jackson
On Wed, 2019-12-25 at 12:52 -0600, Kevin Brace wrote:
> From: Kevin Brace 
> 
> Signed-off-by: Kevin Brace 

What's the provenance of these changes? I've seen some hacked packages
for additional SiS device support but never got around to merging them
all up, would be good to know where this came from.

> -#define IS_SIS661741760761   (IS_SIS661 || IS_SIS741 || IS_SIS760 || 
> IS_SIS761)
> +#define IS_SIS661662741760761   (IS_SIS661 || IS_SIS662 || IS_SIS741 || 
> IS_SIS760 || IS_SIS761)
>  #define IS_SIS650740((SiS_Pr->ChipType >= SIS_650) && 
> (SiS_Pr->ChipType < SIS_330))
>  #define IS_SIS550650740 (IS_SIS550 || IS_SIS650740)
> -#define IS_SIS650740661741760761(IS_SIS650 || IS_SIS740 || 
> IS_SIS661741760761)
> -#define IS_SIS550650740661741760761 (IS_SIS550 || IS_SIS650740661741760761)
> +#define IS_SIS650740661662741760761 (IS_SIS650 || IS_SIS740 || 
> IS_SIS661662741760761)
> +#define IS_SIS550650740661662741760761  (IS_SIS550 || 
> IS_SIS650740661662741760761)

Ew.

- ajax

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel