AW: [PATCH] mi: sprite: SaveUnderCursor2
hi Madhurkiran Harikrishnan,
my experience is that readability reduced rapidly with indent-level.
I would suggest:
if ( ! DevHasCursor(pDev) continue;
pCursorInfo = GetSprite(pDev);
if (!pCursorInfo) continue; // just to shrink the if ()
// no braces needed
if ( pCursorInfo->isUp &&
pCursorInfo->pScreen == pScreen)
miSpriteSaveUnderCursor(pDev, pScreen);
jm2c
re,
wh
Von: xorg-devel im Auftrag von Madhurkiran
Harikrishnan
Gesendet: Montag, 8. März 2021 23:09
An: xorg-devel@lists.x.org
Cc: Madhurkiran Harikrishnan; Hyun Kwon
Betreff: [PATCH] mi: sprite: SaveUnderCursor2
From: Hyun Kwon
Signed-off-by: Hyun Kwon
Signed-off-by: Madhurkiran Harikrishnan
---
mi/mipointer.h | 2 ++
mi/misprite.c | 17 +
2 files changed, 19 insertions(+)
diff --git a/mi/mipointer.h b/mi/mipointer.h
index 7ce6409..107b24f 100644
--- a/mi/mipointer.h
+++ b/mi/mipointer.h
@@ -127,4 +127,6 @@ extern _X_EXPORT DevPrivateKeyRec miPointerScreenKeyRec;
#define miPointerScreenKey ()
+extern _X_EXPORT void miDCSaveUnderCursor2(ScreenPtr pScreen);
+
#endif /* MIPOINTER_H */
diff --git a/mi/misprite.c b/mi/misprite.c
index add2c55..46ce9f0 100644
--- a/mi/misprite.c
+++ b/mi/misprite.c
@@ -955,3 +955,20 @@ miSpriteComputeSaved(DeviceIntPtr pDev, ScreenPtr pScreen)
pCursorInfo->saved.x2 = pCursorInfo->saved.x1 + w + wpad * 2;
pCursorInfo->saved.y2 = pCursorInfo->saved.y1 + h + hpad * 2;
}
+
+void
+miDCSaveUnderCursor2(ScreenPtr pScreen)
+{
+ DeviceIntPtr pDev;
+ miCursorInfoPtr pCursorInfo;
+
+ for (pDev = inputInfo.devices; pDev; pDev = pDev->next) {
+ if (DevHasCursor(pDev)) {
+ pCursorInfo = GetSprite(pDev);
+ if (pCursorInfo && pCursorInfo->isUp
+ && pCursorInfo->pScreen == pScreen) {
+ miSpriteSaveUnderCursor(pDev, pScreen);
+ }
+ }
+ }
+}
--
2.7.4
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] mi: sprite: SaveUnderCursor2
Hi,
On 3/8/21 11:09 PM, Madhurkiran Harikrishnan wrote:
> From: Hyun Kwon
There should be a block of text here explaining what this new function
does, why it is needed, etc.
Please submit a new version with an actual commit message describing
the what and why of this patch.
Regards,
Hans
>
> Signed-off-by: Hyun Kwon
> Signed-off-by: Madhurkiran Harikrishnan
> ---
> mi/mipointer.h | 2 ++
> mi/misprite.c | 17 +
> 2 files changed, 19 insertions(+)
>
> diff --git a/mi/mipointer.h b/mi/mipointer.h
> index 7ce6409..107b24f 100644
> --- a/mi/mipointer.h
> +++ b/mi/mipointer.h
> @@ -127,4 +127,6 @@ extern _X_EXPORT DevPrivateKeyRec miPointerScreenKeyRec;
>
> #define miPointerScreenKey ()
>
> +extern _X_EXPORT void miDCSaveUnderCursor2(ScreenPtr pScreen);
> +
> #endif /* MIPOINTER_H */
> diff --git a/mi/misprite.c b/mi/misprite.c
> index add2c55..46ce9f0 100644
> --- a/mi/misprite.c
> +++ b/mi/misprite.c
> @@ -955,3 +955,20 @@ miSpriteComputeSaved(DeviceIntPtr pDev, ScreenPtr
> pScreen)
> pCursorInfo->saved.x2 = pCursorInfo->saved.x1 + w + wpad * 2;
> pCursorInfo->saved.y2 = pCursorInfo->saved.y1 + h + hpad * 2;
> }
> +
> +void
> +miDCSaveUnderCursor2(ScreenPtr pScreen)
> +{
> + DeviceIntPtr pDev;
> + miCursorInfoPtr pCursorInfo;
> +
> + for (pDev = inputInfo.devices; pDev; pDev = pDev->next) {
> + if (DevHasCursor(pDev)) {
> + pCursorInfo = GetSprite(pDev);
> + if (pCursorInfo && pCursorInfo->isUp
> + && pCursorInfo->pScreen == pScreen) {
> + miSpriteSaveUnderCursor(pDev, pScreen);
> + }
> + }
> + }
> +}
>
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
[PATCH] mi: sprite: SaveUnderCursor2
From: Hyun Kwon
Signed-off-by: Hyun Kwon
Signed-off-by: Madhurkiran Harikrishnan
---
mi/mipointer.h | 2 ++
mi/misprite.c | 17 +
2 files changed, 19 insertions(+)
diff --git a/mi/mipointer.h b/mi/mipointer.h
index 7ce6409..107b24f 100644
--- a/mi/mipointer.h
+++ b/mi/mipointer.h
@@ -127,4 +127,6 @@ extern _X_EXPORT DevPrivateKeyRec miPointerScreenKeyRec;
#define miPointerScreenKey ()
+extern _X_EXPORT void miDCSaveUnderCursor2(ScreenPtr pScreen);
+
#endif /* MIPOINTER_H */
diff --git a/mi/misprite.c b/mi/misprite.c
index add2c55..46ce9f0 100644
--- a/mi/misprite.c
+++ b/mi/misprite.c
@@ -955,3 +955,20 @@ miSpriteComputeSaved(DeviceIntPtr pDev, ScreenPtr pScreen)
pCursorInfo->saved.x2 = pCursorInfo->saved.x1 + w + wpad * 2;
pCursorInfo->saved.y2 = pCursorInfo->saved.y1 + h + hpad * 2;
}
+
+void
+miDCSaveUnderCursor2(ScreenPtr pScreen)
+{
+ DeviceIntPtr pDev;
+ miCursorInfoPtr pCursorInfo;
+
+ for (pDev = inputInfo.devices; pDev; pDev = pDev->next) {
+ if (DevHasCursor(pDev)) {
+ pCursorInfo = GetSprite(pDev);
+ if (pCursorInfo && pCursorInfo->isUp
+ && pCursorInfo->pScreen == pScreen) {
+ miSpriteSaveUnderCursor(pDev, pScreen);
+ }
+ }
+ }
+}
--
2.7.4
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
