Re: [PATCH xserver] xfree86/modes: Make colormap/gamma glue code work with RandR disabled
On Wed, 12 Apr 2017 18:34:39 +0900
Michel Dänzer <mic...@daenzer.net> wrote:
> From: Michel Dänzer <michel.daen...@amd.com>
>
> E.g. because Xinerama is enabled.
>
> Fixes crash on startup and wrong colours in that case.
>
> Bugzilla: https://bugs.freedesktop.org/100293
> Bugzilla: https://bugs.freedesktop.org/100294
> Fixes: 62f44052573b ("xfree86/modes: Move gamma initialization to
> xf86RandR12Init12 v2")
>
> Signed-off-by: Michel Dänzer <michel.daen...@amd.com>
Tested-by: Mariusz Bialonczyk <ma...@skyboo.net>
---
Indeed, xorg is not crashing and colors are correct with xinerama.
Thank you very much for the fix! :)
Please merge this upstream.
regards,
--
Mariusz Białończyk | xmpp/e-mail: ma...@skyboo.net
http://manio.skyboo.net | https://github.com/manio
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver] xf86_crtc_supports_gamma: Return FALSE if RandR is disabled
On Thu, 6 Apr 2017 15:15:00 +0900 Michel Dänzer <mic...@daenzer.net> wrote: > On 06/04/17 12:27 PM, Alex Deucher wrote: > > On Wed, Apr 5, 2017 at 11:23 PM, Michel Dänzer <mic...@daenzer.net> wrote: > >> From: Michel Dänzer <michel.daen...@amd.com> > >> > >> E.g. becuase Xinerama is enabled. > >> > >> Fixes crash on server startup when RandR is disabled and all other > >> conditions in xf86_crtc_supports_gamma are satisfied. > >> > >> Bugzilla: https://bugs.freedesktop.org/100293 > >> Signed-off-by: Michel Dänzer <michel.daen...@amd.com> > > > > Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > > Thanks, Alex. However, after thinking about this bug and related > https://bugs.freedesktop.org/show_bug.cgi?id=100294 some more, I suspect > we might end up needing a different fix. Tested-by: Mariusz Bialonczyk <ma...@skyboo.net> FWIW: the patch indeed fixes the xorg crash Regarding bug #100294, I've added a photo from monitors, for you to see what I am talking about: https://bugs.freedesktop.org/attachment.cgi?id=130733 https://bugs.freedesktop.org/attachment.cgi?id=130734 In the same time the third monitor was constantly black, only cursor was visible. Moving a window to this screen shows nothing (black) - maybe the gamma was set to zero, or something like this? Of course when I did a screenshot from xorg, all is fine: https://bugs.freedesktop.org/attachment.cgi?id=130735 regards, -- Mariusz Białończyk | xmpp/e-mail: ma...@skyboo.net http://manio.skyboo.net | https://github.com/manio ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
[PATCH xserver] configure.ac: fix checking for libdrm version after 9232835bd
Fix commit 9232835bd16b6948442f7a4588fb9376782cb814 glamor: use drmGetDeviceNameFromFD2 when available No matter what libdrm version was installed, it always set the GLAMOR_HAS_DRM_NAME_FROM_FD_2 conditional to 1. This obviously leads to compilation problems. Signed-off-by: Mariusz Bialonczyk <ma...@skyboo.net> Cc: Qiang Yu <qiang...@amd.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index ac11e6572..0f2f68abb 100644 --- a/configure.ac +++ b/configure.ac @@ -2167,7 +2167,7 @@ if test "x$GLAMOR" = xyes; then fi fi - PKG_CHECK_MODULES(LIBDRM, "libdrm >= 2.4.74", + PKG_CHECK_EXISTS(libdrm >= 2.4.74, [AC_DEFINE(GLAMOR_HAS_DRM_NAME_FROM_FD_2, 1, [Have GLAMOR_HAS_DRM_NAME_FROM_FD_2])], []) fi AM_CONDITIONAL([GLAMOR_EGL], [test "x$GBM" = xyes]) -- 2.11.0 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
