Re: [ANNOUNCE] xorg-server 1.19.0
On Thu, Nov 17, 2016 at 09:55:01AM +1000, Peter Hutterer wrote: > On Wed, Nov 16, 2016 at 02:18:29PM +0100, Thomas Klausner wrote: > > The release breaks most currently existing graphics driver releases > > and two input driver releases (details below). > > yes, a driver released for an older X server is not guaranteed to work with > a newer x server. that's usually expected, we have to wait for a server > release before we can release the drivers (yes, pre-releases are possible, > but these are not the most interesting drivers). I agree for most of these, but wonder about the intel and qxl ones, which do have quite a bit of activity in git. > now that we have a server release, we can start releasing the drivers. I'll > be doing the input ones ove the next couple of days. Thank you for the releases! Thomas ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [ANNOUNCE] xorg-server 1.19.0
On Wed, Nov 16, 2016 at 02:18:29PM +0100, Thomas Klausner wrote: > The release breaks most currently existing graphics driver releases > and two input driver releases (details below). yes, a driver released for an older X server is not guaranteed to work with a newer x server. that's usually expected, we have to wait for a server release before we can release the drivers (yes, pre-releases are possible, but these are not the most interesting drivers). > What is the proper fix? > When are new releases planned? now that we have a server release, we can start releasing the drivers. I'll be doing the input ones ove the next couple of days. Cheers, Peter > chips: > > ct_driver.c: In function 'chipsBlockHandler': > ct_driver.c:7477:5: error: too many arguments to function > 'pScreen->BlockHandler' > (*pScreen->BlockHandler) (BLOCKHANDLER_ARGS); > ^ > > i740: > > i740_video.c: In function 'I740BlockHandler': > i740_video.c:842:3: error: too many arguments to function > 'pScreen->BlockHandler' >(*pScreen->BlockHandler) (BLOCKHANDLER_ARGS); >^ > > qxl: > > uxa-damage.c: In function 'uxa_damage_chars': > uxa-damage.c:947:5: error: implicit declaration of function > 'QueryGlyphExtents' [-Werror=implicit-function-declaration] > QueryGlyphExtents(font, charinfo, n, ); > ^ > > r128: > > r128_driver.c:1550:5: error: too many arguments to function > 'pScreen->BlockHandler' > (*pScreen->BlockHandler) (BLOCKHANDLER_ARGS); > ^ > > sis: > > sis_driver.c: In function 'SISBlockHandler': > sis_driver.c:8257:5: error: too many arguments to function > 'pScreen->BlockHandler' > (*pScreen->BlockHandler) (BLOCKHANDLER_ARGS); > ^ > > tdfx: > > tdfx_driver.c: In function 'TDFXBlockHandler': > tdfx_driver.c:2668:5: error: too many arguments to function > 'pScreen->BlockHandler' > (*pScreen->BlockHandler) (BLOCKHANDLER_ARGS); > ^ > > amdgpu: > > amdgpu_kms.c:522:2: error: too many arguments to function > 'pScreen->BlockHandler' > (*pScreen->BlockHandler) (BLOCKHANDLER_ARGS); > ^ > > glint: > > glint_driver.c:3475:5: error: too many arguments to function > 'pScreen->BlockHandler' > (*pScreen->BlockHandler) (BLOCKHANDLER_ARGS); > ^ > > savage: > > savage_dri.c: In function 'SAVAGEWakeupHandler': > savage_dri.c:277:4: error: too many arguments to function > 'psav->pDRIInfo->wrap.WakeupHandler' > (*psav->pDRIInfo->wrap.WakeupHandler) (WAKEUPHANDLER_ARGS); > ^ > savage_dri.c: In function 'SAVAGEBlockHandler': > savage_dri.c:321:4: error: too many arguments to function > 'psav->pDRIInfo->wrap.BlockHandler' > (*psav->pDRIInfo->wrap.BlockHandler) (BLOCKHANDLER_ARGS); > ^ > > xgi: > > xgi_driver.c: In function 'XGIBlockHandler': > xgi_driver.c:4503:5: error: too many arguments to function > 'pScreen->BlockHandler' > (*pScreen->BlockHandler) (BLOCKHANDLER_ARGS); > ^ > > ati: > > radeon_kms.c:612:5: error: too many arguments to function > 'pScreen->BlockHandler' > (*pScreen->BlockHandler) (BLOCKHANDLER_ARGS); > ^ > > intel: > > i810_video.c: In function 'I810BlockHandler': > i810_video.c:1149:5: error: too many arguments to function > 'screen->BlockHandler' > (*screen->BlockHandler) (BLOCKHANDLER_ARGS); > ^ > > mga: > > mga_driver.c: In function 'MGABlockHandler': > mga_driver.c:4024:5: error: too many arguments to function > 'pScreen->BlockHandler' > (*pScreen->BlockHandler) (BLOCKHANDLER_ARGS); > ^ > > nv: > > nv_driver.c: In function 'NVBlockHandler': > nv_driver.c:1181:5: error: too many arguments to function > 'pScreen->BlockHandler' > (*pScreen->BlockHandler) (BLOCKHANDLER_ARGS); > ^ > > siliconmotion: > > smi_video.c:2070:5: error: too many arguments to function > 'pScreen->BlockHandler' > (*pScreen->BlockHandler)(BLOCKHANDLER_ARGS); > ^ > > trident: > > trident_driver.c: In function 'TRIDENTBlockHandler': > trident_driver.c:617:5: error: too many arguments to function > 'pScreen->BlockHandler' > (*pScreen->BlockHandler) (BLOCKHANDLER_ARGS); > ^ > > > input-joystick: > > jstk.c: In function 'jstkReadProc': > jstk.c:128:17: error: implicit declaration of function 'RemoveEnabledDevice' > [-Werror=implicit-function-declaration] > RemoveEnabledDevice(pInfo->fd); > ^ > jstk.c:128:17: warning: nested extern declaration of 'RemoveEnabledDevice' > [-Wnested-externs] > jstk.c: In function 'jstkDeviceControlProc': > jstk.c:395:13: error: implicit declaration of function 'AddEnabledDevice' > [-Werror=implicit-function-declaration] > AddEnabledDevice(pInfo->fd); > ^ > > > input-keyboard: > > kbd.c: In function 'KbdProc': > kbd.c:386:2: error: implicit declaration of function 'AddEnabledDevice' > [-Werror=implicit-function-declaration] > AddEnabledDevice(pInfo->fd); > ^ > kbd.c:386:2: warning: nested extern declaration of 'AddEnabledDevice' > [-Wnested-externs] >
Re: [ANNOUNCE] xorg-server 1.19.0
On Wed, Nov 16, 2016 at 02:18:29PM +0100, Thomas Klausner wrote: > The release breaks most currently existing graphics driver releases > and two input driver releases (details below). Most of the drivers are fixed with one of two patches that I found in some of the repositories (by Adam Jackson), attached. Not intel nor qxl though. Are releases planned for those? Thomas commit 78d1138dd6e214a200ca66fa9e439ee3c9270ec8 Author: Adam JacksonDate: Tue Jul 19 10:03:56 2016 -0400 Adapt Block/WakeupHandler signature for ABI 23 Signed-off-by: Adam Jackson diff --git a/src/compat-api.h b/src/compat-api.h index 6bc946f..89976e4 100644 --- a/src/compat-api.h +++ b/src/compat-api.h @@ -75,8 +75,13 @@ #define SCREEN_INIT_ARGS_DECL ScreenPtr pScreen, int argc, char **argv +#if ABI_VIDEODRV_VERSION >= SET_ABI_VERSION(23, 0) +#define BLOCKHANDLER_ARGS_DECL ScreenPtr arg, pointer pTimeout +#define BLOCKHANDLER_ARGS arg, pTimeout +#else #define BLOCKHANDLER_ARGS_DECL ScreenPtr arg, pointer pTimeout, pointer pReadmask #define BLOCKHANDLER_ARGS arg, pTimeout, pReadmask +#endif #define CLOSE_SCREEN_ARGS_DECL ScreenPtr pScreen #define CLOSE_SCREEN_ARGS pScreen commit b99390efcb55d7d4a68e8c595119c1af4426fc0b Author: Adam Jackson Date: Tue Jul 19 10:03:56 2016 -0400 Adapt Block/WakeupHandler signature for ABI 23 Signed-off-by: Adam Jackson diff --git a/src/compat-api.h b/src/compat-api.h index 98ba435..44daea4 100644 --- a/src/compat-api.h +++ b/src/compat-api.h @@ -78,11 +78,19 @@ #define SCREEN_INIT_ARGS_DECL ScreenPtr pScreen, int argc, char **argv +#if ABI_VIDEODRV_VERSION >= SET_ABI_VERSION(23, 0) +#define BLOCKHANDLER_ARGS_DECL ScreenPtr arg, pointer pTimeout +#define BLOCKHANDLER_ARGS arg, pTimeout + +#define WAKEUPHANDLER_ARGS_DECL ScreenPtr arg, unsigned long result +#define WAKEUPHANDLER_ARGS arg, result +#else #define BLOCKHANDLER_ARGS_DECL ScreenPtr arg, pointer pTimeout, pointer pReadmask #define BLOCKHANDLER_ARGS arg, pTimeout, pReadmask #define WAKEUPHANDLER_ARGS_DECL ScreenPtr arg, unsigned long result, pointer read_mask #define WAKEUPHANDLER_ARGS arg, result, read_mask +#endif #define CLOSE_SCREEN_ARGS_DECL ScreenPtr pScreen #define CLOSE_SCREEN_ARGS pScreen ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [ANNOUNCE] xorg-server 1.19.0
The release breaks most currently existing graphics driver releases and two input driver releases (details below). What is the proper fix? When are new releases planned? Thanks, Thomas chips: ct_driver.c: In function 'chipsBlockHandler': ct_driver.c:7477:5: error: too many arguments to function 'pScreen->BlockHandler' (*pScreen->BlockHandler) (BLOCKHANDLER_ARGS); ^ i740: i740_video.c: In function 'I740BlockHandler': i740_video.c:842:3: error: too many arguments to function 'pScreen->BlockHandler' (*pScreen->BlockHandler) (BLOCKHANDLER_ARGS); ^ qxl: uxa-damage.c: In function 'uxa_damage_chars': uxa-damage.c:947:5: error: implicit declaration of function 'QueryGlyphExtents' [-Werror=implicit-function-declaration] QueryGlyphExtents(font, charinfo, n, ); ^ r128: r128_driver.c:1550:5: error: too many arguments to function 'pScreen->BlockHandler' (*pScreen->BlockHandler) (BLOCKHANDLER_ARGS); ^ sis: sis_driver.c: In function 'SISBlockHandler': sis_driver.c:8257:5: error: too many arguments to function 'pScreen->BlockHandler' (*pScreen->BlockHandler) (BLOCKHANDLER_ARGS); ^ tdfx: tdfx_driver.c: In function 'TDFXBlockHandler': tdfx_driver.c:2668:5: error: too many arguments to function 'pScreen->BlockHandler' (*pScreen->BlockHandler) (BLOCKHANDLER_ARGS); ^ amdgpu: amdgpu_kms.c:522:2: error: too many arguments to function 'pScreen->BlockHandler' (*pScreen->BlockHandler) (BLOCKHANDLER_ARGS); ^ glint: glint_driver.c:3475:5: error: too many arguments to function 'pScreen->BlockHandler' (*pScreen->BlockHandler) (BLOCKHANDLER_ARGS); ^ savage: savage_dri.c: In function 'SAVAGEWakeupHandler': savage_dri.c:277:4: error: too many arguments to function 'psav->pDRIInfo->wrap.WakeupHandler' (*psav->pDRIInfo->wrap.WakeupHandler) (WAKEUPHANDLER_ARGS); ^ savage_dri.c: In function 'SAVAGEBlockHandler': savage_dri.c:321:4: error: too many arguments to function 'psav->pDRIInfo->wrap.BlockHandler' (*psav->pDRIInfo->wrap.BlockHandler) (BLOCKHANDLER_ARGS); ^ xgi: xgi_driver.c: In function 'XGIBlockHandler': xgi_driver.c:4503:5: error: too many arguments to function 'pScreen->BlockHandler' (*pScreen->BlockHandler) (BLOCKHANDLER_ARGS); ^ ati: radeon_kms.c:612:5: error: too many arguments to function 'pScreen->BlockHandler' (*pScreen->BlockHandler) (BLOCKHANDLER_ARGS); ^ intel: i810_video.c: In function 'I810BlockHandler': i810_video.c:1149:5: error: too many arguments to function 'screen->BlockHandler' (*screen->BlockHandler) (BLOCKHANDLER_ARGS); ^ mga: mga_driver.c: In function 'MGABlockHandler': mga_driver.c:4024:5: error: too many arguments to function 'pScreen->BlockHandler' (*pScreen->BlockHandler) (BLOCKHANDLER_ARGS); ^ nv: nv_driver.c: In function 'NVBlockHandler': nv_driver.c:1181:5: error: too many arguments to function 'pScreen->BlockHandler' (*pScreen->BlockHandler) (BLOCKHANDLER_ARGS); ^ siliconmotion: smi_video.c:2070:5: error: too many arguments to function 'pScreen->BlockHandler' (*pScreen->BlockHandler)(BLOCKHANDLER_ARGS); ^ trident: trident_driver.c: In function 'TRIDENTBlockHandler': trident_driver.c:617:5: error: too many arguments to function 'pScreen->BlockHandler' (*pScreen->BlockHandler) (BLOCKHANDLER_ARGS); ^ input-joystick: jstk.c: In function 'jstkReadProc': jstk.c:128:17: error: implicit declaration of function 'RemoveEnabledDevice' [-Werror=implicit-function-declaration] RemoveEnabledDevice(pInfo->fd); ^ jstk.c:128:17: warning: nested extern declaration of 'RemoveEnabledDevice' [-Wnested-externs] jstk.c: In function 'jstkDeviceControlProc': jstk.c:395:13: error: implicit declaration of function 'AddEnabledDevice' [-Werror=implicit-function-declaration] AddEnabledDevice(pInfo->fd); ^ input-keyboard: kbd.c: In function 'KbdProc': kbd.c:386:2: error: implicit declaration of function 'AddEnabledDevice' [-Werror=implicit-function-declaration] AddEnabledDevice(pInfo->fd); ^ kbd.c:386:2: warning: nested extern declaration of 'AddEnabledDevice' [-Wnested-externs] kbd.c:400:7: error: implicit declaration of function 'RemoveEnabledDevice' [-Werror=implicit-function-declaration] RemoveEnabledDevice(pInfo->fd); ^ - End forwarded message - ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel