[PATCH:libX11 1/2] Do not return() after exit().

2015-07-19 Thread Thomas Klausner 
Signed-off-by: Thomas Klausner w...@netbsd.org
---
 src/XlibInt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/XlibInt.c b/src/XlibInt.c
index 80c1298..bbc5c82 100644
--- a/src/XlibInt.c
+++ b/src/XlibInt.c
@@ -1256,7 +1256,7 @@ int _XDefaultIOError(
 
}
exit(1);
-return(0); /* dummy - function should never return */
+   /*NOTREACHED*/
 }
 
 
@@ -1465,7 +1465,7 @@ _XIOError (
 else
_XDefaultIOError(dpy);
 exit (1);
-return 0;
+/*NOTREACHED*/
 }
 
 
-- 
2.4.6

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH:libX11 1/2] Do not return() after exit().

2015-07-19 Thread Alan Coopersmith 

On 07/19/15 01:23 AM, Thomas Klausner wrote:

Signed-off-by: Thomas Klausner w...@netbsd.org
---
  src/XlibInt.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/XlibInt.c b/src/XlibInt.c
index 80c1298..bbc5c82 100644
--- a/src/XlibInt.c
+++ b/src/XlibInt.c
@@ -1256,7 +1256,7 @@ int _XDefaultIOError(

}
exit(1);
-return(0); /* dummy - function should never return */
+   /*NOTREACHED*/
  }


@@ -1465,7 +1465,7 @@ _XIOError (
  else
_XDefaultIOError(dpy);
  exit (1);
-return 0;
+/*NOTREACHED*/
  }





Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com

--
-Alan Coopersmith-  alan.coopersm...@oracle.com
 Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel