Re: [PATCH] glx: Fix checking GL version
On 07/05/2012 05:52 PM, Bartosz Brachaczek wrote:
Signed-off-by: Bartosz Brachaczekb.brachac...@gmail.com
Which is weird because the piglit test for this case passed.
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
---
Hi,
I looked at Ian's patch out of curiosity and spotted this typo.
Not sure if I am supposed to send a full-blown patch for this, but
I didn't have a better idea.
glx/glxdri2.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/glx/glxdri2.c b/glx/glxdri2.c
index 1e99179..2db12b6 100644
--- a/glx/glxdri2.c
+++ b/glx/glxdri2.c
@@ -481,7 +481,7 @@ dri2_convert_glx_attribs(unsigned num_attribs, const
uint32_t *attribs,
* don't support OpenGL 3.2 may fail the request for a core profile.
*/
if (*api == __DRI_API_OPENGL_CORE
- (*major_ver 3 || (*major_ver 3 *minor_ver 2))) {
+ (*major_ver 3 || (*major_ver == 3 *minor_ver 2))) {
*api == __DRI_API_OPENGL;
}
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] glx: Fix checking GL version
On 07/06/2012 09:01 AM, Ian Romanick wrote:
On 07/05/2012 05:52 PM, Bartosz Brachaczek wrote:
Signed-off-by: Bartosz Brachaczekb.brachac...@gmail.com
Which is weird because the piglit test for this case passed.
The test failed to catch this error because it creates a context with
the default version, which is 1.0. This is handled by the '*major_ver
3' part. I'll modify the test to try other versions. It gets a bit
trickier because implementations could support
GLX_ARB_create_context_profile but not support 3.0+.
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
---
Hi,
I looked at Ian's patch out of curiosity and spotted this typo.
Not sure if I am supposed to send a full-blown patch for this, but
I didn't have a better idea.
glx/glxdri2.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/glx/glxdri2.c b/glx/glxdri2.c
index 1e99179..2db12b6 100644
--- a/glx/glxdri2.c
+++ b/glx/glxdri2.c
@@ -481,7 +481,7 @@ dri2_convert_glx_attribs(unsigned num_attribs,
const uint32_t *attribs,
* don't support OpenGL 3.2 may fail the request for a core
profile.
*/
if (*api == __DRI_API_OPENGL_CORE
- (*major_ver 3 || (*major_ver 3 *minor_ver 2))) {
+ (*major_ver 3 || (*major_ver == 3 *minor_ver 2))) {
*api == __DRI_API_OPENGL;
}
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH] glx: Fix checking GL version
Signed-off-by: Bartosz Brachaczek b.brachac...@gmail.com
---
Hi,
I looked at Ian's patch out of curiosity and spotted this typo.
Not sure if I am supposed to send a full-blown patch for this, but
I didn't have a better idea.
glx/glxdri2.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/glx/glxdri2.c b/glx/glxdri2.c
index 1e99179..2db12b6 100644
--- a/glx/glxdri2.c
+++ b/glx/glxdri2.c
@@ -481,7 +481,7 @@ dri2_convert_glx_attribs(unsigned num_attribs, const
uint32_t *attribs,
* don't support OpenGL 3.2 may fail the request for a core profile.
*/
if (*api == __DRI_API_OPENGL_CORE
- (*major_ver 3 || (*major_ver 3 *minor_ver 2))) {
+ (*major_ver 3 || (*major_ver == 3 *minor_ver 2))) {
*api == __DRI_API_OPENGL;
}
--
1.7.8.6
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
