Re: [PATCH] pciaccess: remove xorg macros dependency
Daniel Stone wrote: > Agreed, but shouldn't XORG_RELEASE_VERSION be removed in general? At least many of the driver packages use the PACKAGE_VERSION_* macros it sets to report the version number without having to maintain it in both configure.ac and a *.h file. The bits for repackaging the releases with -X11R7.x- added to their names should be deleted from the macro though, as noted in the message I sent to the xorg-macros review thread just now. -- -Alan Coopersmith- alan.coopersm...@sun.com Sun Microsystems, Inc. - X Window System Engineering ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] pciaccess: remove xorg macros dependency
On Fri, 2009-07-17 at 02:05 +1000, Daniel Stone wrote: > On Thu, Jul 16, 2009 at 08:27:12AM -0700, Eric Anholt wrote: > > On Thu, 2009-07-16 at 14:18 +0300, Tiago Vignatti wrote: > > > -m4_ifndef([XORG_MACROS_VERSION], [AC_FATAL([must install xorg-macros 1.2 > > > or later before running autoconf/autogen])]) > > > -XORG_MACROS_VERSION(1.2) > > > AM_CONFIG_HEADER(config.h) > > > > > > # Check for progs > > > AC_PROG_CC > > > AC_PROG_LIBTOOL > > > -XORG_CWARNFLAGS > > > > > > pciids_path=/usr/share/hwdata > > > AC_ARG_WITH(pciids-path, AC_HELP_STRING([--with-pciids-path=PCIIDS_PATH], > > > @@ -108,9 +104,6 @@ AC_CHECK_MEMBER([struct pci_io.pi_sel.pc_domain], > > > AC_SUBST(PCIACCESS_CFLAGS) > > > AC_SUBST(PCIACCESS_LIBS) > > > > > > -XORG_RELEASE_VERSION > > > -XORG_CHANGELOG > > > - > > > AC_OUTPUT([Makefile > > > src/Makefile > > > pciaccess.pc]) > > > > NAK. > > > > Reducing the functionality of the package for no reason. > > Agreed, but shouldn't XORG_RELEASE_VERSION be removed in general? Yeah, XORG_RELEASE_VERSION is terrible, and I think XORG_CHANGELOG is pretty bogus, too. Removing the warning cflags is what I don't like. -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] pciaccess: remove xorg macros dependency
On Thu, Jul 16, 2009 at 08:27:12AM -0700, Eric Anholt wrote: > On Thu, 2009-07-16 at 14:18 +0300, Tiago Vignatti wrote: > > -m4_ifndef([XORG_MACROS_VERSION], [AC_FATAL([must install xorg-macros 1.2 > > or later before running autoconf/autogen])]) > > -XORG_MACROS_VERSION(1.2) > > AM_CONFIG_HEADER(config.h) > > > > # Check for progs > > AC_PROG_CC > > AC_PROG_LIBTOOL > > -XORG_CWARNFLAGS > > > > pciids_path=/usr/share/hwdata > > AC_ARG_WITH(pciids-path, AC_HELP_STRING([--with-pciids-path=PCIIDS_PATH], > > @@ -108,9 +104,6 @@ AC_CHECK_MEMBER([struct pci_io.pi_sel.pc_domain], > > AC_SUBST(PCIACCESS_CFLAGS) > > AC_SUBST(PCIACCESS_LIBS) > > > > -XORG_RELEASE_VERSION > > -XORG_CHANGELOG > > - > > AC_OUTPUT([Makefile > >src/Makefile > > pciaccess.pc]) > > NAK. > > Reducing the functionality of the package for no reason. Agreed, but shouldn't XORG_RELEASE_VERSION be removed in general? Cheers, Daniel pgpHVHfLOtHKO.pgp Description: PGP signature ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] pciaccess: remove xorg macros dependency
On Thu, 2009-07-16 at 14:18 +0300, Tiago Vignatti wrote: > Signed-off-by: Tiago Vignatti > --- > configure.ac |7 --- > 1 files changed, 0 insertions(+), 7 deletions(-) > > diff --git a/configure.ac b/configure.ac > index c55112c..d52ab0e 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -28,15 +28,11 @@ AC_INIT(libpciaccess, 0.10.6, > [https://bugs.freedesktop.org/enter_bug.cgi?produc > AM_INIT_AUTOMAKE([dist-bzip2]) > AM_MAINTAINER_MODE > > -# Require xorg-macros: XORG_CWARNFLAGS, XORG_CHANGELOG > -m4_ifndef([XORG_MACROS_VERSION], [AC_FATAL([must install xorg-macros 1.2 or > later before running autoconf/autogen])]) > -XORG_MACROS_VERSION(1.2) > AM_CONFIG_HEADER(config.h) > > # Check for progs > AC_PROG_CC > AC_PROG_LIBTOOL > -XORG_CWARNFLAGS > > pciids_path=/usr/share/hwdata > AC_ARG_WITH(pciids-path, AC_HELP_STRING([--with-pciids-path=PCIIDS_PATH], > @@ -108,9 +104,6 @@ AC_CHECK_MEMBER([struct pci_io.pi_sel.pc_domain], > AC_SUBST(PCIACCESS_CFLAGS) > AC_SUBST(PCIACCESS_LIBS) > > -XORG_RELEASE_VERSION > -XORG_CHANGELOG > - > AC_OUTPUT([Makefile > src/Makefile > pciaccess.pc]) NAK. Reducing the functionality of the package for no reason. -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] pciaccess: remove xorg macros dependency
Vignatti Tiago (Nokia-D/Helsinki) wrote: > On Thu, Jul 16, 2009 at 02:03:11PM +0200, ext Julien Cristau wrote: >> On Thu, Jul 16, 2009 at 14:53:47 +0300, Vignatti Tiago (Nokia-D/Helsinki) >> wrote: >> >>> On Thu, Jul 16, 2009 at 01:30:22PM +0200, ext Julien Cristau wrote: why? >>> Why pci access library must rely on X server? >>> >> Who said anything about the X server? This is a just bunch of m4 >> macros > > whatever, the library does not need it. Ack? Then the library needs to copy the work previously done by the macros of setting the CFLAGS & generating the changelog from git when making releases. When you're done, all you've done is duplicated code, increasing the maintenance burden, and removed the requirement for people making releases to have X.Org's autoconf macro packages installed. End users see no difference, and I see no benefit in making us work harder just to purge the word "XORG" from the macros. -- -Alan Coopersmith- alan.coopersm...@sun.com Sun Microsystems, Inc. - X Window System Engineering ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] pciaccess: remove xorg macros dependency
On Thu, Jul 16, 2009 at 02:03:11PM +0200, ext Julien Cristau wrote: > On Thu, Jul 16, 2009 at 14:53:47 +0300, Vignatti Tiago (Nokia-D/Helsinki) > wrote: > > > On Thu, Jul 16, 2009 at 01:30:22PM +0200, ext Julien Cristau wrote: > > > > > > why? > > > > Why pci access library must rely on X server? > > > Who said anything about the X server? This is a just bunch of m4 > macros whatever, the library does not need it. Ack? Tiago ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] pciaccess: remove xorg macros dependency
On Thu, Jul 16, 2009 at 14:53:47 +0300, Vignatti Tiago (Nokia-D/Helsinki) wrote: > On Thu, Jul 16, 2009 at 01:30:22PM +0200, ext Julien Cristau wrote: > > > > why? > > Why pci access library must rely on X server? > Who said anything about the X server? This is a just bunch of m4 macros… Cheers, Julien ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] pciaccess: remove xorg macros dependency
On Thu, Jul 16, 2009 at 01:30:22PM +0200, ext Julien Cristau wrote: > > why? Why pci access library must rely on X server? > Also, you don't remove $(CHANGELOG_CMD) from Makefile.am or > $(CWARNFLAGS) from src/Makefile.am… why? Tiago ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] pciaccess: remove xorg macros dependency
why? Also, you don't remove $(CHANGELOG_CMD) from Makefile.am or $(CWARNFLAGS) from src/Makefile.am… Cheers, Julien ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH] pciaccess: remove xorg macros dependency
Signed-off-by: Tiago Vignatti --- configure.ac |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/configure.ac b/configure.ac index c55112c..d52ab0e 100644 --- a/configure.ac +++ b/configure.ac @@ -28,15 +28,11 @@ AC_INIT(libpciaccess, 0.10.6, [https://bugs.freedesktop.org/enter_bug.cgi?produc AM_INIT_AUTOMAKE([dist-bzip2]) AM_MAINTAINER_MODE -# Require xorg-macros: XORG_CWARNFLAGS, XORG_CHANGELOG -m4_ifndef([XORG_MACROS_VERSION], [AC_FATAL([must install xorg-macros 1.2 or later before running autoconf/autogen])]) -XORG_MACROS_VERSION(1.2) AM_CONFIG_HEADER(config.h) # Check for progs AC_PROG_CC AC_PROG_LIBTOOL -XORG_CWARNFLAGS pciids_path=/usr/share/hwdata AC_ARG_WITH(pciids-path, AC_HELP_STRING([--with-pciids-path=PCIIDS_PATH], @@ -108,9 +104,6 @@ AC_CHECK_MEMBER([struct pci_io.pi_sel.pc_domain], AC_SUBST(PCIACCESS_CFLAGS) AC_SUBST(PCIACCESS_LIBS) -XORG_RELEASE_VERSION -XORG_CHANGELOG - AC_OUTPUT([Makefile src/Makefile pciaccess.pc]) -- 1.5.6.3 ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
