Re: [PATCH] uxa: fix missing includes for fstat

2016-04-28 Thread Stefan Dirsch 
On Thu, Apr 28, 2016 at 11:31:51AM +0200, Julien Cristau wrote:
> On Thu, Apr 28, 2016 at 11:06:38 +0200, Stefan Dirsch wrote:
> 
> > On Wed, Apr 27, 2016 at 11:23:10PM +0100, Emil Velikov wrote:
> > > P.S. For xorg-devel patches please set the correct prefix $ git config
> > > --local format.subjectPrefix "PATCH foo". With foo being the
> > > respective project.
> > 
> > Ok. Will do that. Is there a an official policy available for submitting
> > patches to xorg-devel like it exists for Mesa
> > (http://mesa3d.org/devinfo.html#submitting)?
> > 
> http://www.x.org/wiki/Development/Documentation/SubmittingPatches/

Thanks a lot! Very useful indeed!

Stefan

Public Key available
--
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] uxa: fix missing includes for fstat

2016-04-28 Thread Julien Cristau 
On Thu, Apr 28, 2016 at 11:06:38 +0200, Stefan Dirsch wrote:

> On Wed, Apr 27, 2016 at 11:23:10PM +0100, Emil Velikov wrote:
> > P.S. For xorg-devel patches please set the correct prefix $ git config
> > --local format.subjectPrefix "PATCH foo". With foo being the
> > respective project.
> 
> Ok. Will do that. Is there a an official policy available for submitting
> patches to xorg-devel like it exists for Mesa
> (http://mesa3d.org/devinfo.html#submitting)?
> 
http://www.x.org/wiki/Development/Documentation/SubmittingPatches/

Cheers,
Julien
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] uxa: fix missing includes for fstat

2016-04-28 Thread Stefan Dirsch 
On Wed, Apr 27, 2016 at 11:23:10PM +0100, Emil Velikov wrote:
> On 26 April 2016 at 15:07, Stefan Dirsch  wrote:
> > On Tue, Apr 26, 2016 at 01:51:39PM +0100, Chris Wilson wrote:
> >> On Tue, Apr 26, 2016 at 02:42:52PM +0200, Stefan Dirsch wrote:
> >> > From: Dominique Leuenberger 
> >> >
> >> > Without these headers, we can run into build errors like:
> >>
> >> sys/stat.h is already included. Curious.
> >> -Chris
> >
> > I can't see it included by uxa/intel_driver.c. Build still fails for me with
> >
> >   -Werror=implicit-function-declaration
> >
> > being set. Same applies to the patch for sna/intel_driver.c.
> >
> Seems like you've got out of date tree in there.
> 
> commit 369ceec0e4910ba2c37736a59c55c0d6c26433bf
> Author: Chris Wilson 
> Date:   Tue Feb 24 15:25:40 2015 +
> 
> uxa: udev integration depends on fstat and sys/stat.h
> 
> src/uxa/intel_driver.c: In function 'I830HandleUEvents':
> src/uxa/intel_driver.c:738:14: error: storage size of 's' isn't known
> src/uxa/intel_driver.c:746:2: error: implicit declaration of
> function 'fstat' [-Werror=implicit-function-declaration]
> 
> Signed-off-by: Chris Wilson 
> 
> diff --git a/src/uxa/intel_driver.c b/src/uxa/intel_driver.c
> ...

You're right. I must have made something stupid. Probably messed up 2.99.917
and git master. Sorry for the noise!

> P.S. For xorg-devel patches please set the correct prefix $ git config
> --local format.subjectPrefix "PATCH foo". With foo being the
> respective project.

Ok. Will do that. Is there a an official policy available for submitting
patches to xorg-devel like it exists for Mesa
(http://mesa3d.org/devinfo.html#submitting)?

Thanks,
Stefan

Public Key available
--
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] uxa: fix missing includes for fstat

2016-04-27 Thread Emil Velikov 
On 26 April 2016 at 15:07, Stefan Dirsch  wrote:
> On Tue, Apr 26, 2016 at 01:51:39PM +0100, Chris Wilson wrote:
>> On Tue, Apr 26, 2016 at 02:42:52PM +0200, Stefan Dirsch wrote:
>> > From: Dominique Leuenberger 
>> >
>> > Without these headers, we can run into build errors like:
>>
>> sys/stat.h is already included. Curious.
>> -Chris
>
> I can't see it included by uxa/intel_driver.c. Build still fails for me with
>
>   -Werror=implicit-function-declaration
>
> being set. Same applies to the patch for sna/intel_driver.c.
>
Seems like you've got out of date tree in there.

commit 369ceec0e4910ba2c37736a59c55c0d6c26433bf
Author: Chris Wilson 
Date:   Tue Feb 24 15:25:40 2015 +

uxa: udev integration depends on fstat and sys/stat.h

src/uxa/intel_driver.c: In function 'I830HandleUEvents':
src/uxa/intel_driver.c:738:14: error: storage size of 's' isn't known
src/uxa/intel_driver.c:746:2: error: implicit declaration of
function 'fstat' [-Werror=implicit-function-declaration]

Signed-off-by: Chris Wilson 

diff --git a/src/uxa/intel_driver.c b/src/uxa/intel_driver.c
...

Regards
Emil

P.S. For xorg-devel patches please set the correct prefix $ git config
--local format.subjectPrefix "PATCH foo". With foo being the
respective project.
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] uxa: fix missing includes for fstat

2016-04-26 Thread Stefan Dirsch 
On Tue, Apr 26, 2016 at 01:51:39PM +0100, Chris Wilson wrote:
> On Tue, Apr 26, 2016 at 02:42:52PM +0200, Stefan Dirsch wrote:
> > From: Dominique Leuenberger 
> > 
> > Without these headers, we can run into build errors like:
> 
> sys/stat.h is already included. Curious.
> -Chris

I can't see it included by uxa/intel_driver.c. Build still fails for me with

  -Werror=implicit-function-declaration 

being set. Same applies to the patch for sna/intel_driver.c.

Thanks,
Stefan

Public Key available
--
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] uxa: fix missing includes for fstat

2016-04-26 Thread Chris Wilson 
On Tue, Apr 26, 2016 at 02:42:52PM +0200, Stefan Dirsch wrote:
> From: Dominique Leuenberger 
> 
> Without these headers, we can run into build errors like:

sys/stat.h is already included. Curious.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH] uxa: fix missing includes for fstat

2016-04-26 Thread Stefan Dirsch 
From: Dominique Leuenberger 

Without these headers, we can run into build errors like:

intel_driver.c: In function 'I830HandleUEvents':
intel_driver.c:745:14: error: storage size of 's' isn't known

intel_video.c:104:39: warning: initialization discards 'const' qualifier from 
pointer target type [-Wdiscarded-qualifiers]
{XvSettable | XvGettable, -128, 127, "XV_BRIGHTNESS"},
   ^
intel_driver.c:753:6: error: implicit declaration of function 'fstat' 
[-Werror=implicit-function-declaration]
---
 src/uxa/intel_driver.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/uxa/intel_driver.c b/src/uxa/intel_driver.c
index 8f76b34..2cf5998 100644
--- a/src/uxa/intel_driver.c
+++ b/src/uxa/intel_driver.c
@@ -44,6 +44,8 @@ USE OR OTHER DEALINGS IN THE SOFTWARE.
 #include 
 #include 
 #include 
+#include 
+#include 
 
 #include "xorg-server.h"
 #include "xf86.h"
-- 
2.6.2

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel