[PATCH 1/3] xfree86: Report DRI3 as a built-in module

2014-05-12 Thread Chris Wilson 
This is so that drivers can do a runtime check that DRI3 is available,
similar to existing runtime checks performed by the drivers for DRI and
DRI2.

Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk
---
 hw/xfree86/loader/loadmod.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/xfree86/loader/loadmod.c b/hw/xfree86/loader/loadmod.c
index 092bf57..9f54929 100644
--- a/hw/xfree86/loader/loadmod.c
+++ b/hw/xfree86/loader/loadmod.c
@@ -838,6 +838,7 @@ static const char *compiled_in_modules[] = {
 extmod,
 dri,
 dri2,
+dri3,
 NULL
 };
 
-- 
2.0.0.rc2

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 1/3] xfree86: Report DRI3 as a built-in module

2014-05-12 Thread Mark Kettenis 
 From: Chris Wilson ch...@chris-wilson.co.uk
 Date: Mon, 12 May 2014 08:12:37 +0100
 
 This is so that drivers can do a runtime check that DRI3 is available,
 similar to existing runtime checks performed by the drivers for DRI and
 DRI2.

Does that run-time check actually work?  It seems any check based on
compiled_in_modules would detect DRI3 even on platforms that don't
support DRI3 or if the server was built using --disable-dri3.

 ---
  hw/xfree86/loader/loadmod.c | 1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/hw/xfree86/loader/loadmod.c b/hw/xfree86/loader/loadmod.c
 index 092bf57..9f54929 100644
 --- a/hw/xfree86/loader/loadmod.c
 +++ b/hw/xfree86/loader/loadmod.c
 @@ -838,6 +838,7 @@ static const char *compiled_in_modules[] = {
  extmod,
  dri,
  dri2,
 +dri3,
  NULL
  };
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 1/3] xfree86: Report DRI3 as a built-in module

2014-05-12 Thread Chris Wilson 
On Mon, May 12, 2014 at 11:29:58AM +0200, Mark Kettenis wrote:
  From: Chris Wilson ch...@chris-wilson.co.uk
  Date: Mon, 12 May 2014 08:12:37 +0100
  
  This is so that drivers can do a runtime check that DRI3 is available,
  similar to existing runtime checks performed by the drivers for DRI and
  DRI2.
 
 Does that run-time check actually work?  It seems any check based on
 compiled_in_modules would detect DRI3 even on platforms that don't
 support DRI3 or if the server was built using --disable-dri3.

I was just following suit, but you are right...

diff --git a/hw/xfree86/loader/loadmod.c b/hw/xfree86/loader/loadmod.c
index 9f54929..f92ad8d 100644
--- a/hw/xfree86/loader/loadmod.c
+++ b/hw/xfree86/loader/loadmod.c
@@ -838,7 +838,9 @@ static const char *compiled_in_modules[] = {
 extmod,
 dri,
 dri2,
+#if DRI3
 dri3,
+#endif
 NULL
 };

Should do the right thing, I think.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel