Re: [PATCH 16/36] xf86: load modesetting driver on Linux hotplug
On Mon, Jul 2, 2012 at 11:55 PM, Keith Packard kei...@keithp.com wrote: Dave Airlie airl...@gmail.com writes: From: Dave Airlie airl...@redhat.com This driver is currently really the only choice for a hotplug at the moment, we can refine this in the future to try and pick the driver names. We have to reload this as it can get unloaded it not used in the original probe. Should xf86platformAddDevice be doing this module load instead? It's got the module name sitting there. Duplicating kludges for modesetting across two functions seems sub-optimal after all. Yeah I've merged this into the hotplug functions in xf86platformBus, once I get to having some hw other than modesetting driven USB devices, I will probably revisit, the split out a bit more, but this is will work perfectly well for all current use cases. Dave. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH 16/36] xf86: load modesetting driver on Linux hotplug
From: Dave Airlie airl...@redhat.com This driver is currently really the only choice for a hotplug at the moment, we can refine this in the future to try and pick the driver names. We have to reload this as it can get unloaded it not used in the original probe. Signed-off-by: Dave Airlie airl...@redhat.com --- hw/xfree86/os-support/linux/lnx_platform.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/xfree86/os-support/linux/lnx_platform.c b/hw/xfree86/os-support/linux/lnx_platform.c index 76f5583..56887a1 100644 --- a/hw/xfree86/os-support/linux/lnx_platform.c +++ b/hw/xfree86/os-support/linux/lnx_platform.c @@ -138,6 +138,9 @@ void NewGPUDeviceRequest(struct OdevAttributes *attribs) if (old_num == xf86_num_platform_devices) return; +/* force load the modesetting driver for now */ +xf86LoadOneModule(modesetting, NULL); + ret = xf86platformAddDevice(xf86_num_platform_devices-1); if (ret == -1) xf86_remove_platform_device(xf86_num_platform_devices-1); -- 1.7.10.2 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 16/36] xf86: load modesetting driver on Linux hotplug
Dave Airlie airl...@gmail.com writes: From: Dave Airlie airl...@redhat.com This driver is currently really the only choice for a hotplug at the moment, we can refine this in the future to try and pick the driver names. We have to reload this as it can get unloaded it not used in the original probe. Should xf86platformAddDevice be doing this module load instead? It's got the module name sitting there. Duplicating kludges for modesetting across two functions seems sub-optimal after all. -- keith.pack...@intel.com pgpqv1Nq686rc.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
