Re: [PATCH 19/19] x86emu: Undefine _NO_INLINE

2014-09-29 Thread Keith Packard
Mark Kettenis mark.kette...@xs4all.nl writes:

 From: Adam Jackson a...@redhat.com
 Date: Thu, 25 Sep 2014 13:37:35 -0400
 
 Never defined by the server.

 Fairly certain it was never intended to be defined by the server, but
 used as a compile-time option to make debugging easier.

Yeah, when people were careful about using inline and not just leaving
them in the header file to be compiled static everywhere. However, at
this point, I'm pretty sure the server won't compile without inline, so
we shouldn't keep this pretense.

Reviewed-by: Keith Packard kei...@keithp.com

(won't merge until everyone is satisfied with the patch though).

-- 
keith.pack...@intel.com


pgpBQTioD3Qjd.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH 19/19] x86emu: Undefine _NO_INLINE

2014-09-25 Thread Adam Jackson
Never defined by the server.

Signed-off-by: Adam Jackson a...@redhat.com
---
 hw/xfree86/x86emu/x86emu/x86emui.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/xfree86/x86emu/x86emu/x86emui.h 
b/hw/xfree86/x86emu/x86emu/x86emui.h
index 5e20d97..01bd92a 100644
--- a/hw/xfree86/x86emu/x86emu/x86emui.h
+++ b/hw/xfree86/x86emu/x86emu/x86emui.h
@@ -46,7 +46,7 @@
  * dramatically in this case).
  */
 
-#ifdefined(__cplusplus)  !defined(_NO_INLINE)
+#if defined(__cplusplus)
 #define_INLINE inline
 #else
 #define_INLINE static
-- 
1.9.3

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel


Re: [PATCH 19/19] x86emu: Undefine _NO_INLINE

2014-09-25 Thread Mark Kettenis
 From: Adam Jackson a...@redhat.com
 Date: Thu, 25 Sep 2014 13:37:35 -0400
 
 Never defined by the server.

Fairly certain it was never intended to be defined by the server, but
used as a compile-time option to make debugging easier.

 Signed-off-by: Adam Jackson a...@redhat.com
 ---
  hw/xfree86/x86emu/x86emu/x86emui.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/hw/xfree86/x86emu/x86emu/x86emui.h 
 b/hw/xfree86/x86emu/x86emu/x86emui.h
 index 5e20d97..01bd92a 100644
 --- a/hw/xfree86/x86emu/x86emu/x86emui.h
 +++ b/hw/xfree86/x86emu/x86emu/x86emui.h
 @@ -46,7 +46,7 @@
   * dramatically in this case).
   */
  
 -#if  defined(__cplusplus)  !defined(_NO_INLINE)
 +#if defined(__cplusplus)
  #define  _INLINE inline
  #else
  #define  _INLINE static
 -- 
 1.9.3
 
 ___
 xorg-devel@lists.x.org: X.Org development
 Archives: http://lists.x.org/archives/xorg-devel
 Info: http://lists.x.org/mailman/listinfo/xorg-devel
 
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel