Re: [PATCH 32/36] xf86/cursor: fallback to sw cursor if we have slaves present.
On Mon, Jul 2, 2012 at 10:16 PM, Alex Deucher alexdeuc...@gmail.com wrote: On Mon, Jul 2, 2012 at 6:13 AM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com Current USB devices have no hw rendered cursors, so we need the master GPU to render the cursor, so whenever we plug in a slave device, fallback to sw rendered cursors. What about when we have a non-USB output slave that can do hw cursors? We need to overhaul the cursor APIs from what I can see to enable any other scenario, and I have this on my things to look at for 1.14 most likely, Dave. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH 32/36] xf86/cursor: fallback to sw cursor if we have slaves present.
From: Dave Airlie airl...@redhat.com Current USB devices have no hw rendered cursors, so we need the master GPU to render the cursor, so whenever we plug in a slave device, fallback to sw rendered cursors. Signed-off-by: Dave Airlie airl...@redhat.com --- hw/xfree86/ramdac/xf86Cursor.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xfree86/ramdac/xf86Cursor.c b/hw/xfree86/ramdac/xf86Cursor.c index 8b91e05..8d48a75 100644 --- a/hw/xfree86/ramdac/xf86Cursor.c +++ b/hw/xfree86/ramdac/xf86Cursor.c @@ -336,7 +336,7 @@ xf86CursorSetCursor(DeviceIntPtr pDev, ScreenPtr pScreen, CursorPtr pCurs, if (!infoPtr-pScrn-vtSema) ScreenPriv-SavedCursor = pCurs; -if (infoPtr-pScrn-vtSema +if (infoPtr-pScrn-vtSema xorg_list_is_empty(pScreen-pixmap_dirty_list) (ScreenPriv-ForceHWCursorCount || (( #ifdef ARGB_CURSOR -- 1.7.10.2 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 32/36] xf86/cursor: fallback to sw cursor if we have slaves present.
On Mon, Jul 2, 2012 at 6:13 AM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com Current USB devices have no hw rendered cursors, so we need the master GPU to render the cursor, so whenever we plug in a slave device, fallback to sw rendered cursors. What about when we have a non-USB output slave that can do hw cursors? Alex Signed-off-by: Dave Airlie airl...@redhat.com --- hw/xfree86/ramdac/xf86Cursor.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xfree86/ramdac/xf86Cursor.c b/hw/xfree86/ramdac/xf86Cursor.c index 8b91e05..8d48a75 100644 --- a/hw/xfree86/ramdac/xf86Cursor.c +++ b/hw/xfree86/ramdac/xf86Cursor.c @@ -336,7 +336,7 @@ xf86CursorSetCursor(DeviceIntPtr pDev, ScreenPtr pScreen, CursorPtr pCurs, if (!infoPtr-pScrn-vtSema) ScreenPriv-SavedCursor = pCurs; -if (infoPtr-pScrn-vtSema +if (infoPtr-pScrn-vtSema xorg_list_is_empty(pScreen-pixmap_dirty_list) (ScreenPriv-ForceHWCursorCount || (( #ifdef ARGB_CURSOR -- 1.7.10.2 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
