[PATCH app-xdm 6/9] config: comment libxtrans macros as they are order sensitive

2010-11-22 Thread Gaetan Nadon
XTRANS_SECURE_RPC_FLAGS must be called after XTRANS_CONNECTION_FLAGS
which finds libraries like -lsockect, -lnsl or -lws32_32.

The found libraries are pre-pended to $LIBS which is not obvious.

Signed-off-by: Gaetan Nadon mems...@videotron.ca
---
 configure.ac |4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/configure.ac b/configure.ac
index 4d9f198..70d5676 100644
--- a/configure.ac
+++ b/configure.ac
@@ -107,8 +107,10 @@ CHOOSER_CFLAGS=$CHOOSER_CFLAGS
 
 AC_FUNC_FORK
 
+# Find needed libraries for TCP sockets (pre-pended in $LIBS)
 XTRANS_CONNECTION_FLAGS
-dnl Sets $SECURE_RPC to yes or no
+
+# Sets $SECURE_RPC to yes or no using libraries found above from $LIBS
 XTRANS_SECURE_RPC_FLAGS
 AM_CONDITIONAL(HAS_SECURE_RPC, test x$SECURE_RPC = xyes)
 
-- 
1.6.0.4

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel


Re: [PATCH app-xdm 6/9] config: comment libxtrans macros as they are order sensitive

2010-11-22 Thread Alan Coopersmith
Gaetan Nadon wrote:
 XTRANS_SECURE_RPC_FLAGS must be called after XTRANS_CONNECTION_FLAGS
 which finds libraries like -lsockect, -lnsl or -lws32_32.

s/-lsockect/-lsocket/

 The found libraries are pre-pended to $LIBS which is not obvious.
 
 Signed-off-by: Gaetan Nadon mems...@videotron.ca
 ---
  configure.ac |4 +++-
  1 files changed, 3 insertions(+), 1 deletions(-)
 
 diff --git a/configure.ac b/configure.ac
 index 4d9f198..70d5676 100644
 --- a/configure.ac
 +++ b/configure.ac
 @@ -107,8 +107,10 @@ CHOOSER_CFLAGS=$CHOOSER_CFLAGS
  
  AC_FUNC_FORK
  
 +# Find needed libraries for TCP sockets (pre-pended in $LIBS)
  XTRANS_CONNECTION_FLAGS
 -dnl Sets $SECURE_RPC to yes or no
 +
 +# Sets $SECURE_RPC to yes or no using libraries found above from $LIBS
  XTRANS_SECURE_RPC_FLAGS
  AM_CONDITIONAL(HAS_SECURE_RPC, test x$SECURE_RPC = xyes)
  

Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com

-- 
-Alan Coopersmith-alan.coopersm...@oracle.com
 Oracle Solaris Platform Engineering: X Window System

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel


[PATCH app-xdm 6/9] config: comment libxtrans macros as they are order sensitive

2010-11-12 Thread Gaetan Nadon
XTRANS_SECURE_RPC_FLAGS must be called after XTRANS_CONNECTION_FLAGS
which finds libraries like -lsockect, -lnsl or -lws32_32.

The found libraries are pre-pended to $LIBS which is not obvious.

Signed-off-by: Gaetan Nadon mems...@videotron.ca
---
 configure.ac |4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/configure.ac b/configure.ac
index 4d9f198..70d5676 100644
--- a/configure.ac
+++ b/configure.ac
@@ -107,8 +107,10 @@ CHOOSER_CFLAGS=$CHOOSER_CFLAGS
 
 AC_FUNC_FORK
 
+# Find needed libraries for TCP sockets (pre-pended in $LIBS)
 XTRANS_CONNECTION_FLAGS
-dnl Sets $SECURE_RPC to yes or no
+
+# Sets $SECURE_RPC to yes or no using libraries found above from $LIBS
 XTRANS_SECURE_RPC_FLAGS
 AM_CONDITIONAL(HAS_SECURE_RPC, test x$SECURE_RPC = xyes)
 
-- 
1.6.0.4

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel