[PATCH libXi] Fix typo when converting raw events from the wire.
From: Carlos Garnacho carl...@gnome.org The raw values were being miscalculated, containing only the integral part of the FP3232, meanwhile normal valuators were mistakenly added the fractional part of its corresponding raw value. Signed-off-by: Carlos Garnacho carl...@gnome.org --- src/XExtInt.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/XExtInt.c b/src/XExtInt.c index 4909ab6..05b4ff2 100644 --- a/src/XExtInt.c +++ b/src/XExtInt.c @@ -1804,7 +1804,7 @@ wireToRawEvent(xXIRawEvent *in, XGenericEventCookie *cookie) out-valuators.values[i] = values-integral; out-valuators.values[i] += ((double)values-frac / (1 16) / (1 16)); out-raw_values[i] = (values + bits)-integral; -out-valuators.values[i] += ((double)(values + bits)-frac / (1 16) / (1 16)); +out-raw_values[i] += ((double)(values + bits)-frac / (1 16) / (1 16)); values++; } -- 1.7.0.4 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH libXi] Fix typo when converting raw events from the wire.
Reviewed-by: Jeremy Huddleston jerem...@apple.com On Oct 6, 2010, at 02:04, Carlos Garnacho wrote: From: Carlos Garnacho carl...@gnome.org The raw values were being miscalculated, containing only the integral part of the FP3232, meanwhile normal valuators were mistakenly added the fractional part of its corresponding raw value. Signed-off-by: Carlos Garnacho carl...@gnome.org --- src/XExtInt.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/XExtInt.c b/src/XExtInt.c index 4909ab6..05b4ff2 100644 --- a/src/XExtInt.c +++ b/src/XExtInt.c @@ -1804,7 +1804,7 @@ wireToRawEvent(xXIRawEvent *in, XGenericEventCookie *cookie) out-valuators.values[i] = values-integral; out-valuators.values[i] += ((double)values-frac / (1 16) / (1 16)); out-raw_values[i] = (values + bits)-integral; -out-valuators.values[i] += ((double)(values + bits)-frac / (1 16) / (1 16)); +out-raw_values[i] += ((double)(values + bits)-frac / (1 16) / (1 16)); values++; } -- 1.7.0.4 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH libXi] Fix typo when converting raw events from the wire.
On Wed, Oct 06, 2010 at 12:27:15PM -0700, Jeremy Huddleston wrote: Reviewed-by: Jeremy Huddleston jerem...@apple.com On Oct 6, 2010, at 02:04, Carlos Garnacho wrote: From: Carlos Garnacho carl...@gnome.org The raw values were being miscalculated, containing only the integral part of the FP3232, meanwhile normal valuators were mistakenly added the fractional part of its corresponding raw value. Signed-off-by: Carlos Garnacho carl...@gnome.org --- src/XExtInt.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/XExtInt.c b/src/XExtInt.c index 4909ab6..05b4ff2 100644 --- a/src/XExtInt.c +++ b/src/XExtInt.c @@ -1804,7 +1804,7 @@ wireToRawEvent(xXIRawEvent *in, XGenericEventCookie *cookie) out-valuators.values[i] = values-integral; out-valuators.values[i] += ((double)values-frac / (1 16) / (1 16)); out-raw_values[i] = (values + bits)-integral; -out-valuators.values[i] += ((double)(values + bits)-frac / (1 16) / (1 16)); +out-raw_values[i] += ((double)(values + bits)-frac / (1 16) / (1 16)); values++; } -- 1.7.0.4 pushed, thanks. Cheers, Peter ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
