Re: [PATCH v2 xserver] xwayland: Enable DRI3 for glamor

2018-07-25 Thread Adam Jackson 
On Wed, 2018-07-25 at 16:33 +0200, Olivier Fourdan wrote:
> glamor_fds_from_pixmap() will bail out early if DRI3 is not enabled,
> unfortunately Xwayland's glamor code would not set it as enabled which
> would lead to blank pixmaps when using texture from pixmap.
> 
> Make sure to mark DRI3 as enabled from glamor_egl_screen_init() in
> Xwayland.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107287
> Fixes: c8c276c956 ("glamor: Implement PixmapFromBuffers and 
> BuffersFromPixmap")
> Signed-off-by: Olivier Fourdan 
> Reviewed-by: Michel Dänzer 

Merged, thanks:

remote: remote: I: patch #239943 updated using rev 
cdec2b3c195d1d080207ef01c55ff14b45370010.
remote: remote: I: 1 patch(es) updated to state Accepted.
remote: To ssh://kemper.freedesktop.org/git/xorg/xserver
remote:ce2dde9ed..cdec2b3c1  cdec2b3c195d1d080207ef01c55ff14b45370010 -> 
master
To ssh://gitlab.freedesktop.org/xorg/xserver
   ce2dde9ed..cdec2b3c1  master -> master

- ajax
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH v2 xserver] xwayland: Enable DRI3 for glamor

2018-07-25 Thread Olivier Fourdan 
glamor_fds_from_pixmap() will bail out early if DRI3 is not enabled,
unfortunately Xwayland's glamor code would not set it as enabled which
would lead to blank pixmaps when using texture from pixmap.

Make sure to mark DRI3 as enabled from glamor_egl_screen_init() in
Xwayland.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107287
Fixes: c8c276c956 ("glamor: Implement PixmapFromBuffers and BuffersFromPixmap")
Signed-off-by: Olivier Fourdan 
Reviewed-by: Michel Dänzer 
---
 v2: Fix "Fixes" vs. "Bugzilla"
 Add Michel's r-b

 hw/xwayland/xwayland-glamor.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/xwayland/xwayland-glamor.c b/hw/xwayland/xwayland-glamor.c
index f17914344..7ea6def61 100644
--- a/hw/xwayland/xwayland-glamor.c
+++ b/hw/xwayland/xwayland-glamor.c
@@ -57,6 +57,7 @@ glamor_egl_screen_init(ScreenPtr screen, struct 
glamor_context *glamor_ctx)
 {
 struct xwl_screen *xwl_screen = xwl_screen_get(screen);
 
+glamor_enable_dri3(screen);
 glamor_ctx->ctx = xwl_screen->egl_context;
 glamor_ctx->display = xwl_screen->egl_display;
 
-- 
2.17.1

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel