Re: [PATCH xf86-input-libinput 1/3] Add a comment regarding scroll dist default values

[Hans de Goede]

Hi,

On 29-11-16 00:25, Peter Hutterer wrote:

Changed this during development because I forgot that the value actually
matters (for touchpads anyway).

Signed-off-by: Peter Hutterer 


Series looks good to me:

Reviewed-by: Hans de Goede 

Regards,

Hans



---
 src/xf86libinput.c | 10 --
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/xf86libinput.c b/src/xf86libinput.c
index 747e84b..324bfc8 100644
--- a/src/xf86libinput.c
+++ b/src/xf86libinput.c
@@ -2928,13 +2928,19 @@ xf86libinput_pre_init(InputDriverPtr drv,

pInfo->private = driver_data;
driver_data->pInfo = pInfo;
-   driver_data->scroll.vdist = 15;
-   driver_data->scroll.hdist = 15;
driver_data->path = path;
driver_data->shared_device = shared_device;
xorg_list_append(_data->shared_device_link,
 _device->device_list);

+   /* Scroll dist value matters for source finger/continuous. For those
+* devices libinput provides pixel-like data, changing this will
+* affect touchpad scroll speed. For wheels it doesn't matter as
+* we're using the discrete value only.
+*/
+   driver_data->scroll.vdist = 15;
+   driver_data->scroll.hdist = 15;
+
if (!is_subdevice) {
if (libinput_device_has_capability(device, 
LIBINPUT_DEVICE_CAP_POINTER))
driver_data->capabilities |= CAP_POINTER;


___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xf86-input-libinput 1/3] Add a comment regarding scroll dist default values

[Peter Hutterer]

Changed this during development because I forgot that the value actually
matters (for touchpads anyway).

Signed-off-by: Peter Hutterer 
---
 src/xf86libinput.c | 10 --
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/xf86libinput.c b/src/xf86libinput.c
index 747e84b..324bfc8 100644
--- a/src/xf86libinput.c
+++ b/src/xf86libinput.c
@@ -2928,13 +2928,19 @@ xf86libinput_pre_init(InputDriverPtr drv,
 
pInfo->private = driver_data;
driver_data->pInfo = pInfo;
-   driver_data->scroll.vdist = 15;
-   driver_data->scroll.hdist = 15;
driver_data->path = path;
driver_data->shared_device = shared_device;
xorg_list_append(_data->shared_device_link,
 _device->device_list);
 
+   /* Scroll dist value matters for source finger/continuous. For those
+* devices libinput provides pixel-like data, changing this will
+* affect touchpad scroll speed. For wheels it doesn't matter as
+* we're using the discrete value only.
+*/
+   driver_data->scroll.vdist = 15;
+   driver_data->scroll.hdist = 15;
+
if (!is_subdevice) {
if (libinput_device_has_capability(device, 
LIBINPUT_DEVICE_CAP_POINTER))
driver_data->capabilities |= CAP_POINTER;
-- 
2.9.3

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel