Re: [PATCH xf86-video-v4l 1/4] Remove unused variable osname

2018-10-07 Thread Dave Airlie
yay, for all 4.

Reviewed-by: Dave Airlie 
On Mon, 8 Oct 2018 at 13:20, Peter Hutterer  wrote:
>
> Coverity is unhappy and there's enough unhappiness in this world already, so
> let's go for the low-hanging fruit.
>
> Signed-off-by: Peter Hutterer 
> ---
>  src/v4l.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/src/v4l.c b/src/v4l.c
> index 8db8f7d..0f1058e 100644
> --- a/src/v4l.c
> +++ b/src/v4l.c
> @@ -86,7 +86,6 @@ _X_EXPORT XF86ModuleData v4lModuleData = { , 
> v4lSetup, NULL };
>  static pointer
>  v4lSetup(pointer module, pointer opts, int *errmaj, int *errmin)
>  {
> -const char *osname;
>  static Bool setupDone = FALSE;
>
>  if (setupDone) {
> --
> 2.17.1
>
> ___
> xorg-devel@lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: https://lists.x.org/mailman/listinfo/xorg-devel
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xf86-video-v4l 1/4] Remove unused variable osname

2018-10-07 Thread Peter Hutterer
Coverity is unhappy and there's enough unhappiness in this world already, so
let's go for the low-hanging fruit.

Signed-off-by: Peter Hutterer 
---
 src/v4l.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/v4l.c b/src/v4l.c
index 8db8f7d..0f1058e 100644
--- a/src/v4l.c
+++ b/src/v4l.c
@@ -86,7 +86,6 @@ _X_EXPORT XF86ModuleData v4lModuleData = { , 
v4lSetup, NULL };
 static pointer
 v4lSetup(pointer module, pointer opts, int *errmaj, int *errmin)
 {
-const char *osname;
 static Bool setupDone = FALSE;
 
 if (setupDone) {
-- 
2.17.1

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel