Re: [PATCH xserver] glamor: Fix dashed line rendering.

2017-03-16 Thread Eric Anholt 
Eric Anholt  writes:

> We were binding the screen pixmap as the dash and sampling its alpha,
> which is usually just 1.0 (no dashing at all).
>
> Please cherry-pick this to active stable branches.

Pushed.  Thanks everyone!


signature.asc
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver] glamor: Fix dashed line rendering.

2017-03-16 Thread Eric Anholt 
Keith Packard  writes:

> [ Unknown signature status ]
> Eric Anholt  writes:
>
>> We were binding the screen pixmap as the dash and sampling its alpha,
>> which is usually just 1.0 (no dashing at all).
>>
>> Please cherry-pick this to active stable branches.
>>
>> Signed-off-by: Eric Anholt 
>
> Thank you for finding this!
>
> Reviewed-by: Keith Packard 
>
> Now, can you explain why it ever did anything reasonable at all?

I'm sure that was just some pre-refactor version.  Sadly, xts doesn't
actually test dashes at all.


signature.asc
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver] glamor: Fix dashed line rendering.

2017-03-15 Thread Michel Dänzer 
On 16/03/17 10:24 AM, Eric Anholt wrote:
> We were binding the screen pixmap as the dash and sampling its alpha,
> which is usually just 1.0 (no dashing at all).
> 
> Please cherry-pick this to active stable branches.
> 
> Signed-off-by: Eric Anholt 
> ---
>  glamor/glamor_dash.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/glamor/glamor_dash.c b/glamor/glamor_dash.c
> index 3c19dba323c7..f3cf749a6785 100644
> --- a/glamor/glamor_dash.c
> +++ b/glamor/glamor_dash.c
> @@ -146,7 +146,7 @@ glamor_dash_setup(DrawablePtr drawable, GCPtr gc)
>  goto bail;
>  
>  dash_pixmap = glamor_get_dash_pixmap(gc);
> -dash_priv = glamor_get_pixmap_private(pixmap);
> +dash_priv = glamor_get_pixmap_private(dash_pixmap);
>  
>  if (!GLAMOR_PIXMAP_PRIV_HAS_FBO(dash_priv))
>  goto bail;
> 

Reviewed-by: Michel Dänzer 


-- 
Earthling Michel Dänzer   |   http://www.amd.com
Libre software enthusiast | Mesa and X developer
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver] glamor: Fix dashed line rendering.

2017-03-15 Thread Keith Packard 
Eric Anholt  writes:

> We were binding the screen pixmap as the dash and sampling its alpha,
> which is usually just 1.0 (no dashing at all).
>
> Please cherry-pick this to active stable branches.
>
> Signed-off-by: Eric Anholt 

Thank you for finding this!

Reviewed-by: Keith Packard 

Now, can you explain why it ever did anything reasonable at all?

-- 
-keith


signature.asc
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xserver] glamor: Fix dashed line rendering.

2017-03-15 Thread Eric Anholt 
We were binding the screen pixmap as the dash and sampling its alpha,
which is usually just 1.0 (no dashing at all).

Please cherry-pick this to active stable branches.

Signed-off-by: Eric Anholt 
---
 glamor/glamor_dash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/glamor/glamor_dash.c b/glamor/glamor_dash.c
index 3c19dba323c7..f3cf749a6785 100644
--- a/glamor/glamor_dash.c
+++ b/glamor/glamor_dash.c
@@ -146,7 +146,7 @@ glamor_dash_setup(DrawablePtr drawable, GCPtr gc)
 goto bail;
 
 dash_pixmap = glamor_get_dash_pixmap(gc);
-dash_priv = glamor_get_pixmap_private(pixmap);
+dash_priv = glamor_get_pixmap_private(dash_pixmap);
 
 if (!GLAMOR_PIXMAP_PRIV_HAS_FBO(dash_priv))
 goto bail;
-- 
2.11.0

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel