Re: [PATCH xserver 4/7] mi: Shortcut miDoCopy/miCopyArea based on paintable not realized

[Keith Packard]

Adam Jackson  writes:

> Signed-off-by: Adam Jackson 

Should we just be checking for empty clip lists instead? It's not quite
as cheap, but we do catch FullyObscurred in the same check.

-- 
-keith


signature.asc
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xserver 4/7] mi: Shortcut miDoCopy/miCopyArea based on paintable not realized

[Adam Jackson]

Signed-off-by: Adam Jackson 
---
 mi/mibitblt.c | 4 ++--
 mi/micopy.c   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/mi/mibitblt.c b/mi/mibitblt.c
index 2de5bf8fd5..8d70e5494e 100644
--- a/mi/mibitblt.c
+++ b/mi/mibitblt.c
@@ -92,9 +92,9 @@ miCopyArea(DrawablePtr pSrcDrawable,
 srcx = xIn + pSrcDrawable->x;
 srcy = yIn + pSrcDrawable->y;
 
-/* If the destination isn't realized, this is easy */
+/* If the destination isn't paintable, this is easy */
 if (pDstDrawable->type == DRAWABLE_WINDOW &&
-!((WindowPtr) pDstDrawable)->realized)
+!((WindowPtr) pDstDrawable)->paintable)
 return NULL;
 
 /* clip the source */
diff --git a/mi/micopy.c b/mi/micopy.c
index 12cdad4ad5..8fb995a540 100644
--- a/mi/micopy.c
+++ b/mi/micopy.c
@@ -155,7 +155,7 @@ miDoCopy(DrawablePtr pSrcDrawable,
 /* Short cut for unmapped windows */
 
 if (pDstDrawable->type == DRAWABLE_WINDOW &&
-!((WindowPtr) pDstDrawable)->realized) {
+!((WindowPtr) pDstDrawable)->paintable) {
 return NULL;
 }
 
-- 
2.17.0

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel