Re: [PATCH xserver v2] meson: Fix epoll detection
Peter Harris writes: > HAVE_OSPOLL is only defined inside this file, not by autoconf/meson, so > it's always defined to 1. > > The rest of os/ospoll.c uses #if instead of #ifdef everywhere. I'd be > inclined to update all of them if I were to paint that particular > bikeshed. Sounds good. I was only looking at the patch in isolation. -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver v2] meson: Fix epoll detection
On 2017-08-14 4:45 PM, Keith Packard wrote: > Peter Harris writes: >> -#if !HAVE_OSPOLL && HAVE_EPOLL_CREATE1 >> +#if !HAVE_OSPOLL && defined(HAVE_EPOLL_CREATE1) > > Should be using defined for HAVE_OSPOLL as well? HAVE_OSPOLL is only defined inside this file, not by autoconf/meson, so it's always defined to 1. The rest of os/ospoll.c uses #if instead of #ifdef everywhere. I'd be inclined to update all of them if I were to paint that particular bikeshed. Peter Harris -- Open Text Connectivity Solutions Group Peter Harrishttp://connectivity.opentext.com/ Research and DevelopmentPhone: +1 905 762 6001 phar...@opentext.comToll Free: 1 877 359 4866 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver v2] meson: Fix epoll detection
Peter Harris writes: > The epoll code depends on epoll_create1, not epoll_create. Reviewed and pushed. Thanks! signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver v2] meson: Fix epoll detection
Peter Harris writes: > The epoll code depends on epoll_create1, not epoll_create. > > Signed-off-by: Peter Harris Thanks! > -#if !HAVE_OSPOLL && HAVE_EPOLL_CREATE1 > +#if !HAVE_OSPOLL && defined(HAVE_EPOLL_CREATE1) Should be using defined for HAVE_OSPOLL as well? -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
