Re: [PATCH xwayland 3/7] xwayland: "Accept" confineTo on InputOnly windows

[Jonas Ådahl]

On Sat, Nov 12, 2016 at 05:25:18PM +0100, Carlos Garnacho wrote:
> Of sorts, actually make it confine to the pointer focus, as the
> InputOnly window is entirely invisible to xwayland accounting,
> we don't have a xwl_window for it.
> 
> Signed-off-by: Carlos Garnacho 
> ---
>  hw/xwayland/xwayland.c | 4 
>  1 file changed, 4 insertions(+)
> 
> diff --git a/hw/xwayland/xwayland.c b/hw/xwayland/xwayland.c
> index ff0e2e5..66b2089 100644
> --- a/hw/xwayland/xwayland.c
> +++ b/hw/xwayland/xwayland.c
> @@ -208,6 +208,10 @@ xwl_cursor_confined_to(DeviceIntPtr device,
>  }
>  
>  xwl_window = xwl_window_from_window(window);
> +if (!xwl_window && window->drawable.class == InputOnly) {
> +DebugF("Confine on InputOnly window, assuming pointer focus\n");
> +xwl_window = xwl_seat->focus_window;
> +}

Same here, should we maybe avoid using windows from other clients here?


Jonas

>  if (!xwl_window)
>  return;
>  
> -- 
> 2.9.3
> 
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xwayland 3/7] xwayland: "Accept" confineTo on InputOnly windows

[Carlos Garnacho]

Of sorts, actually make it confine to the pointer focus, as the
InputOnly window is entirely invisible to xwayland accounting,
we don't have a xwl_window for it.

Signed-off-by: Carlos Garnacho 
---
 hw/xwayland/xwayland.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/hw/xwayland/xwayland.c b/hw/xwayland/xwayland.c
index ff0e2e5..66b2089 100644
--- a/hw/xwayland/xwayland.c
+++ b/hw/xwayland/xwayland.c
@@ -208,6 +208,10 @@ xwl_cursor_confined_to(DeviceIntPtr device,
 }
 
 xwl_window = xwl_window_from_window(window);
+if (!xwl_window && window->drawable.class == InputOnly) {
+DebugF("Confine on InputOnly window, assuming pointer focus\n");
+xwl_window = xwl_seat->focus_window;
+}
 if (!xwl_window)
 return;
 
-- 
2.9.3

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel