Re: [PULL] Implement GLX_ARB_create_context

2012-06-14 Thread Keith Packard
Ian Romanick i...@freedesktop.org writes:

 Ian Romanick (11):
glx: Fix mishandling of shared contexts
glx: Don't track GLClientmajorVersion or GLClientminorVersion
glx: Extend __GLXscreen::createContext to take attributes
glx: Add tracking for GLX_ARB_create_context and 
 GLX_ARB_create_context_profile
glx: Optionally call DRI2 createContextAttribs from 
 __glXDRIscreenCreateContext
glx: Implement GLX SetClientInfoARB protocol
glx: Initialize all context fields together
glx: Initialize remaining context fields
glx: Use one function to add a context to all global tables
glx: Make several functions available outside the glxcmds.c 
 compilation unit
glx: Implement protocol for glXCreateContextAttribsARB

Merged.
   db9d2b8..ffb47a1  master - master

-- 
keith.pack...@intel.com


pgpH6jc97SYC9.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PULL] Implement GLX_ARB_create_context

2012-06-08 Thread Ian Romanick

The following changes since commit 9bc53d8cb04af2be3feeebb1b10774c2d599a76b:

  dri2: SProcDRI2Connect - send the response. (2012-05-22 21:19:40 -0700)

are available in the git repository at:
  ssh+git://people.freedesktop.org/~idr/xserver.git GLX_ARB_create_context

Ian Romanick (11):
  glx: Fix mishandling of shared contexts
  glx: Don't track GLClientmajorVersion or GLClientminorVersion
  glx: Extend __GLXscreen::createContext to take attributes
  glx: Add tracking for GLX_ARB_create_context and 
GLX_ARB_create_context_profile
  glx: Optionally call DRI2 createContextAttribs from 
__glXDRIscreenCreateContext

  glx: Implement GLX SetClientInfoARB protocol
  glx: Initialize all context fields together
  glx: Initialize remaining context fields
  glx: Use one function to add a context to all global tables
  glx: Make several functions available outside the glxcmds.c 
compilation unit

  glx: Implement protocol for glXCreateContextAttribsARB

 configure.ac   |2 +-
 glx/clientinfo.c   |   49 +++-
 glx/createcontext.c|  213 
+++-

 glx/extension_string.c |   34 
 glx/extension_string.h |4 +-
 glx/glxcmds.c  |   77 +-
 glx/glxcontext.h   |   13 +++
 glx/glxdri.c   |   12 +++-
 glx/glxdri2.c  |  161 +++--
 glx/glxdriswrast.c |   12 +++-
 glx/glxext.c   |   13 ++-
 glx/glxext.h   |2 +-
 glx/glxscreens.h   |5 +-
 glx/glxserver.h|2 -
 14 files changed, 525 insertions(+), 74 deletions(-)
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel


Re: [PULL] Implement GLX_ARB_create_context

2012-05-17 Thread Keith Packard
Ian Romanick i...@freedesktop.org writes:

   glx: Extend __GLXscreen::createContext to take attributes

This doesn't even compile - a missing comma:

__glXDRIscreenCreateContext(__GLXscreen * baseScreen,
__GLXconfig * glxConfig,
__GLXcontext * baseShareContext,
unsigned num_attribs,
const uint32_t *attribs
int *error)

Are you sure you've actually run this code?

-- 
keith.pack...@intel.com


pgpPn6JXuIxhy.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PULL] Implement GLX_ARB_create_context

2012-05-17 Thread Ian Romanick

On 05/17/2012 04:37 PM, Keith Packard wrote:

Ian Romanicki...@freedesktop.org  writes:


   glx: Extend __GLXscreen::createContext to take attributes


This doesn't even compile - a missing comma:

__glXDRIscreenCreateContext(__GLXscreen * baseScreen,
 __GLXconfig * glxConfig,
 __GLXcontext * baseShareContext,
 unsigned num_attribs,
 const uint32_t *attribs
 int *error)

Are you sure you've actually run this code?


Oh bother.  Yes, I ran it a bunch of times.

Then I got some review comments about warnings, formatting, etc.  Being 
lazy, I fixed the issues without re-running.  This particular function 
was missing the (unused) error parameter.  In v2 of the patch, I added 
the parameter to remove a compiler warning.  num_attribs, attribs, and 
error are unused in the DRI1 version of this function.  They're only 
used in the DRI2 backend.


I'll fix the missing comma, re-run my test, and send another pull 
request.  Ugh.

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel


[PULL] Implement GLX_ARB_create_context

2012-05-07 Thread Ian Romanick
The following changes since commit 97041364a6acb2b66b5cfd06757c90a006ad50e9:

  Merge remote-tracking branch 'whot/for-keith' (2012-05-02 20:47:25 -0700)

are available in the git repository at:

  ssh+git://people.freedesktop.org/~idr/xserver.git GLX_ARB_create_context

Ian Romanick (11):
  glx: Fix mishandling of shared contexts
  glx: Don't track GLClientmajorVersion or GLClientminorVersion
  glx: Extend __GLXscreen::createContext to take attributes
  glx: Add tracking for GLX_ARB_create_context and 
GLX_ARB_create_context_profile
  glx: Optionally call DRI2 createContextAttribs from 
__glXDRIscreenCreateContext
  glx: Implement GLX SetClientInfoARB protocol
  glx: Initialize all context fields together
  glx: Initialize remaining context fields
  glx: Use one function to add a context to all global tables
  glx: Make several functions available outside the glxcmds.c compilation 
unit
  glx: Implement protocol for glXCreateContextAttribsARB

 configure.ac   |2 +-
 glx/clientinfo.c   |   49 +++-
 glx/createcontext.c|  213 +++-
 glx/extension_string.c |   34 
 glx/extension_string.h |4 +-
 glx/glxcmds.c  |   77 +-
 glx/glxcontext.h   |   13 +++
 glx/glxdri.c   |   12 +++-
 glx/glxdri2.c  |  161 +++--
 glx/glxdriswrast.c |   12 +++-
 glx/glxext.c   |   13 ++-
 glx/glxext.h   |2 +-
 glx/glxscreens.h   |5 +-
 glx/glxserver.h|2 -
 14 files changed, 525 insertions(+), 74 deletions(-)


pgpcjfOxdwzkL.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel