Re: [xproto] Add XF86XK_Keyboard

[Hans de Goede]

Hi,

On 19-04-17 15:26, Christian Kellner wrote:

From: Christian Kellner 

The 2017 Thinkpad models have a new hotkey with a keyboard symbols
on it, which is mapped to KEY_KEYBOARD in the kernel.

Signed-off-by: Christian Kellner 


Since Peter said he was going to push this patch and I'm preparing
a patch adding some more symbols which would conflict I've gone ahead
and pushed this patch.

Regards,

Hans



---
  XF86keysym.h | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/XF86keysym.h b/XF86keysym.h
index 8b5646e..89d40b8 100644
--- a/XF86keysym.h
+++ b/XF86keysym.h
@@ -197,6 +197,8 @@
  
  #define XF86XK_AudioMicMute	0x1008FFB2   /* Mute the Mic from the system */
  
+#define XF86XK_Keyboard		0x1008FFB3   /* User defined keyboard related action */

+
  /* Keys for special action keys (hot keys) */
  /* Virtual terminals on some operating systems */
  #define XF86XK_Switch_VT_10x1008FE01


___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xproto] Add XF86XK_Keyboard

[Peter Hutterer]

On Fri, Apr 21, 2017 at 10:38:42AM +0200, Christian Kellner wrote:
> 
> > We are not XFree86, and are not adding new XF86 keysyms as the note
> > at the top of XF86keysym.h says. Instead keysyms should be added to
> > keysymdef.h and the files listed in the big comment at the top of it.
> 
> I did indeed see the 'big comment' while making the change, but when I 
> looked for a good place in keysymdef.h to put this key nothing obvious
> seemed like the right place. The "Misc functions" group doesn't seem to
> have any values left to use. Maybe a new group in the "XK_XKB_KEYS"
> section?
> 
> While discussing this issue (on IRC) with Daniel Stone and a few others
> it was pointed out that the intention to not add symbols toXF86keysym.h
>   might be a relict from era where XFree86 was still "more active" (to
> put it nicely). So still in doubt after all the discussions I decided
> to put it in XF86keysym.h was the easiest and despite "the big comment"
> maybe still the best option; mainly I wanted to get advice where to
> exactly put this keysym (and future ones as there might be more like
> this key in the near future since there are quite a few umapped input
> key events).

I agree, I think we can stop caring about 'XFree86 owns that scope' and
should just add them where it's make sense. All the other special symbols
are in there, many of those added after the split (and the proportion of
users who even know what xfree86 was is shrinking too). 

So unless Alan has any serious objections, I'll go ahead and push this patch
in the next day or two.

Cheers,
   Peter
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xproto] Add XF86XK_Keyboard

[Christian Kellner]

> We are not XFree86, and are not adding new XF86 keysyms as the note
> at the top of XF86keysym.h says. Instead keysyms should be added to
> keysymdef.h and the files listed in the big comment at the top of it.

I did indeed see the 'big comment' while making the change, but when I 
looked for a good place in keysymdef.h to put this key nothing obvious
seemed like the right place. The "Misc functions" group doesn't seem to
have any values left to use. Maybe a new group in the "XK_XKB_KEYS"
section?

While discussing this issue (on IRC) with Daniel Stone and a few others
it was pointed out that the intention to not add symbols toXF86keysym.h
  might be a relict from era where XFree86 was still "more active" (to
put it nicely). So still in doubt after all the discussions I decided
to put it in XF86keysym.h was the easiest and despite "the big comment"
maybe still the best option; mainly I wanted to get advice where to
exactly put this keysym (and future ones as there might be more like
this key in the near future since there are quite a few umapped input
key events).

Sorry, I meant to add all this to a cover letter to the initial patch,
somehow that got swallowed.

Thanks,
CK 

-- 
Dr. Christian J. Kellner
Desktop Hardware Enablement
Red Hat
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xproto] Add XF86XK_Keyboard

[Alan Coopersmith]

On 04/19/17 06:26 AM, Christian Kellner wrote:

+++ b/XF86keysym.h
@@ -197,6 +197,8 @@

 #define XF86XK_AudioMicMute0x1008FFB2   /* Mute the Mic from the system */

+#define XF86XK_Keyboard0x1008FFB3   /* User defined keyboard 
related action */
+


We are not XFree86, and are not adding new XF86 keysyms as the note at the
top of XF86keysym.h says.   Instead keysyms should be added to keysymdef.h
and the files listed in the big comment at the top of it.

--
-Alan Coopersmith-  alan.coopersm...@oracle.com
 Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xproto] Add XF86XK_Keyboard

[Christian Kellner]

From: Christian Kellner 

The 2017 Thinkpad models have a new hotkey with a keyboard symbols
on it, which is mapped to KEY_KEYBOARD in the kernel.

Signed-off-by: Christian Kellner 
---
 XF86keysym.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/XF86keysym.h b/XF86keysym.h
index 8b5646e..89d40b8 100644
--- a/XF86keysym.h
+++ b/XF86keysym.h
@@ -197,6 +197,8 @@
 
 #define XF86XK_AudioMicMute0x1008FFB2   /* Mute the Mic from the system */
 
+#define XF86XK_Keyboard0x1008FFB3   /* User defined keyboard 
related action */
+
 /* Keys for special action keys (hot keys) */
 /* Virtual terminals on some operating systems */
 #define XF86XK_Switch_VT_1 0x1008FE01
-- 
2.9.3

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel