Re: [xserver PULL master] modesetting HW cursor patches
Thanks Adam! Regards Michael 08.02.2017 18:05, Adam Jackson wrote: On Thu, 2017-02-02 at 11:43 +0100, Michael Thayer wrote: Respectful but rather frustrated ping. Is it still worth my trying to get these changes in or should I just give up? Sorry for the delay. The cursor code is that perfect horrifying intersection of input and output that means I hate reviewing it. (To be fair, apparently so does everybody else...) Fixed up for ickle's input_lock change and merged: remote: E: failed to find patch for rev c02f6a687c3d6bd0727322b055ee788f8fefa005. remote: I: patch #113066 updated using rev ecd0a62323f26b333c49bddd7237dd5118482a35. remote: I: patch #113067 updated using rev eb04b20160d706d4e0e67122d0adb1e723c0da92. remote: I: 2 patch(es) updated to state Accepted. To ssh://git.freedesktop.org/git/xorg/xserver 3ef16df..eb04b20 master -> master - ajax -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstraße 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [xserver PULL master] modesetting HW cursor patches
On Thu, 2017-02-02 at 11:43 +0100, Michael Thayer wrote: > Respectful but rather frustrated ping. Is it still worth my trying to > get these changes in or should I just give up? Sorry for the delay. The cursor code is that perfect horrifying intersection of input and output that means I hate reviewing it. (To be fair, apparently so does everybody else...) Fixed up for ickle's input_lock change and merged: remote: E: failed to find patch for rev c02f6a687c3d6bd0727322b055ee788f8fefa005. remote: I: patch #113066 updated using rev ecd0a62323f26b333c49bddd7237dd5118482a35. remote: I: patch #113067 updated using rev eb04b20160d706d4e0e67122d0adb1e723c0da92. remote: I: 2 patch(es) updated to state Accepted. To ssh://git.freedesktop.org/git/xorg/xserver 3ef16df..eb04b20 master -> master - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [xserver PULL master] modesetting HW cursor patches
Respectful but rather frustrated ping. Is it still worth my trying to get these changes in or should I just give up? Regards Michael 27.01.2017 17:51, Michael Thayer wrote: Hello Adam and Keith, These patches have been hanging around for a while (since October in fact), and never made it into the tree. They were reviewed by Hans, who suggested that I try preparing a rebased branch with the patches and send a pull request. So finally done that. Thanks Michael The following changes since commit 7617a0a180a2cd3427a8ffa9534152df6a8fecbf: dri2: refine dri2_probe_driver_name (v2) (2017-01-25 15:13:33 -0500) are available in the git repository at: https://github.com/michael-thayer/xserver.git for you to fetch changes up to 4163091129eed352166a59c2681edc2da313e436: modesetting: allow switching from software to hardware cursors (v5). (2017-01-27 16:09:08 +0100) Michael Thayer (3): xfree86: Immediately handle failure to set HW cursor, v5 modesetting: Immediately handle failure to set HW cursor, v5 modesetting: allow switching from software to hardware cursors (v5). hw/xfree86/drivers/modesetting/drmmode_display.c | 45 ++-- hw/xfree86/drivers/modesetting/drmmode_display.h | 2 -- hw/xfree86/modes/xf86Crtc.h | 4 ++- hw/xfree86/modes/xf86Cursors.c | 40 +++-- hw/xfree86/ramdac/xf86Cursor.h | 16 + hw/xfree86/ramdac/xf86HWCurs.c | 8 ++--- 6 files changed, 71 insertions(+), 44 deletions(-) -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstraße 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [xserver PULL master] modesetting HW cursor patches
On 28/01/17 06:29 PM, Michael Thayer wrote: > Hello Adam and Keith, > > For some reason you got left off CC on that message. No idea why, you > are still there in the copy in my "sent" folder... It's because Adam and Keith have "Avoid duplicate copies of messages?" enabled in their mailman subscription options for the xorg-devel list. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [xserver PULL master] modesetting HW cursor patches
Hello Adam and Keith, For some reason you got left off CC on that message. No idea why, you are still there in the copy in my "sent" folder... Regards Michael 27.01.2017 17:51, Michael Thayer wrote: Hello Adam and Keith, These patches have been hanging around for a while (since October in fact), and never made it into the tree. They were reviewed by Hans, who suggested that I try preparing a rebased branch with the patches and send a pull request. So finally done that. Thanks Michael The following changes since commit 7617a0a180a2cd3427a8ffa9534152df6a8fecbf: dri2: refine dri2_probe_driver_name (v2) (2017-01-25 15:13:33 -0500) are available in the git repository at: https://github.com/michael-thayer/xserver.git for you to fetch changes up to 4163091129eed352166a59c2681edc2da313e436: modesetting: allow switching from software to hardware cursors (v5). (2017-01-27 16:09:08 +0100) Michael Thayer (3): xfree86: Immediately handle failure to set HW cursor, v5 modesetting: Immediately handle failure to set HW cursor, v5 modesetting: allow switching from software to hardware cursors (v5). hw/xfree86/drivers/modesetting/drmmode_display.c | 45 ++-- hw/xfree86/drivers/modesetting/drmmode_display.h | 2 -- hw/xfree86/modes/xf86Crtc.h | 4 ++- hw/xfree86/modes/xf86Cursors.c | 40 +++-- hw/xfree86/ramdac/xf86Cursor.h | 16 + hw/xfree86/ramdac/xf86HWCurs.c | 8 ++--- 6 files changed, 71 insertions(+), 44 deletions(-) -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstraße 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
[xserver PULL master] modesetting HW cursor patches
Hello Adam and Keith, These patches have been hanging around for a while (since October in fact), and never made it into the tree. They were reviewed by Hans, who suggested that I try preparing a rebased branch with the patches and send a pull request. So finally done that. Thanks Michael The following changes since commit 7617a0a180a2cd3427a8ffa9534152df6a8fecbf: dri2: refine dri2_probe_driver_name (v2) (2017-01-25 15:13:33 -0500) are available in the git repository at: https://github.com/michael-thayer/xserver.git for you to fetch changes up to 4163091129eed352166a59c2681edc2da313e436: modesetting: allow switching from software to hardware cursors (v5). (2017-01-27 16:09:08 +0100) Michael Thayer (3): xfree86: Immediately handle failure to set HW cursor, v5 modesetting: Immediately handle failure to set HW cursor, v5 modesetting: allow switching from software to hardware cursors (v5). hw/xfree86/drivers/modesetting/drmmode_display.c | 45 ++-- hw/xfree86/drivers/modesetting/drmmode_display.h | 2 -- hw/xfree86/modes/xf86Crtc.h | 4 ++- hw/xfree86/modes/xf86Cursors.c | 40 +++-- hw/xfree86/ramdac/xf86Cursor.h | 16 + hw/xfree86/ramdac/xf86HWCurs.c | 8 ++--- 6 files changed, 71 insertions(+), 44 deletions(-) -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstraße 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
