Re: [xserver PULL master] randr fixes + primary GPU fallback
Hi, On 06-12-16 19:06, Adam Jackson wrote: On Tue, 2016-12-06 at 15:22 +0100, Hans de Goede wrote: Hi, On Mon Dec 5 16:54:51 UTC 2016, Adam Jackson wrote: > Not a fan of the autobind patch in terms of upstreaming, I feel like we > really should be able to do better. We've had years to do better And? This is seat configuration. It's something the system should tell us, not something we should guess at. That solves it both for all DEs and for all display servers. No this is not seat configuration, when auto-configuring output devices we already take the seat into account AFAIK, so we only bring up GPUs which are part of the seat the xserver is running for, this is about actually tying these GPUs together, so that they actually form a coherent seat, rather then being claimed by the server (since they belong to the current seat) but not being usable by the end-user unless the end-user first types some black-magic xrandr commands. I find the this is seat configuration pov quite interesting btw, that does nicely solve the policy problem of which devices to bring up in a DE agnostic manner, which means that the one thing which has stopped this patch from going upstream actually has been solved long ago. Regards, Hans ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [xserver PULL master] randr fixes + primary GPU fallback
On Tue, 2016-12-06 at 15:22 +0100, Hans de Goede wrote: > Hi, > > On Mon Dec 5 16:54:51 UTC 2016, Adam Jackson wrote: > > Not a fan of the autobind patch in terms of upstreaming, I feel like we > > really should be able to do better. > > We've had years to do better And? This is seat configuration. It's something the system should tell us, not something we should guess at. That solves it both for all DEs and for all display servers. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [xserver PULL master] randr fixes + primary GPU fallback
Hi, On Mon Dec 5 16:54:51 UTC 2016, Adam Jackson wrote: > Not a fan of the autobind patch in terms of upstreaming, I feel like we > really should be able to do better. We've had years to do better and carried this patch in both Fedora and RHEL for years and nothing better materialized, I think we're really doing (other) downstream users a dis-service by keeping this patch out of upstream. I can only hope that other distros are including it themselves, otherwise a lot of the effort spend on making prime setups work smoothly is wasted, unless users can find the right magic xrandr commands to make things work in google ... Regards, Hans ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [xserver PULL master] randr fixes + primary GPU fallback
On Mon, 2016-12-05 at 11:39 +0100, Hans de Goede wrote: > The following changes since commit e1d30075c923f96a375895d74ea12a3c92a640c6: > > configure: Enable glamor when building just Xwayland (2016-11-30 09:47:43 > +0100) > > are available in the git repository at: > > git://people.freedesktop.org/~jwrdegoede/xserver for-master > > for you to fetch changes up to 55a4ce24fd778627bd1ca65f4735c4568a2332cd: > > xfree86: Try harder to find atleast 1 non GPU Screen (2016-12-05 11:21:49 > +0100) Ugh, that last patch. Well, better than nothing. Merged: remote: I: patch #123074 updated using rev 3b624aa9a9df86dc7d48149e0f18ca223b4355f1. remote: I: patch #123075 updated using rev a46afee84d45fbff4e4dad9376afc95bbcc31d7c. remote: I: patch #112959 updated using rev b72d161cad15bec9dd082d30521c5383be526c56. remote: I: patch #112970 updated using rev 7121b03d324fccf687d49b63c53da7c8d93038c9. remote: I: patch #112971 updated using rev 75c4f6e412e07c5d416fa9ad8d7defd972d2baa9. remote: I: 5 patch(es) updated to state Accepted. To ssh://git.freedesktop.org/git/xorg/xserver e1d3007..75c4f6e master -> master Not a fan of the autobind patch in terms of upstreaming, I feel like we really should be able to do better. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
patchwork.freedesktop.org Re: [xserver PULL master] randr fixes + primary GPU fallback
Am 05.12.2016 11:39, schrieb Hans de Goede: > Hi Adam, Keith, > > > > p.s. > > Talking about unreviewed patched it would be really good to get > a review of / some discussion on: > > https://patchwork.freedesktop.org/patch/112579/ > > Which is the last magic sauce in the Fedora xserver pkgs and > is really important for a smooth ootb experience on laptops > with hybrid gfx. https://patchwork.freedesktop.org contains a bunch of not-yet-processed patches. How can we help/speed up things ? (Note: i am biased several of my patches are also there) re, wh ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
[xserver PULL master] randr fixes + primary GPU fallback
Hi Adam, Keith, Here is a pull-req consisting of 2 different patch-sets: 1) 2 randr fixes for sometimes the screen pixmap being too small when using slave outputs, these have been Reviewed-by Dave Airlie 2) 3 xfree86 patches which together make the xserver choice the first available device, rather then exiting with a "No screens" error, when output devices are found, but non is recognized as being the primary / boot display adapter. This is necessary at least for the simpledrm kms driver, which due to its nature does not get recognized as being the boot display. These 3 patches are *unreviewed*, but have been part of the Fedora xserver pkg since F25 beta and have shown no issues, as such I believe these are ready for merging. The following changes since commit e1d30075c923f96a375895d74ea12a3c92a640c6: configure: Enable glamor when building just Xwayland (2016-11-30 09:47:43 +0100) are available in the git repository at: git://people.freedesktop.org/~jwrdegoede/xserver for-master for you to fetch changes up to 55a4ce24fd778627bd1ca65f4735c4568a2332cd: xfree86: Try harder to find atleast 1 non GPU Screen (2016-12-05 11:21:49 +0100) Hans de Goede (5): randr: rrCheckPixmapBounding: Do not substract crtc non 0 x,y from screen size randr: rrCheckPixmapBounding: do not shrink the screen_pixmap xfree86: Remove redundant ServerIsNotSeat0 check from xf86CallDriverProbe xfree86: Make adding unclaimed devices as GPU devices a separate step xfree86: Try harder to find atleast 1 non GPU Screen hw/xfree86/common/xf86.h| 1 + hw/xfree86/common/xf86Bus.c | 32 +++- hw/xfree86/common/xf86Globals.c | 1 + hw/xfree86/common/xf86pciBus.c | 4 hw/xfree86/common/xf86platformBus.c | 19 +++ hw/xfree86/common/xf86platformBus.h | 6 ++ randr/rrcrtc.c | 10 -- 7 files changed, 66 insertions(+), 7 deletions(-) Regards, Hans p.s. Talking about unreviewed patched it would be really good to get a review of / some discussion on: https://patchwork.freedesktop.org/patch/112579/ Which is the last magic sauce in the Fedora xserver pkgs and is really important for a smooth ootb experience on laptops with hybrid gfx. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
