Re: [PATCH app/xrandr] Document that --dpi and --fbmm options set DPI of whole X screen

[walter harms]

documentation is a painful job, thx for doing this.

re,
 wh

Am 28.05.2017 23:33, schrieb Pali Rohár:
> Explicitly document and make it clear that those options does not change
> DPI of some monitor output. Also state that these options have no useful
> meaning for multi-monitor configuration.
> 
> Signed-off-by: Pali Rohár 
> ---
>  man/xrandr.man |   14 ++
>  1 file changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/man/xrandr.man b/man/xrandr.man
> index 55ea5dd..fec4a1a 100644
> --- a/man/xrandr.man
> +++ b/man/xrandr.man
> @@ -226,14 +226,20 @@ fit within this size. When this option is not provided, 
> xrandr computes the
>  smallest screen size that will hold the set of configured outputs; this
>  option provides a way to override that behaviour.
>  .IP "\-\-fbmm \fIwidth\fPx\fIheight\fP"
> -Sets the reported values for the physical size of the screen. Normally,
> +Sets the reported values for the physical size of the whole X screen (not 
> particular
> +output!) which consists of all configured monitors. Physical size of the X 
> screen does
> +not have any meaning when two monitors with different DPI are configured. 
> Normally,
>  xrandr resets the reported physical size values to keep the DPI constant.
> -This overrides that computation.
> +This overrides that computation. This option should be calculated from DPI
> +value 96 as it not have any useful meaning for multi-monitor configuration.
>  .IP "\-\-dpi \fIdpi\fP"
>  .IP "\-\-dpi \fIfrom-output\fP"
> -This also sets the reported physical size values of the screen, it uses 
> either
> +This also sets the reported physical size values of the whole X screen (not 
> particular
> +output!) which consists of all configured monitors. Physical size of the X 
> screen does not
> +have any meaning when two monitors with different DPI are configured. This 
> option uses either

No number needed:

"have any meaning when monitors with different DPI are configured."

>  the specified DPI value, or the DPI of the given output, to compute an 
> appropriate
> -physical size using whatever pixel size will be set.
> +physical size using whatever pixel size will be set. This option should be 
> set to
> +default value 96 as it not have any useful meaning for multi-monitor 
> configuration.

The "default value 96" is confusing me, perhaps a simple reordering may help:

physical size using whatever pixel size will be set (default 96 DPI). It does 
not have any useful
meaning for multi-monitor configuration.


>  .IP "\-\-newmode \fIname\fP \fImode\fP"
>  New modelines can be added to the server and then associated with outputs.
>  This option does the former. The \fImode\fP is specified using the ModeLine
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH app/xrandr] Document that --dpi and --fbmm options set DPI of whole X screen

[Pali Rohár]

On Sunday 28 May 2017 23:33:59 Pali Rohár wrote:
> Explicitly document and make it clear that those options does not change
> DPI of some monitor output. Also state that these options have no useful
> meaning for multi-monitor configuration.
> 
> Signed-off-by: Pali Rohár 
> ---
>  man/xrandr.man |   14 ++
>  1 file changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/man/xrandr.man b/man/xrandr.man
> index 55ea5dd..fec4a1a 100644
> --- a/man/xrandr.man
> +++ b/man/xrandr.man
> @@ -226,14 +226,20 @@ fit within this size. When this option is not provided, 
> xrandr computes the
>  smallest screen size that will hold the set of configured outputs; this
>  option provides a way to override that behaviour.
>  .IP "\-\-fbmm \fIwidth\fPx\fIheight\fP"
> -Sets the reported values for the physical size of the screen. Normally,
> +Sets the reported values for the physical size of the whole X screen (not 
> particular
> +output!) which consists of all configured monitors. Physical size of the X 
> screen does
> +not have any meaning when two monitors with different DPI are configured. 
> Normally,
>  xrandr resets the reported physical size values to keep the DPI constant.
> -This overrides that computation.
> +This overrides that computation. This option should be calculated from DPI
> +value 96 as it not have any useful meaning for multi-monitor configuration.
>  .IP "\-\-dpi \fIdpi\fP"
>  .IP "\-\-dpi \fIfrom-output\fP"
> -This also sets the reported physical size values of the screen, it uses 
> either
> +This also sets the reported physical size values of the whole X screen (not 
> particular
> +output!) which consists of all configured monitors. Physical size of the X 
> screen does not
> +have any meaning when two monitors with different DPI are configured. This 
> option uses either
>  the specified DPI value, or the DPI of the given output, to compute an 
> appropriate
> -physical size using whatever pixel size will be set.
> +physical size using whatever pixel size will be set. This option should be 
> set to
> +default value 96 as it not have any useful meaning for multi-monitor 
> configuration.
>  .IP "\-\-newmode \fIname\fP \fImode\fP"
>  New modelines can be added to the server and then associated with outputs.
>  This option does the former. The \fImode\fP is specified using the ModeLine

PING, can somebody review this patch?

-- 
Pali Rohár
pali.ro...@gmail.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH app/xrandr] Document that --dpi and --fbmm options set DPI of whole X screen

[Pali Rohár]

On Saturday 10 June 2017 21:19:32 Pali Rohár wrote:
> On Sunday 28 May 2017 23:33:59 Pali Rohár wrote:
> > Explicitly document and make it clear that those options does not
> > change DPI of some monitor output. Also state that these options
> > have no useful meaning for multi-monitor configuration.
> 
> I would like to remind this patch. Can you review/comment it?

Any opinion on this patch?

-- 
Pali Rohár
pali.ro...@gmail.com


signature.asc
Description: This is a digitally signed message part.
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH app/xrandr] Document that --dpi and --fbmm options set DPI of whole X screen

[Pali Rohár]

On Sunday 28 May 2017 23:33:59 Pali Rohár wrote:
> Explicitly document and make it clear that those options does not
> change DPI of some monitor output. Also state that these options
> have no useful meaning for multi-monitor configuration.

I would like to remind this patch. Can you review/comment it?

> Signed-off-by: Pali Rohár 
> ---
>  man/xrandr.man |   14 ++
>  1 file changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/man/xrandr.man b/man/xrandr.man
> index 55ea5dd..fec4a1a 100644
> --- a/man/xrandr.man
> +++ b/man/xrandr.man
> @@ -226,14 +226,20 @@ fit within this size. When this option is not
> provided, xrandr computes the smallest screen size that will hold
> the set of configured outputs; this option provides a way to
> override that behaviour.
>  .IP "\-\-fbmm \fIwidth\fPx\fIheight\fP"
> -Sets the reported values for the physical size of the screen.
> Normally, +Sets the reported values for the physical size of the
> whole X screen (not particular +output!) which consists of all
> configured monitors. Physical size of the X screen does +not have
> any meaning when two monitors with different DPI are configured.
> Normally, xrandr resets the reported physical size values to keep
> the DPI constant. -This overrides that computation.
> +This overrides that computation. This option should be calculated
> from DPI +value 96 as it not have any useful meaning for
> multi-monitor configuration. .IP "\-\-dpi \fIdpi\fP"
>  .IP "\-\-dpi \fIfrom-output\fP"
> -This also sets the reported physical size values of the screen, it
> uses either +This also sets the reported physical size values of the
> whole X screen (not particular +output!) which consists of all
> configured monitors. Physical size of the X screen does not +have
> any meaning when two monitors with different DPI are configured.
> This option uses either the specified DPI value, or the DPI of the
> given output, to compute an appropriate -physical size using
> whatever pixel size will be set.
> +physical size using whatever pixel size will be set. This option
> should be set to +default value 96 as it not have any useful meaning
> for multi-monitor configuration. .IP "\-\-newmode \fIname\fP
> \fImode\fP"
>  New modelines can be added to the server and then associated with
> outputs. This option does the former. The \fImode\fP is specified
> using the ModeLine

-- 
Pali Rohár
pali.ro...@gmail.com


signature.asc
Description: This is a digitally signed message part.
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel