Re: [PATCH xserver 5/7] meson: Make XV optional

2017-05-11 Thread Eric Anholt 
Julien Cristau  writes:

> On Mon, May  8, 2017 at 10:13:52 -0700, Eric Anholt wrote:
>
>> Optional XV seems a bit silly to me.  Could we just do something
>> like:
>> 
>> build_xv = build_xorg || build_dmx || build_ephyr?
>
> FWIW the Xorg build we're shipping in debian installer images (which run
> a single specific gtk2 client) have xv disabled.  I could be convinced
> not to care, though; no idea what the size difference is, or if this
> still matters 7 years later.

Looks like about 70kb total, more than I thought it would be.


signature.asc
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver 5/7] meson: Make XV optional

2017-05-10 Thread Julien Cristau 
On Mon, May  8, 2017 at 10:13:52 -0700, Eric Anholt wrote:

> Optional XV seems a bit silly to me.  Could we just do something
> like:
> 
> build_xv = build_xorg || build_dmx || build_ephyr?

FWIW the Xorg build we're shipping in debian installer images (which run
a single specific gtk2 client) have xv disabled.  I could be convinced
not to care, though; no idea what the size difference is, or if this
still matters 7 years later.

Cheers,
Julien
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver 5/7] meson: Make XV optional

2017-05-09 Thread Olivier Fourdan 
Hey,

On 8 May 2017 at 19:13, Eric Anholt  wrote:

>
> Optional XV seems a bit silly to me.  Could we just do something
> like:
>
> build_xv = build_xorg || build_dmx || build_ephyr?


Does Xwayland fall in one of those 3 categories?

If not, you'd need to add Xwayland to that list as it uses Xv with glamor
as well.

Cheers,
Olivier
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver 5/7] meson: Make XV optional

2017-05-09 Thread Jon Turney 

On 08/05/2017 18:13, Eric Anholt wrote:

Jon Turney  writes:


Signed-off-by: Jon Turney 
---
 meson.build   | 11 ++-
 meson_options.txt |  3 +++
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index c7c9c79c3..5f30b996c 100644
--- a/meson.build
+++ b/meson.build
@@ -251,6 +251,16 @@ if libdrm_dep.found()
   build_modesetting = dependency('libdrm', version: '>= 2.4.46', required: 
false).found()
 endif

+build_xv = false
+if get_option('xv') == 'auto'
+if (host_machine.system() != 'windows' and
+host_machine.system() != 'cygwin')
+build_xv = true
+endif
+else
+build_xv = get_option('xv') == 'yes'
+endif


Optional XV seems a bit silly to me.  Could we just do something
like:

build_xv = build_xorg || build_dmx || build_ephyr?


I'm all for reducing the number of configuration options :)

I think I'll just drop this patch.

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver 5/7] meson: Make XV optional

2017-05-08 Thread Eric Anholt 
Jon Turney  writes:

> Signed-off-by: Jon Turney 
> ---
>  meson.build   | 11 ++-
>  meson_options.txt |  3 +++
>  2 files changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index c7c9c79c3..5f30b996c 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -251,6 +251,16 @@ if libdrm_dep.found()
>build_modesetting = dependency('libdrm', version: '>= 2.4.46', required: 
> false).found()
>  endif
>  
> +build_xv = false
> +if get_option('xv') == 'auto'
> +if (host_machine.system() != 'windows' and
> +host_machine.system() != 'cygwin')
> +build_xv = true
> +endif
> +else
> +build_xv = get_option('xv') == 'yes'
> +endif

Optional XV seems a bit silly to me.  Could we just do something
like:

build_xv = build_xorg || build_dmx || build_ephyr?


signature.asc
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel