Re: xf86-video-vmware compilation issue with xserver built with meson
On Sat, 2019-01-12 at 12:18 +, Tuomo Rinne wrote: > The correct fix would be to use #ifdef statements in the xf86-video-vmware > driver correct? I'm happy to send a patch if this is the case. I think that's the best fix. xserver's never going to do #define XSERVER_LIBPCIACCESS 0 so using #ifdef should be portable. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
xf86-video-vmware compilation issue with xserver built with meson
Hi, There's a different behaviour between the build systems in how they define the variables in xorg-server.h. I've in particular run into problem with variable XSERVER_LIBPCIACCESS. The autotools build system defines this as: #define XSERVER_LIBPCIACCESS 1 whereas meson build system defines this as: #define XSERVER_LIBPCIACCESS The xf86-video-vmware driver has statements such as #if XSERVER_LIBPCIACCESS which causes compilation errors when compiled in conjunction with the meson build of xserver. The correct fix would be to use #ifdef statements in the xf86-video-vmware driver correct? I'm happy to send a patch if this is the case. Thanks, Tuomo ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
