On Saturday 24 October 2015 00:39:22 Amitoj Kaur Chawla wrote:
> This patch replaces timeval with timespec64 as 32 bit 'struct timeval'
> will not give current time beyond 2038.
>
> The patch changes the code to use ktime_get_real_ts64() which returns
> a 'struct timespec64' instead of do_gettimeofday() which returns a
> 'struct timeval'
>
> This patch also alters the format strings in pr_info() for now.tv_sec
> and now.tv_nsec to incorporate 'long long' on 32 bit architectures and
> leading zeroes respectively.
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com>
> ---
The patch looks correct, but I think that this time the format string
was actually ok already for the microsecond value. Just leave it at "%6.6ld"
and send it again with the maintainers on Cc.
> drivers/char/ipmi/ipmi_ssif.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
> index 877205d..926add4 100644
> --- a/drivers/char/ipmi/ipmi_ssif.c
> +++ b/drivers/char/ipmi/ipmi_ssif.c
> @@ -52,6 +52,7 @@
> #include <linux/kthread.h>
> #include <linux/acpi.h>
> #include <linux/ctype.h>
> +#include <linux/time64.h>
>
> #define PFX "ipmi_ssif: "
> #define DEVICE_NAME "ipmi_ssif"
> @@ -1041,12 +1042,12 @@ static void sender(void *send_info,
> start_next_msg(ssif_info, flags);
>
> if (ssif_info->ssif_debug & SSIF_DEBUG_TIMING) {
> - struct timeval t;
> + struct timespec64 t;
>
> - do_gettimeofday(&t);
> - pr_info("**Enqueue %02x %02x: %ld.%6.6ld\n",
> + ktime_get_real_ts64(&t);
> + pr_info("**Enqueue %02x %02x: %lld.%6.06ld\n",
> msg->data[0], msg->data[1],
> - (long) t.tv_sec, (long) t.tv_usec);
> + (long long) t.tv_sec, (long) t.tv_nsec / NSEC_PER_USEC);
> }
> }
>
>
_______________________________________________
Y2038 mailing list
Y2038@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/y2038
