[Yahoo-eng-team] [Bug 1696830] Re: nova-placement-api default config files is too strict

2019-03-11 Thread Chris Dent 
After speaking with coreycb we're going to drop nova/placement from this
as it no longer quite fits and the existing snap related bugs are
sufficient to provide an aide-mémoire.

** Changed in: nova
   Status: In Progress => Won't Fix

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1696830

Title:
  nova-placement-api default config files is too strict

Status in OpenStack Compute (nova):
  Won't Fix
Status in oslo.config:
  Fix Released
Status in Glance Snap:
  Fix Released
Status in Keystone Snap:
  Fix Released
Status in Neutron Snap:
  Fix Released
Status in Nova Snap:
  Fix Released
Status in Nova Hypervisor Snap:
  Fix Released

Bug description:
  If nova.conf doesn't exist in the typical location of
  /etc/nova/nova.conf and OS_PLACEMENT_CONFIG_DIR isn't set, nova-
  placement-api's wsgi application will fail. In our case with the
  OpenStack snap, we have two possible paths we may pick nova.conf up
  from, based on what --config-file specifies. I think the right answer
  here is to be a bit more flexible and not set the default config file
  if it's path doesn't exist.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1696830/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

[Yahoo-eng-team] [Bug 1696830] Re: nova-placement-api default config files is too strict

2017-06-22 Thread Corey Bryant 
** Changed in: snap-nova-hypervisor
   Status: New => Fix Released

** Changed in: snap-glance
   Status: New => Fix Released

** Changed in: snap-neutron
   Status: New => Fix Released

** Changed in: nova
 Assignee: Corey Bryant (corey.bryant) => (unassigned)

** Changed in: snap-keystone
   Status: New => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1696830

Title:
  nova-placement-api default config files is too strict

Status in OpenStack Compute (nova):
  Confirmed
Status in oslo.config:
  Fix Released
Status in Glance Snap:
  Fix Released
Status in Keystone Snap:
  Fix Released
Status in Neutron Snap:
  Fix Released
Status in Nova Snap:
  Fix Released
Status in Nova Hypervisor Snap:
  Fix Released

Bug description:
  If nova.conf doesn't exist in the typical location of
  /etc/nova/nova.conf and OS_PLACEMENT_CONFIG_DIR isn't set, nova-
  placement-api's wsgi application will fail. In our case with the
  OpenStack snap, we have two possible paths we may pick nova.conf up
  from, based on what --config-file specifies. I think the right answer
  here is to be a bit more flexible and not set the default config file
  if it's path doesn't exist.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1696830/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

[Yahoo-eng-team] [Bug 1696830] Re: nova-placement-api default config files is too strict

2017-06-22 Thread OpenStack Infra 
Reviewed:  https://review.openstack.org/473615
Committed: 
https://git.openstack.org/cgit/openstack/snap-nova/commit/?id=f011198f5bd93d20fd37a124140d9addbf1a4c29
Submitter: Jenkins
Branch:master

commit f011198f5bd93d20fd37a124140d9addbf1a4c29
Author: Corey Bryant 
Date:   Tue Jun 13 13:14:00 2017 +

Enable nova-placement-api config and logging

nova-placement-api is a bit tricky. The wsgi application doesn't accept
CLI arguments, so we can't pass --config-file, --config-dir, or
--log-file via uwsgi's pyargv. Additionally, nova-placement-api doesn't
pass the [keystone_authtoken] from the config file found in
OS_PLACEMENT_CONFIG_DIR to keystonemiddleware.

We continue to use the OS_PLACEMENT_CONFIG_DIR environment variable to
point at the default nova.conf in $SNAP/etc/nova.conf. This default
nova.conf includes logdir=$SNAP_COMMON/log/, enabling nova-placement-api.log
to be written to the correct directory.

Passing [keystone_authtoken] to keystonemiddleware is fixed in oslo.config.
The prior commit titled "Patch (_COMMON) dirs into oslo.config defaults"
includes a patch for this. keystonemiddleware gets the [keystone_authtoken]
config via oslo.config's find_config_files() and find_config_dirs(), which
are patched to include the $SNAP and $SNAP_COMMON config directories.

Change-Id: I02e2a5d9df91eb8cbf36beb474809bc1e80fe80b
Closes-Bug: 1696830


** Changed in: snap-nova
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1696830

Title:
  nova-placement-api default config files is too strict

Status in OpenStack Compute (nova):
  Confirmed
Status in oslo.config:
  Fix Released
Status in Glance Snap:
  New
Status in Keystone Snap:
  New
Status in Neutron Snap:
  New
Status in Nova Snap:
  Fix Released
Status in Nova Hypervisor Snap:
  New

Bug description:
  If nova.conf doesn't exist in the typical location of
  /etc/nova/nova.conf and OS_PLACEMENT_CONFIG_DIR isn't set, nova-
  placement-api's wsgi application will fail. In our case with the
  OpenStack snap, we have two possible paths we may pick nova.conf up
  from, based on what --config-file specifies. I think the right answer
  here is to be a bit more flexible and not set the default config file
  if it's path doesn't exist.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1696830/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

[Yahoo-eng-team] [Bug 1696830] Re: nova-placement-api default config files is too strict

2017-06-19 Thread OpenStack Infra 
Reviewed:  https://review.openstack.org/474212
Committed: 
https://git.openstack.org/cgit/openstack/oslo.config/commit/?id=21e70e28b3015c1619dacfad8a2218b09e8109ec
Submitter: Jenkins
Branch:master

commit 21e70e28b3015c1619dacfad8a2218b09e8109ec
Author: Corey Bryant 
Date:   Wed Jun 14 09:57:23 2017 -0400

Add snap package paths to default config dirs

With snap packaging (see snapcraft.io) the package is installed into a
read-only squashfs filesystem, which includes the default config. For
example, $SNAP/etc/nova/nova.conf. To override the defaults, a separate
writable directory is used, and this directory is also unique to the snap.
For example, either $SNAP_COMMON/etc/nova/nova.conf, or
$SNAP_COMMON/etc/nova/nova.conf.d/ can be used to override config.

This patch adds these snap directories to the default config paths where
oslo looks for config.

For more details on $SNAP and $SNAP_COMMON please refer to
https://snapcraft.io/docs/reference/env.

Change-Id: I83627e0f215382aedc7b32163e0303b39e8bccf8
Closes-Bug: 1696830


** Changed in: oslo.config
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1696830

Title:
  nova-placement-api default config files is too strict

Status in OpenStack Compute (nova):
  Confirmed
Status in oslo.config:
  Fix Released
Status in Glance Snap:
  New
Status in Keystone Snap:
  New
Status in Neutron Snap:
  New
Status in Nova Snap:
  In Progress
Status in Nova Hypervisor Snap:
  New

Bug description:
  If nova.conf doesn't exist in the typical location of
  /etc/nova/nova.conf and OS_PLACEMENT_CONFIG_DIR isn't set, nova-
  placement-api's wsgi application will fail. In our case with the
  OpenStack snap, we have two possible paths we may pick nova.conf up
  from, based on what --config-file specifies. I think the right answer
  here is to be a bit more flexible and not set the default config file
  if it's path doesn't exist.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1696830/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

[Yahoo-eng-team] [Bug 1696830] Re: nova-placement-api default config files is too strict

2017-06-14 Thread Corey Bryant 
** Also affects: snap-neutron
   Importance: Undecided
   Status: New

** Also affects: snap-keystone
   Importance: Undecided
   Status: New

** Also affects: snap-nova-hypervisor
   Importance: Undecided
   Status: New

** Also affects: snap-glance
   Importance: Undecided
   Status: New

** Changed in: snap-nova-hypervisor
 Assignee: (unassigned) => Corey Bryant (corey.bryant)

** Changed in: snap-keystone
 Assignee: (unassigned) => Corey Bryant (corey.bryant)

** Changed in: snap-glance
 Assignee: (unassigned) => Corey Bryant (corey.bryant)

** Changed in: snap-neutron
 Assignee: (unassigned) => Corey Bryant (corey.bryant)

** Changed in: snap-neutron
   Importance: Undecided => Critical

** Changed in: snap-keystone
   Importance: Undecided => Critical

** Changed in: snap-nova
   Importance: Undecided => Critical

** Changed in: snap-nova-hypervisor
   Importance: Undecided => Critical

** Changed in: snap-glance
   Importance: Undecided => Critical

** Changed in: snap-keystone
   Importance: Critical => High

** Changed in: snap-glance
   Importance: Critical => High

** Changed in: snap-neutron
   Importance: Critical => High

** Changed in: snap-nova-hypervisor
   Importance: Critical => High

** Changed in: snap-nova
   Importance: Critical => High

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1696830

Title:
  nova-placement-api default config files is too strict

Status in OpenStack Compute (nova):
  Confirmed
Status in oslo.config:
  In Progress
Status in Glance Snap:
  New
Status in Keystone Snap:
  New
Status in Neutron Snap:
  New
Status in Nova Snap:
  In Progress
Status in Nova Hypervisor Snap:
  New

Bug description:
  If nova.conf doesn't exist in the typical location of
  /etc/nova/nova.conf and OS_PLACEMENT_CONFIG_DIR isn't set, nova-
  placement-api's wsgi application will fail. In our case with the
  OpenStack snap, we have two possible paths we may pick nova.conf up
  from, based on what --config-file specifies. I think the right answer
  here is to be a bit more flexible and not set the default config file
  if it's path doesn't exist.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1696830/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

[Yahoo-eng-team] [Bug 1696830] Re: nova-placement-api default config files is too strict

2017-06-11 Thread Corey Bryant 
It looks like there's more to this. From what I can tell, the placement
api config doesn't actually make its way through from the placement wsgi
script to keystonemiddleware via OS_PLACEMENT_CONFIG_DIR or via my
attempt to fix above by passing sys.argv. While setting debug=true makes
it look like the config gets applied, it doesn't actually get passed
along.

See nova/api/openstack/placement/deploy.py:

# Do not provide global conf to middleware here.
auth_middleware = auth_token.filter_factory(
{}, oslo_config_project=project_name)

I think that results in the ConfigOpts class of oslo_config having to
call find_config_files() and find_config_dirs() which will search
standard config locations (~/.nova, ~/, /etc/nova, /etc) for config.

For the nova snap package, the config will either be in
/snap/nova/current/etc/nova/ or /var/snap/nova/common/etc/nova, neither
of which would be in oslo_config's standard search paths.

It seems that this should be fixed in nova, but oslo_config could also
be updated to be a bit more flexible in their standard search paths,
perhaps with snap package directories or via environment variables.

** Also affects: oslo.config
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1696830

Title:
  nova-placement-api default config files is too strict

Status in OpenStack Compute (nova):
  Confirmed
Status in oslo.config:
  New
Status in Nova Snap:
  New

Bug description:
  If nova.conf doesn't exist in the typical location of
  /etc/nova/nova.conf and OS_PLACEMENT_CONFIG_DIR isn't set, nova-
  placement-api's wsgi application will fail. In our case with the
  OpenStack snap, we have two possible paths we may pick nova.conf up
  from, based on what --config-file specifies. I think the right answer
  here is to be a bit more flexible and not set the default config file
  if it's path doesn't exist.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1696830/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

[Yahoo-eng-team] [Bug 1696830] Re: nova-placement-api default config files is too strict

2017-06-09 Thread Chris Dent 
As I said in response to you on the review, the goal is to be able to
express more than one place to look for the config, which the
environment variable currently does not do.

** Changed in: nova
   Status: Opinion => Triaged

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1696830

Title:
  nova-placement-api default config files is too strict

Status in OpenStack Compute (nova):
  Triaged
Status in Nova Snap:
  New

Bug description:
  If nova.conf doesn't exist in the typical location of
  /etc/nova/nova.conf and OS_PLACEMENT_CONFIG_DIR isn't set, nova-
  placement-api's wsgi application will fail. In our case with the
  OpenStack snap, we have two possible paths we may pick nova.conf up
  from, based on what --config-file specifies. I think the right answer
  here is to be a bit more flexible and not set the default config file
  if it's path doesn't exist.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1696830/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

[Yahoo-eng-team] [Bug 1696830] Re: nova-placement-api default config files is too strict

2017-06-09 Thread Sylvain Bauza 
Like I said in the review, after looking at PEP-, I think Nova already 
supports defining other places for nova.conf by defining the 
OS_PLACEMENT_CONFIG_DIR environment variable.
I don't really see why you couldn't want to set this specific envvar ?

** Changed in: nova
   Status: In Progress => Opinion

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1696830

Title:
  nova-placement-api default config files is too strict

Status in OpenStack Compute (nova):
  Opinion
Status in Nova Snap:
  New

Bug description:
  If nova.conf doesn't exist in the typical location of
  /etc/nova/nova.conf and OS_PLACEMENT_CONFIG_DIR isn't set, nova-
  placement-api's wsgi application will fail. In our case with the
  OpenStack snap, we have two possible paths we may pick nova.conf up
  from, based on what --config-file specifies. I think the right answer
  here is to be a bit more flexible and not set the default config file
  if it's path doesn't exist.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1696830/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp