[Yahoo-eng-team] [Bug 1754634] Re: Image Import call does not honour enabled methods config option

2018-03-21 Thread Erno Kuvaja
** Also affects: glance/queens
   Importance: Undecided
   Status: New

** Changed in: glance/queens
   Status: New => In Progress

** Changed in: glance/queens
   Importance: Undecided => High

** Changed in: glance/queens
 Assignee: (unassigned) => Brian Rosmaita (brian-rosmaita)

** Changed in: glance/queens
   Importance: High => Critical

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1754634

Title:
  Image Import call does not honour enabled methods config option

Status in Glance:
  Fix Released
Status in Glance queens series:
  In Progress

Bug description:
  Regardless what is configured import call will always accept all the
  methods. This means that for example one cannot turn 'web-download'
  method off if the image import feature is enabled.

  This can be easily corrected by changing the request de-serializer to
  check the method in the request against the config option rather than
  hardcoded list.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1754634/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1754634] Re: Image Import call does not honour enabled methods config option

2018-03-19 Thread OpenStack Infra
Reviewed:  https://review.openstack.org/551274
Committed: 
https://git.openstack.org/cgit/openstack/glance/commit/?id=e1738033dfab389727e61c76eb0312f392f0ff41
Submitter: Zuul
Branch:master

commit e1738033dfab389727e61c76eb0312f392f0ff41
Author: Brian Rosmaita 
Date:   Fri Mar 9 08:06:47 2018 -0500

Use config opt value to determine import methods

Instead of validating import requests by checking the provided
import-method against a hard-coded list, use the values in the
appropriate configuration option.

Change-Id: Iefac190a4adf5f08df538e04db3e07e261ad1bd9
Closes-bug: #1754634


** Changed in: glance
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1754634

Title:
  Image Import call does not honour enabled methods config option

Status in Glance:
  Fix Released

Bug description:
  Regardless what is configured import call will always accept all the
  methods. This means that for example one cannot turn 'web-download'
  method off if the image import feature is enabled.

  This can be easily corrected by changing the request de-serializer to
  check the method in the request against the config option rather than
  hardcoded list.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1754634/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp