[Yahoo-eng-team] [Bug 1755783] Re: PCI configuration documentation renders with smart quotes

2018-04-12 Thread OpenStack Infra
Reviewed:  https://review.openstack.org/553860
Committed: 
https://git.openstack.org/cgit/openstack/oslo.config/commit/?id=03ff144f0bf386982d379d18aeb9183146a05fd5
Submitter: Zuul
Branch:master

commit 03ff144f0bf386982d379d18aeb9183146a05fd5
Author: Stephen Finucane 
Date:   Fri Mar 16 16:53:37 2018 +

sphinxext: Start parsing 'Opt.help' as rST

Users expect this to be parsed as rST and write their docstrings
accordingly. This has the potential to introduce warnings for users with
improperly formatted rST and these warnings can be promoted to errors if
'sphinx-build' is used with the '-W' option. As a result, we disable the
'warning-is-error' logger for these options. We may wish to change this
behavior in the future.

It is not really possible to test this yet as the output wouldn't look
much different. In addition, the error messages generated are rather
unhelpful. Both of these can be changed in a future modification.

Change-Id: Ic6c2dcbe7823dd3fdc71db8dc5afab2d604559e3
Closes-Bug: #1755783


** Changed in: oslo.config
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1755783

Title:
  PCI configuration documentation renders with smart quotes

Status in OpenStack Compute (nova):
  Fix Released
Status in oslo.config:
  Fix Released

Bug description:
  https://docs.openstack.org/nova/latest/configuration/config.html#pci

  For example, an alias example line renders as:

  alias = { “name”: “QuickAssist”, “product_id”: “0443”, “vendor_id”:
  “8086”, “device_type”: “type-PCI”, “numa_policy”: “required” }

  Instead of the valid:

  alias = { "name": "QuickAssist", "product_id": "0443", "vendor_id":
  "8086", "device_type": "type-PCI", "numa_policy": "required" }

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1755783/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1755783] Re: PCI configuration documentation renders with smart quotes

2018-03-16 Thread OpenStack Infra
Reviewed:  https://review.openstack.org/553730
Committed: 
https://git.openstack.org/cgit/openstack/nova/commit/?id=75fc30090133c31316e6ae790568f1b622807d0c
Submitter: Zuul
Branch:master

commit 75fc30090133c31316e6ae790568f1b622807d0c
Author: Lee Yarwood 
Date:   Fri Mar 16 09:37:19 2018 +

docs: Disable smartquotes

This change should then allow all configuration examples to be copied
from the docs directly into nova.conf without resulting in Unicode
errors when these options are then parsed.

Note that this option is deprecated and replaced in Sphinx 1.6.6 [1] by
the smartquotes configurable. A future change will need to land to
switch between these, for now we will use and backport the
html_use_smartypants option.

[1] http://www.sphinx-doc.org/en/stable/config.html#confval-smartquotes

Change-Id: I6c47a0d74e5b5a03bc030a7e45cc7783f22ddadf
Closes-bug: #1755783


** Changed in: nova
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1755783

Title:
  PCI configuration documentation renders with smart quotes

Status in OpenStack Compute (nova):
  Fix Released
Status in oslo.config:
  New

Bug description:
  https://docs.openstack.org/nova/latest/configuration/config.html#pci

  For example, an alias example line renders as:

  alias = { “name”: “QuickAssist”, “product_id”: “0443”, “vendor_id”:
  “8086”, “device_type”: “type-PCI”, “numa_policy”: “required” }

  Instead of the valid:

  alias = { "name": "QuickAssist", "product_id": "0443", "vendor_id":
  "8086", "device_type": "type-PCI", "numa_policy": "required" }

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1755783/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1755783] Re: PCI configuration documentation renders with smart quotes

2018-03-16 Thread OpenStack Infra
Fix proposed to branch: master
Review: https://review.openstack.org/553730

** Changed in: nova
   Status: Invalid => In Progress

** Changed in: nova
 Assignee: (unassigned) => Lee Yarwood (lyarwood)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1755783

Title:
  PCI configuration documentation renders with smart quotes

Status in OpenStack Compute (nova):
  In Progress
Status in oslo.config:
  New

Bug description:
  https://docs.openstack.org/nova/latest/configuration/config.html#pci

  For example, an alias example line renders as:

  alias = { “name”: “QuickAssist”, “product_id”: “0443”, “vendor_id”:
  “8086”, “device_type”: “type-PCI”, “numa_policy”: “required” }

  Instead of the valid:

  alias = { "name": "QuickAssist", "product_id": "0443", "vendor_id":
  "8086", "device_type": "type-PCI", "numa_policy": "required" }

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1755783/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1755783] Re: PCI configuration documentation renders with smart quotes

2018-03-15 Thread Matt Riedemann
The generated sample file is OK:

# ZeroMQ bind address. Should be a wildcard (*), an ethernet interface, or IP.
# The "host" option should point or resolve to this address. (string value)
#rpc_zmq_bind_address = *

** Also affects: oslo.config
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1755783

Title:
  PCI configuration documentation renders with smart quotes

Status in OpenStack Compute (nova):
  Invalid
Status in oslo.config:
  New

Bug description:
  https://docs.openstack.org/nova/latest/configuration/config.html#pci

  For example, an alias example line renders as:

  alias = { “name”: “QuickAssist”, “product_id”: “0443”, “vendor_id”:
  “8086”, “device_type”: “type-PCI”, “numa_policy”: “required” }

  Instead of the valid:

  alias = { "name": "QuickAssist", "product_id": "0443", "vendor_id":
  "8086", "device_type": "type-PCI", "numa_policy": "required" }

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1755783/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp


[Yahoo-eng-team] [Bug 1755783] Re: PCI configuration documentation renders with smart quotes

2018-03-15 Thread Matt Riedemann
The problem would be in here I'd think, but not sure where:

https://github.com/openstack/oslo.config/blob/master/oslo_config/sphinxext.py

** Changed in: nova
   Status: Confirmed => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1755783

Title:
  PCI configuration documentation renders with smart quotes

Status in OpenStack Compute (nova):
  Invalid
Status in oslo.config:
  New

Bug description:
  https://docs.openstack.org/nova/latest/configuration/config.html#pci

  For example, an alias example line renders as:

  alias = { “name”: “QuickAssist”, “product_id”: “0443”, “vendor_id”:
  “8086”, “device_type”: “type-PCI”, “numa_policy”: “required” }

  Instead of the valid:

  alias = { "name": "QuickAssist", "product_id": "0443", "vendor_id":
  "8086", "device_type": "type-PCI", "numa_policy": "required" }

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1755783/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp