Public bug reported: Backing to the patch https://review.openstack.org/#/c/399684/ when the domain_id is added for Idp, I assume that the domain_id is designed for unique?
The domain_id in Idp model is unique: https://github.com/openstack/keystone/blob/master/keystone/federation/backends/sql.py#L58 But the db migration is not: https://github.com/openstack/keystone/blob/master/keystone/common/sql/expand_repo/versions/012_expand_add_domain_id_to_idp.py#L55-L56 They are not in consistence. Since I don't know the origin purpose for the change, I'm not very sure which is correct but I prefer the first one. What's more, our unit test use resource models to init db so that it's unique in our unit test sqlite db. It's not in consistence as well with the real usage. ** Affects: keystone Importance: Undecided Status: New ** Description changed: Backing to the patch https://review.openstack.org/#/c/399684/ when the - domain_id is added for Idp, I assume that the domain_id is designed - unique. + domain_id is added for Idp, I assume that the domain_id is designed for + unique? The domain_id in Idp model is unique: https://github.com/openstack/keystone/blob/master/keystone/federation/backends/sql.py#L58 But the db migration is not: https://github.com/openstack/keystone/blob/master/keystone/common/sql/expand_repo/versions/012_expand_add_domain_id_to_idp.py#L55-L56 They are not in consistence. Since I don't know the origin purpose for the change, I'm not very sure which is correct but I prefer the first one. What's more, our unit test use resource models to init db so that it's unique in our unit test sqlite db. It's not in consistence as well with the real usage. -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Identity (keystone). https://bugs.launchpad.net/bugs/1760843 Title: Idp's domain is not unique Status in OpenStack Identity (keystone): New Bug description: Backing to the patch https://review.openstack.org/#/c/399684/ when the domain_id is added for Idp, I assume that the domain_id is designed for unique? The domain_id in Idp model is unique: https://github.com/openstack/keystone/blob/master/keystone/federation/backends/sql.py#L58 But the db migration is not: https://github.com/openstack/keystone/blob/master/keystone/common/sql/expand_repo/versions/012_expand_add_domain_id_to_idp.py#L55-L56 They are not in consistence. Since I don't know the origin purpose for the change, I'm not very sure which is correct but I prefer the first one. What's more, our unit test use resource models to init db so that it's unique in our unit test sqlite db. It's not in consistence as well with the real usage. To manage notifications about this bug go to: https://bugs.launchpad.net/keystone/+bug/1760843/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp