[Yahoo-eng-team] [Bug 1836650] Re: Bug when configuring Keystone events format
Marking this as invalid for keystone since it seems to be a configuration issue with a deployment tool and not a bug in keystone itself. If you think keystone itself needs to be fixed, feel free to change the status back to "new". ** Changed in: keystone Status: Incomplete => Invalid -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Identity (keystone). https://bugs.launchpad.net/bugs/1836650 Title: Bug when configuring Keystone events format Status in OpenStack Identity (keystone): Invalid Status in kolla-ansible: Triaged Status in kolla-ansible stein series: New Status in kolla-ansible train series: Triaged Bug description: By default Kolla-ansible defines 'enable_cadf_notifications' as 'no'. This variable is used to enable/disable CADF format in Keystone. The default of Keystone is 'CADF' already, but it (Keystone) does not set any messaging drivers; as a consequence, the default behavior of Keystone is not to send event messages to the queueing system. We were led to believe that using 'enable_cadf_notifications' with value 'no' would lead Kolla-ansible to configure the 'basic' message format. However, that is not what happens. Kolla-ansible will configure Keystone without setting the oslo.messaging driver as messagingv2 when 'enable_cadf_notifications: no'. This will create a configuration that does not publish events in RabbitMQ. A PR was pull request (PR) was proposed to fix this misunderstanding in https://review.opendev.org/#/c/670626. That PR is introducing a few things: * Moving the definition of 'enable_cadf_notifications' to Keystone role as it is only used there * Changing the default value defined to 'yes' because that is the default behavior in Keystone. Keystone uses CADF format by Default. * Add an else condition in Keystone.conf template. When CADF is not enabled, we need to explicitly set the format as 'basic'. Moreover, enabling the message driver to allow us to get messages in the queueing system. After opening the PR, the fellow Radosław Piliszek questioned the proposed changes. More details can be found there (https://review.opendev.org/#/c/670626/2), at the PR's comments. In summary, it was questioned the use of a parameter in Kolla-ansible to enable/disable a feature in Keystone. It is argued that this is not the goal of Kolla-ansible. Right now, we have a few options with respect to this issue: option 1 -- we can use the PR as is; option 2 -- we can remove the "feature" (enable_cadf_notifications) in kolla-ansible to configure CADF notification format; option 3 -- do nothing (abandon this PR), and leave things as they are. The community now has to decide on which path we will follow to address this situation. Afterwards, we can move on and propose a PR to apply/address the selected option into Kolla-ansible. To manage notifications about this bug go to: https://bugs.launchpad.net/keystone/+bug/1836650/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1836650] Re: Bug when configuring Keystone events format
I strongly doubt keystone (as a project) is affected by this. ;-) Option 2 is best for kolla because it aligns with letting users configure stuff like this using native config format via overrides. This option was not even documented. It needs to be deprecated/obsoleted and removed. If there is something for k-a to orchestrate there, which would be unwieldy for overrides, then we can discuss it but in this form it's not worth the trouble of changing behavior. Please see the change proposal comments for details TL;DR: the proposal changed the default behavior by enabling the notification messaging driver by default (which is actually not a default for keystone). K-a simply did not enable it by default (and notification type was always CADF if only enabled). We would need to slap an upgrade note that we are changing that behavior and (while it is sensible to run notifications) it would need some explanation anyway. ** Also affects: kolla-ansible/stein Importance: Undecided Status: New ** Also affects: kolla-ansible/train Importance: Undecided Assignee: Rafael Weingartner (rafaelweingartner) Status: Triaged ** Changed in: kolla-ansible/train Milestone: None => 9.0.0 ** Changed in: kolla-ansible/stein Milestone: None => 8.0.0 -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Identity (keystone). https://bugs.launchpad.net/bugs/1836650 Title: Bug when configuring Keystone events format Status in OpenStack Identity (keystone): New Status in kolla-ansible: Triaged Status in kolla-ansible stein series: New Status in kolla-ansible train series: Triaged Bug description: By default Kolla-ansible defines 'enable_cadf_notifications' as 'no'. This variable is used to enable/disable CADF format in Keystone. The default of Keystone is 'CADF' already, but it (Keystone) does not set any messaging drivers; as a consequence, the default behavior of Keystone is not to send event messages to the queueing system. We were led to believe that using 'enable_cadf_notifications' with value 'no' would lead Kolla-ansible to configure the 'basic' message format. However, that is not what happens. Kolla-ansible will configure Keystone without setting the oslo.messaging driver as messagingv2 when 'enable_cadf_notifications: no'. This will create a configuration that does not publish events in RabbitMQ. A PR was pull request (PR) was proposed to fix this misunderstanding in https://review.opendev.org/#/c/670626. That PR is introducing a few things: * Moving the definition of 'enable_cadf_notifications' to Keystone role as it is only used there * Changing the default value defined to 'yes' because that is the default behavior in Keystone. Keystone uses CADF format by Default. * Add an else condition in Keystone.conf template. When CADF is not enabled, we need to explicitly set the format as 'basic'. Moreover, enabling the message driver to allow us to get messages in the queueing system. After opening the PR, the fellow Radosław Piliszek questioned the proposed changes. More details can be found there (https://review.opendev.org/#/c/670626/2), at the PR's comments. In summary, it was questioned the use of a parameter in Kolla-ansible to enable/disable a feature in Keystone. It is argued that this is not the goal of Kolla-ansible. Right now, we have a few options with respect to this issue: option 1 -- we can use the PR as is; option 2 -- we can remove the "feature" (enable_cadf_notifications) in kolla-ansible to configure CADF notification format; option 3 -- do nothing (abandon this PR), and leave things as they are. The community now has to decide on which path we will follow to address this situation. Afterwards, we can move on and propose a PR to apply/address the selected option into Kolla-ansible. To manage notifications about this bug go to: https://bugs.launchpad.net/keystone/+bug/1836650/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1836650] Re: Bug when configuring Keystone events format
** Also affects: keystone Importance: Undecided Status: New ** Changed in: kolla-ansible Assignee: (unassigned) => Rafael Weingartner (rafaelweingartner) ** Changed in: keystone Assignee: (unassigned) => Rafael Weingartner (rafaelweingartner) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Identity (keystone). https://bugs.launchpad.net/bugs/1836650 Title: Bug when configuring Keystone events format Status in OpenStack Identity (keystone): New Status in kolla-ansible: New Bug description: By default Kolla-ansible defines 'enable_cadf_notifications' as 'no'. This variable is used to enable/disable CADF format in Keystone. The default of Keystone is 'CADF' already, but it (Keystone) does not set any messaging drivers; as a consequence, the default behavior of Keystone is not to send event messages to the queueing system. We were led to believe that using 'enable_cadf_notifications' with value 'no' would lead Kolla-ansible to configure the 'basic' message format. However, that is not what happens. Kolla-ansible will configure Keystone without setting the oslo.messaging driver as messagingv2 when 'enable_cadf_notifications: no'. This will create a configuration that does not publish events in RabbitMQ. A PR was pull request (PR) was proposed to fix this misunderstanding in https://review.opendev.org/#/c/670626. That PR is introducing a few things: * Moving the definition of 'enable_cadf_notifications' to Keystone role as it is only used there * Changing the default value defined to 'yes' because that is the default behavior in Keystone. Keystone uses CADF format by Default. * Add an else condition in Keystone.conf template. When CADF is not enabled, we need to explicitly set the format as 'basic'. Moreover, enabling the message driver to allow us to get messages in the queueing system. After opening the PR, the fellow Radosław Piliszek questioned the proposed changes. More details can be found there (https://review.opendev.org/#/c/670626/2), at the PR's comments. In summary, it was questioned the use of a parameter in Kolla-ansible to enable/disable a feature in Keystone. It is argued that this is not the goal of Kolla-ansible. Right now, we have a few options with respect to this issue: option 1 -- we can use the PR as is; option 2 -- we can remove the "feature" (enable_cadf_notifications) in kolla-ansible to configure CADF notification format; option 3 -- do nothing (abandon this PR), and leave things as they are. The community now has to decide on which path we will follow to address this situation. Afterwards, we can move on and propose a PR to apply/address the selected option into Kolla-ansible. To manage notifications about this bug go to: https://bugs.launchpad.net/keystone/+bug/1836650/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
