Szilard Nemeth created YARN-9096: ------------------------------------ Summary: Some GpuResourcePlugin and ResourcePluginManager methods are synchronized unnecessarily Key: YARN-9096 URL: https://issues.apache.org/jira/browse/YARN-9096 Project: Hadoop YARN Issue Type: Improvement Reporter: Szilard Nemeth Assignee: Szilard Nemeth
These methods are not used concurrently, they are part of the initialization code of NM that happens from one thread. This is the list of the call hierarchies: 1. GpuResourcePlugin.initialize + ResourcePluginManager.initialize {code:java} GpuResourcePlugin.initialize(Context) (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu) ResourcePluginManager.initialize(Context) (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin) NodeManager.serviceInit(Configuration) (org.apache.hadoop.yarn.server.nodemanager){code} 2. GpuResourcePlugin.createResourceHandler: {code:java} GpuResourcePlugin.createResourceHandler(Context, CGroupsHandler, PrivilegedOperationExecutor) (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu) ResourceHandlerModule.addHandlersFromConfiguredResourcePlugins(List, Configuration, Context) (org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources) ResourceHandlerModule.initializeConfiguredResourceHandlerChain(Configuration, Context) (org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources) ResourceHandlerModule.getConfiguredResourceHandlerChain(Configuration, Context) (org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources) ContainerScheduler.serviceInit(Configuration) (org.apache.hadoop.yarn.server.nodemanager.containermanager.scheduler) LinuxContainerExecutor.init(Context) (org.apache.hadoop.yarn.server.nodemanager) {code} 3. GpuResourcePlugin.getNodeResourceHandlerInstance: {code:java} GpuResourcePlugin.getNodeResourceHandlerInstance() (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu) NodeStatusUpdaterImpl.updateConfiguredResourcesViaPlugins(Resource)(2 usages) (org.apache.hadoop.yarn.server.nodemanager) NodeStatusUpdaterImpl.serviceInit(Configuration) (org.apache.hadoop.yarn.server.nodemanager) {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-dev-h...@hadoop.apache.org