[jira] [Updated] (YARN-9996) Code cleanup in QueueAdminConfigurationMutationACLPolicy
[ https://issues.apache.org/jira/browse/YARN-9996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siddharth Ahuja updated YARN-9996: -- Attachment: YARN-9996-branch-3.2.001.patch > Code cleanup in QueueAdminConfigurationMutationACLPolicy > > > Key: YARN-9996 > URL: https://issues.apache.org/jira/browse/YARN-9996 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Szilard Nemeth >Assignee: Siddharth Ahuja >Priority: Major > Fix For: 3.4.0 > > Attachments: YARN-9996-branch-3.2.001.patch, > YARN-9996-branch-3.2.001.patch, YARN-9996-branch-3.2.001.patch, > YARN-9996-branch-3.3.001.patch, YARN-9996.001.patch > > > Method 'isMutationAllowed' contains many uses of substring and lastIndexOf. > These could be extracted and simplified. > Also, some logging could be added as well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10220) RM HA times out intermittently
[
https://issues.apache.org/jira/browse/YARN-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088995#comment-17088995
]
Bilwa S T commented on YARN-10220:
--
Hi [~ahussein]
its always passing in my machine. Do you have logs for this?
> RM HA times out intermittently
> --
>
> Key: YARN-10220
> URL: https://issues.apache.org/jira/browse/YARN-10220
> Project: Hadoop YARN
> Issue Type: Bug
>Affects Versions: 2.10.0, 3.3.0, 3.2.1, 3.1.3
>Reporter: Ahmed Hussein
>Assignee: Bilwa S T
>Priority: Major
>
> TestResourceTrackerOnHA Among other tests time out intermittently
> * TestApplicationClientProtocolOnHA
> * TestApplicationMasterServiceProtocolForTimelineV2
> * TestApplicationMasterServiceProtocolOnHA
> {code:bash}
> [INFO] --- maven-surefire-plugin:3.0.0-M1:test (default-test) @
> hadoop-yarn-client ---
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.apache.hadoop.yarn.client.TestResourceTrackerOnHA
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 19.612 s <<< FAILURE! - in
> org.apache.hadoop.yarn.client.TestResourceTrackerOnHA
> [ERROR]
> testResourceTrackerOnHA(org.apache.hadoop.yarn.client.TestResourceTrackerOnHA)
> Time elapsed: 19.473 s <<< ERROR!
> org.junit.runners.model.TestTimedOutException: test timed out after 15000
> milliseconds
> at sun.nio.ch.KQueueArrayWrapper.kevent0(Native Method)
> at sun.nio.ch.KQueueArrayWrapper.poll(KQueueArrayWrapper.java:198)
> at sun.nio.ch.KQueueSelectorImpl.doSelect(KQueueSelectorImpl.java:117)
> at sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:86)
> at sun.nio.ch.SelectorImpl.select(SelectorImpl.java:97)
> at
> org.apache.hadoop.net.SocketIOWithTimeout$SelectorPool.select(SocketIOWithTimeout.java:336)
> at
> org.apache.hadoop.net.SocketIOWithTimeout.connect(SocketIOWithTimeout.java:203)
> at org.apache.hadoop.net.NetUtils.connect(NetUtils.java:533)
> at
> org.apache.hadoop.ipc.Client$Connection.setupConnection(Client.java:699)
> at
> org.apache.hadoop.ipc.Client$Connection.setupIOstreams(Client.java:812)
> at org.apache.hadoop.ipc.Client$Connection.access$3800(Client.java:413)
> at org.apache.hadoop.ipc.Client.getConnection(Client.java:1636)
> at org.apache.hadoop.ipc.Client.call(Client.java:1452)
> at org.apache.hadoop.ipc.Client.call(Client.java:1405)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:233)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:118)
> at com.sun.proxy.$Proxy93.registerNodeManager(Unknown Source)
> at
> org.apache.hadoop.yarn.server.api.impl.pb.client.ResourceTrackerPBClientImpl.registerNodeManager(ResourceTrackerPBClientImpl.java:73)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:422)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:165)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:157)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:95)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:359)
> at com.sun.proxy.$Proxy94.registerNodeManager(Unknown Source)
> at
> org.apache.hadoop.yarn.client.TestResourceTrackerOnHA.testResourceTrackerOnHA(TestResourceTrackerOnHA.java:64)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
>
[jira] [Commented] (YARN-10240) Prevent Fatal CancelledException in TimelineV2Client when stopping
[
https://issues.apache.org/jira/browse/YARN-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088547#comment-17088547
]
Tarun Parimi commented on YARN-10240:
-
Thanks for the review [~prabhujoseph]
> Prevent Fatal CancelledException in TimelineV2Client when stopping
> --
>
> Key: YARN-10240
> URL: https://issues.apache.org/jira/browse/YARN-10240
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: ATSv2
>Reporter: Tarun Parimi
>Assignee: Tarun Parimi
>Priority: Major
> Fix For: 3.4.0
>
> Attachments: YARN-10240.001.patch
>
>
> When the timeline client is stopped, it will cancel all sync EntityHolders
> after waiting for a drain timeout.
> {code:java}
> // if some entities were not drained then we need interrupt
> // the threads which had put sync EntityHolders to the
> queue.
> EntitiesHolder nextEntityInTheQueue = null;
> while ((nextEntityInTheQueue =
> timelineEntityQueue.poll()) != null) {
> nextEntityInTheQueue.cancel(true);
> }
> {code}
> We only handle interrupted exception here.
> {code:java}
> if (sync) {
> // In sync call we need to wait till its published and if any error
> then
> // throw it back
> try {
> entitiesHolder.get();
> } catch (ExecutionException e) {
> throw new YarnException("Failed while publishing entity",
> e.getCause());
> } catch (InterruptedException e) {
> Thread.currentThread().interrupt();
> throw new YarnException("Interrupted while publishing entity", e);
> }
> }
> {code}
> But calling nextEntityInTheQueue.cancel(true) will result in
> entitiesHolder.get() throwing a CancelledException which is not handled. This
> can result in FATAL error in NM. We need to prevent this.
> {code:java}
> FATAL event.AsyncDispatcher (AsyncDispatcher.java:dispatch(203)) - Error in
> dispatcher thread
> java.util.concurrent.CancellationException
> at java.util.concurrent.FutureTask.report(FutureTask.java:121)
> at java.util.concurrent.FutureTask.get(FutureTask.java:192)
> at
> org.apache.hadoop.yarn.client.api.impl.TimelineV2ClientImpl$TimelineEntityDispatcher.dispatchEntities(TimelineV2ClientImpl.java:545)
> at
> org.apache.hadoop.yarn.client.api.impl.TimelineV2ClientImpl.putEntities(TimelineV2ClientImpl.java:149)
> at
> org.apache.hadoop.yarn.server.nodemanager.timelineservice.NMTimelinePublisher.putEntity(NMTimelinePublisher.java:348)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-10241) [UI2] Yarn web ui2 can't display Beijing time correctly
[ https://issues.apache.org/jira/browse/YARN-10241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jevic updated YARN-10241: - Environment: *Now the time is: April 21, 2020 11:54* *But the screenshot shows another time period* *versions:* *HDP-3.1.4.0* *HDFS 3.1.1* *yarn 3.1.1* was: *Now the time is: April 21, 2020 11:54* *But the screenshot shows another time period* > [UI2] Yarn web ui2 can't display Beijing time correctly > --- > > Key: YARN-10241 > URL: https://issues.apache.org/jira/browse/YARN-10241 > Project: Hadoop YARN > Issue Type: Bug > Components: webapp, yarn-ui-v2 >Affects Versions: 3.1.1 > Environment: *Now the time is: April 21, 2020 11:54* > *But the screenshot shows another time period* > > *versions:* > *HDP-3.1.4.0* > *HDFS 3.1.1* > *yarn 3.1.1* >Reporter: jevic >Priority: Blocker > Attachments: image-2020-04-21-11-53-27-811.png > > > !image-2020-04-21-11-53-27-811.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-10241) [UI2] Yarn web ui2 can't display Beijing time correctly
[ https://issues.apache.org/jira/browse/YARN-10241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jevic updated YARN-10241: - Summary: [UI2] Yarn web ui2 can't display Beijing time correctly (was: Yarn web ui2 can't display Beijing time correctly) > [UI2] Yarn web ui2 can't display Beijing time correctly > --- > > Key: YARN-10241 > URL: https://issues.apache.org/jira/browse/YARN-10241 > Project: Hadoop YARN > Issue Type: Bug > Components: webapp, yarn-ui-v2 >Affects Versions: 3.1.1 > Environment: *Now the time is: April 21, 2020 11:54* > *But the screenshot shows another time period* >Reporter: jevic >Priority: Blocker > Attachments: image-2020-04-21-11-53-27-811.png > > > !image-2020-04-21-11-53-27-811.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10240) Prevent Fatal CancelledException in TimelineV2Client when stopping
[
https://issues.apache.org/jira/browse/YARN-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088351#comment-17088351
]
Hudson commented on YARN-10240:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18170 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/18170/])
YARN-10240. Prevent Fatal CancelledException in TimelineV2Client when (pjoseph:
rev 60fa15366e8f2d59f4dc8e7beaa6edcbbcb9c18f)
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineV2ClientImpl.java
> Prevent Fatal CancelledException in TimelineV2Client when stopping
> --
>
> Key: YARN-10240
> URL: https://issues.apache.org/jira/browse/YARN-10240
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: ATSv2
>Reporter: Tarun Parimi
>Assignee: Tarun Parimi
>Priority: Major
> Fix For: 3.4.0
>
> Attachments: YARN-10240.001.patch
>
>
> When the timeline client is stopped, it will cancel all sync EntityHolders
> after waiting for a drain timeout.
> {code:java}
> // if some entities were not drained then we need interrupt
> // the threads which had put sync EntityHolders to the
> queue.
> EntitiesHolder nextEntityInTheQueue = null;
> while ((nextEntityInTheQueue =
> timelineEntityQueue.poll()) != null) {
> nextEntityInTheQueue.cancel(true);
> }
> {code}
> We only handle interrupted exception here.
> {code:java}
> if (sync) {
> // In sync call we need to wait till its published and if any error
> then
> // throw it back
> try {
> entitiesHolder.get();
> } catch (ExecutionException e) {
> throw new YarnException("Failed while publishing entity",
> e.getCause());
> } catch (InterruptedException e) {
> Thread.currentThread().interrupt();
> throw new YarnException("Interrupted while publishing entity", e);
> }
> }
> {code}
> But calling nextEntityInTheQueue.cancel(true) will result in
> entitiesHolder.get() throwing a CancelledException which is not handled. This
> can result in FATAL error in NM. We need to prevent this.
> {code:java}
> FATAL event.AsyncDispatcher (AsyncDispatcher.java:dispatch(203)) - Error in
> dispatcher thread
> java.util.concurrent.CancellationException
> at java.util.concurrent.FutureTask.report(FutureTask.java:121)
> at java.util.concurrent.FutureTask.get(FutureTask.java:192)
> at
> org.apache.hadoop.yarn.client.api.impl.TimelineV2ClientImpl$TimelineEntityDispatcher.dispatchEntities(TimelineV2ClientImpl.java:545)
> at
> org.apache.hadoop.yarn.client.api.impl.TimelineV2ClientImpl.putEntities(TimelineV2ClientImpl.java:149)
> at
> org.apache.hadoop.yarn.server.nodemanager.timelineservice.NMTimelinePublisher.putEntity(NMTimelinePublisher.java:348)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10240) Prevent Fatal CancelledException in TimelineV2Client when stopping
[
https://issues.apache.org/jira/browse/YARN-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088342#comment-17088342
]
Prabhu Joseph commented on YARN-10240:
--
Have committed it to trunk.
> Prevent Fatal CancelledException in TimelineV2Client when stopping
> --
>
> Key: YARN-10240
> URL: https://issues.apache.org/jira/browse/YARN-10240
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: ATSv2
>Reporter: Tarun Parimi
>Assignee: Tarun Parimi
>Priority: Major
> Attachments: YARN-10240.001.patch
>
>
> When the timeline client is stopped, it will cancel all sync EntityHolders
> after waiting for a drain timeout.
> {code:java}
> // if some entities were not drained then we need interrupt
> // the threads which had put sync EntityHolders to the
> queue.
> EntitiesHolder nextEntityInTheQueue = null;
> while ((nextEntityInTheQueue =
> timelineEntityQueue.poll()) != null) {
> nextEntityInTheQueue.cancel(true);
> }
> {code}
> We only handle interrupted exception here.
> {code:java}
> if (sync) {
> // In sync call we need to wait till its published and if any error
> then
> // throw it back
> try {
> entitiesHolder.get();
> } catch (ExecutionException e) {
> throw new YarnException("Failed while publishing entity",
> e.getCause());
> } catch (InterruptedException e) {
> Thread.currentThread().interrupt();
> throw new YarnException("Interrupted while publishing entity", e);
> }
> }
> {code}
> But calling nextEntityInTheQueue.cancel(true) will result in
> entitiesHolder.get() throwing a CancelledException which is not handled. This
> can result in FATAL error in NM. We need to prevent this.
> {code:java}
> FATAL event.AsyncDispatcher (AsyncDispatcher.java:dispatch(203)) - Error in
> dispatcher thread
> java.util.concurrent.CancellationException
> at java.util.concurrent.FutureTask.report(FutureTask.java:121)
> at java.util.concurrent.FutureTask.get(FutureTask.java:192)
> at
> org.apache.hadoop.yarn.client.api.impl.TimelineV2ClientImpl$TimelineEntityDispatcher.dispatchEntities(TimelineV2ClientImpl.java:545)
> at
> org.apache.hadoop.yarn.client.api.impl.TimelineV2ClientImpl.putEntities(TimelineV2ClientImpl.java:149)
> at
> org.apache.hadoop.yarn.server.nodemanager.timelineservice.NMTimelinePublisher.putEntity(NMTimelinePublisher.java:348)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-10240) Prevent Fatal CancelledException in TimelineV2Client when stopping
[
https://issues.apache.org/jira/browse/YARN-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Prabhu Joseph updated YARN-10240:
-
Fix Version/s: 3.4.0
> Prevent Fatal CancelledException in TimelineV2Client when stopping
> --
>
> Key: YARN-10240
> URL: https://issues.apache.org/jira/browse/YARN-10240
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: ATSv2
>Reporter: Tarun Parimi
>Assignee: Tarun Parimi
>Priority: Major
> Fix For: 3.4.0
>
> Attachments: YARN-10240.001.patch
>
>
> When the timeline client is stopped, it will cancel all sync EntityHolders
> after waiting for a drain timeout.
> {code:java}
> // if some entities were not drained then we need interrupt
> // the threads which had put sync EntityHolders to the
> queue.
> EntitiesHolder nextEntityInTheQueue = null;
> while ((nextEntityInTheQueue =
> timelineEntityQueue.poll()) != null) {
> nextEntityInTheQueue.cancel(true);
> }
> {code}
> We only handle interrupted exception here.
> {code:java}
> if (sync) {
> // In sync call we need to wait till its published and if any error
> then
> // throw it back
> try {
> entitiesHolder.get();
> } catch (ExecutionException e) {
> throw new YarnException("Failed while publishing entity",
> e.getCause());
> } catch (InterruptedException e) {
> Thread.currentThread().interrupt();
> throw new YarnException("Interrupted while publishing entity", e);
> }
> }
> {code}
> But calling nextEntityInTheQueue.cancel(true) will result in
> entitiesHolder.get() throwing a CancelledException which is not handled. This
> can result in FATAL error in NM. We need to prevent this.
> {code:java}
> FATAL event.AsyncDispatcher (AsyncDispatcher.java:dispatch(203)) - Error in
> dispatcher thread
> java.util.concurrent.CancellationException
> at java.util.concurrent.FutureTask.report(FutureTask.java:121)
> at java.util.concurrent.FutureTask.get(FutureTask.java:192)
> at
> org.apache.hadoop.yarn.client.api.impl.TimelineV2ClientImpl$TimelineEntityDispatcher.dispatchEntities(TimelineV2ClientImpl.java:545)
> at
> org.apache.hadoop.yarn.client.api.impl.TimelineV2ClientImpl.putEntities(TimelineV2ClientImpl.java:149)
> at
> org.apache.hadoop.yarn.server.nodemanager.timelineservice.NMTimelinePublisher.putEntity(NMTimelinePublisher.java:348)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
