[jira] [Commented] (YARN-11350) [Federation] Router Support DelegationToken With ZK

2022-11-12 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/YARN-11350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17633206#comment-17633206
 ] 

ASF GitHub Bot commented on YARN-11350:
---

goiri commented on code in PR #5111:
URL: https://github.com/apache/hadoop/pull/5111#discussion_r1020829032


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/ZookeeperFederationStateStore.java:
##
@@ -1002,7 +1053,9 @@ public RouterRMTokenResponse 
removeStoredToken(RouterRMTokenRequest request)
   @Override
   public RouterRMTokenResponse getTokenByRouterStoreToken(RouterRMTokenRequest 
request)
   throws YarnException, IOException {
+request.getRouterStoreToken().getTokenIdentifier();
 throw new NotImplementedException("Code is not implemented");

Review Comment:
   Didn't we implement it?



##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/ZookeeperFederationStateStore.java:
##
@@ -129,6 +135,7 @@
  * |-

> [Federation] Router Support DelegationToken With ZK
> ---
>
> Key: YARN-11350
> URL: https://issues.apache.org/jira/browse/YARN-11350
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: federation, router
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
>  Labels: pull-request-available
>
> [Federation] Router Support DelegationToken With 
> ZookeeperFederationStateStore.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-10005) Code improvements in MutableCSConfigurationProvider

2022-11-12 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/YARN-10005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632715#comment-17632715
 ] 

ASF GitHub Bot commented on YARN-10005:
---

szilard-nemeth closed pull request #5115: YARN-10005. Code improvements in 
MutableCSConfigurationProvider
URL: https://github.com/apache/hadoop/pull/5115




> Code improvements in MutableCSConfigurationProvider
> ---
>
> Key: YARN-10005
> URL: https://issues.apache.org/jira/browse/YARN-10005
> Project: Hadoop YARN
>  Issue Type: Improvement
>Reporter: Szilard Nemeth
>Assignee: Peter Szucs
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.4.0
>
>
> * Important: constructKeyValueConfUpdate and all related methods seems a 
> separate responsibility: how to convert incoming SchedConfUpdateInfo to 
> Configuration changes (Configuration object)
> * Duplicated code block (9 lines) in init / formatConfigurationInStore methods
> * Method "getConfStore" could be package-private



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Resolved] (YARN-10005) Code improvements in MutableCSConfigurationProvider

2022-11-12 Thread Szilard Nemeth (Jira) 


 [ 
https://issues.apache.org/jira/browse/YARN-10005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szilard Nemeth resolved YARN-10005.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> Code improvements in MutableCSConfigurationProvider
> ---
>
> Key: YARN-10005
> URL: https://issues.apache.org/jira/browse/YARN-10005
> Project: Hadoop YARN
>  Issue Type: Improvement
>Reporter: Szilard Nemeth
>Assignee: Peter Szucs
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.4.0
>
>
> * Important: constructKeyValueConfUpdate and all related methods seems a 
> separate responsibility: how to convert incoming SchedConfUpdateInfo to 
> Configuration changes (Configuration object)
> * Duplicated code block (9 lines) in init / formatConfigurationInStore methods
> * Method "getConfStore" could be package-private



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Updated] (YARN-10005) Code improvements in MutableCSConfigurationProvider

2022-11-12 Thread Szilard Nemeth (Jira) 


 [ 
https://issues.apache.org/jira/browse/YARN-10005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szilard Nemeth updated YARN-10005:
--
Fix Version/s: 3.4.0

> Code improvements in MutableCSConfigurationProvider
> ---
>
> Key: YARN-10005
> URL: https://issues.apache.org/jira/browse/YARN-10005
> Project: Hadoop YARN
>  Issue Type: Improvement
>Reporter: Szilard Nemeth
>Assignee: Peter Szucs
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.4.0
>
>
> * Important: constructKeyValueConfUpdate and all related methods seems a 
> separate responsibility: how to convert incoming SchedConfUpdateInfo to 
> Configuration changes (Configuration object)
> * Duplicated code block (9 lines) in init / formatConfigurationInStore methods
> * Method "getConfStore" could be package-private



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-10005) Code improvements in MutableCSConfigurationProvider

2022-11-12 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/YARN-10005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632714#comment-17632714
 ] 

ASF GitHub Bot commented on YARN-10005:
---

szilard-nemeth commented on PR #5115:
URL: https://github.com/apache/hadoop/pull/5115#issuecomment-1312535163

   Thanks @p-szucs for working on this.
   Code LGTM, committed to trunk.




> Code improvements in MutableCSConfigurationProvider
> ---
>
> Key: YARN-10005
> URL: https://issues.apache.org/jira/browse/YARN-10005
> Project: Hadoop YARN
>  Issue Type: Improvement
>Reporter: Szilard Nemeth
>Assignee: Peter Szucs
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.4.0
>
>
> * Important: constructKeyValueConfUpdate and all related methods seems a 
> separate responsibility: how to convert incoming SchedConfUpdateInfo to 
> Configuration changes (Configuration object)
> * Duplicated code block (9 lines) in init / formatConfigurationInStore methods
> * Method "getConfStore" could be package-private



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org