[jira] [Commented] (YARN-11619) [Federation] Router CLI Supports List SubClusters.
[ https://issues.apache.org/jira/browse/YARN-11619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790891#comment-17790891 ] ASF GitHub Bot commented on YARN-11619: --- slfan1989 opened a new pull request, #6304: URL: https://github.com/apache/hadoop/pull/6304 ### Description of PR JIRA: YARN-11619. [Federation] Router CLI Supports List SubClusters. ### How was this patch tested? Add Junit Test. ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? > [Federation] Router CLI Supports List SubClusters. > -- > > Key: YARN-11619 > URL: https://issues.apache.org/jira/browse/YARN-11619 > Project: Hadoop YARN > Issue Type: Sub-task > Components: federation >Affects Versions: 3.4.0 >Reporter: Shilun Fan >Assignee: Shilun Fan >Priority: Major > > We need to support list subcluster on the command line. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-11619) [Federation] Router CLI Supports List SubClusters.
[ https://issues.apache.org/jira/browse/YARN-11619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated YARN-11619: -- Labels: pull-request-available (was: ) > [Federation] Router CLI Supports List SubClusters. > -- > > Key: YARN-11619 > URL: https://issues.apache.org/jira/browse/YARN-11619 > Project: Hadoop YARN > Issue Type: Sub-task > Components: federation >Affects Versions: 3.4.0 >Reporter: Shilun Fan >Assignee: Shilun Fan >Priority: Major > Labels: pull-request-available > > We need to support list subcluster on the command line. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-11620) [Federation] Improve FederationClientInterceptor To Return Partial Results of subClusters.
[ https://issues.apache.org/jira/browse/YARN-11620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790809#comment-17790809 ] ASF GitHub Bot commented on YARN-11620: --- slfan1989 commented on PR #6289: URL: https://github.com/apache/hadoop/pull/6289#issuecomment-1830906012 @goiri Thank you very much for your help in reviewing the code! > [Federation] Improve FederationClientInterceptor To Return Partial Results of > subClusters. > -- > > Key: YARN-11620 > URL: https://issues.apache.org/jira/browse/YARN-11620 > Project: Hadoop YARN > Issue Type: Sub-task > Components: federation >Affects Versions: 3.4.0 >Reporter: Shilun Fan >Assignee: Shilun Fan >Priority: Major > Labels: pull-request-available > > In FederationInterceptorREST, we support returning partial results of > sub-clusters. This is used to restart the RM of a sub-cluster to ensure that > the interface can return normally. In FederationClientInterceptor, we also > need to support returning partial results. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Resolved] (YARN-11620) [Federation] Improve FederationClientInterceptor To Return Partial Results of subClusters.
[ https://issues.apache.org/jira/browse/YARN-11620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shilun Fan resolved YARN-11620. --- Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed > [Federation] Improve FederationClientInterceptor To Return Partial Results of > subClusters. > -- > > Key: YARN-11620 > URL: https://issues.apache.org/jira/browse/YARN-11620 > Project: Hadoop YARN > Issue Type: Sub-task > Components: federation >Affects Versions: 3.4.0 >Reporter: Shilun Fan >Assignee: Shilun Fan >Priority: Major > Labels: pull-request-available > Fix For: 3.4.0 > > > In FederationInterceptorREST, we support returning partial results of > sub-clusters. This is used to restart the RM of a sub-cluster to ensure that > the interface can return normally. In FederationClientInterceptor, we also > need to support returning partial results. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-11620) [Federation] Improve FederationClientInterceptor To Return Partial Results of subClusters.
[ https://issues.apache.org/jira/browse/YARN-11620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790808#comment-17790808 ] ASF GitHub Bot commented on YARN-11620: --- slfan1989 merged PR #6289: URL: https://github.com/apache/hadoop/pull/6289 > [Federation] Improve FederationClientInterceptor To Return Partial Results of > subClusters. > -- > > Key: YARN-11620 > URL: https://issues.apache.org/jira/browse/YARN-11620 > Project: Hadoop YARN > Issue Type: Sub-task > Components: federation >Affects Versions: 3.4.0 >Reporter: Shilun Fan >Assignee: Shilun Fan >Priority: Major > Labels: pull-request-available > > In FederationInterceptorREST, we support returning partial results of > sub-clusters. This is used to restart the RM of a sub-cluster to ensure that > the interface can return normally. In FederationClientInterceptor, we also > need to support returning partial results. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-11620) [Federation] Improve FederationClientInterceptor To Return Partial Results of subClusters.
[ https://issues.apache.org/jira/browse/YARN-11620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shilun Fan updated YARN-11620: -- Parent: YARN-5597 Issue Type: Sub-task (was: Improvement) > [Federation] Improve FederationClientInterceptor To Return Partial Results of > subClusters. > -- > > Key: YARN-11620 > URL: https://issues.apache.org/jira/browse/YARN-11620 > Project: Hadoop YARN > Issue Type: Sub-task > Components: federation >Affects Versions: 3.4.0 >Reporter: Shilun Fan >Assignee: Shilun Fan >Priority: Major > Labels: pull-request-available > > In FederationInterceptorREST, we support returning partial results of > sub-clusters. This is used to restart the RM of a sub-cluster to ensure that > the interface can return normally. In FederationClientInterceptor, we also > need to support returning partial results. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-11561) [Federation] GPG Supports Format PolicyStateStore.
[
https://issues.apache.org/jira/browse/YARN-11561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790763#comment-17790763
]
ASF GitHub Bot commented on YARN-11561:
---
goiri commented on code in PR #6300:
URL: https://github.com/apache/hadoop/pull/6300#discussion_r1408440133
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator/src/main/java/org/apache/hadoop/yarn/server/globalpolicygenerator/GlobalPolicyGenerator.java:
##
@@ -366,4 +365,15 @@ public WebApp getWebApp() {
private static void printUsage(PrintStream out) {
out.println("Usage: yarn gpg [-format-policy-store]");
}
+
+ private static void handFormatPolicyStateStore(Configuration conf) {
+try {
+ System.out.println("Deleting Federation policy state store.");
+ FederationStateStoreFacade facade =
FederationStateStoreFacade.getInstance(conf);
+ System.out.println("Federation policy state store has been cleaned.");
+ facade.deleteAllPoliciesConfigurations();
+} catch (Exception e) {
+ System.err.println("Delete Federation policy state store error,
exception = " + e);
Review Comment:
Should this be LOG? Or this is for the user?
> [Federation] GPG Supports Format PolicyStateStore.
> --
>
> Key: YARN-11561
> URL: https://issues.apache.org/jira/browse/YARN-11561
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: federation
>Affects Versions: 3.4.0
>Reporter: Shilun Fan
>Assignee: Shilun Fan
>Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-11613) [Federation] Router CLI Supports Delete SubClusterPolicyConfiguration Of Queues.
[
https://issues.apache.org/jira/browse/YARN-11613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790756#comment-17790756
]
ASF GitHub Bot commented on YARN-11613:
---
goiri commented on code in PR #6295:
URL: https://github.com/apache/hadoop/pull/6295#discussion_r1408424992
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/records/impl/pb/DeleteSubClusterPoliciesConfigurationsResponsePBImpl.java:
##
@@ -0,0 +1,75 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package org.apache.hadoop.yarn.server.federation.store.records.impl.pb;
+
+import org.apache.hadoop.classification.InterfaceAudience.Private;
+import org.apache.hadoop.classification.InterfaceStability.Unstable;
+import org.apache.hadoop.thirdparty.protobuf.TextFormat;
+import
org.apache.hadoop.yarn.federation.proto.YarnServerFederationProtos.DeleteSubClusterPoliciesConfigurationsResponseProto;
+import
org.apache.hadoop.yarn.server.federation.store.records.DeleteSubClusterPoliciesConfigurationsResponse;
+
+/**
+ * Protocol buffer based implementation of
+ * {@link DeleteSubClusterPoliciesConfigurationsResponse}.
+ */
+@Private
+@Unstable
+public class DeleteSubClusterPoliciesConfigurationsResponsePBImpl
+extends DeleteSubClusterPoliciesConfigurationsResponse {
+
+ private DeleteSubClusterPoliciesConfigurationsResponseProto proto =
+ DeleteSubClusterPoliciesConfigurationsResponseProto.getDefaultInstance();
+ private DeleteSubClusterPoliciesConfigurationsResponseProto.Builder builder
= null;
+ private boolean viaProto = false;
+
+ public DeleteSubClusterPoliciesConfigurationsResponsePBImpl() {
+builder = DeleteSubClusterPoliciesConfigurationsResponseProto.newBuilder();
+ }
+
+ public DeleteSubClusterPoliciesConfigurationsResponsePBImpl(
+DeleteSubClusterPoliciesConfigurationsResponseProto proto) {
Review Comment:
There is a checkstyle issue here.
> [Federation] Router CLI Supports Delete SubClusterPolicyConfiguration Of
> Queues.
>
>
> Key: YARN-11613
> URL: https://issues.apache.org/jira/browse/YARN-11613
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: federation
>Affects Versions: 3.4.0
>Reporter: Shilun Fan
>Assignee: Shilun Fan
>Priority: Major
> Labels: pull-request-available
>
> Router's command line tool needs to support delete
> SubClusterPolicyConfiguration.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
