[jira] [Commented] (YARN-2847) Linux native container executor segfaults if default banned user detected
[ https://issues.apache.org/jira/browse/YARN-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14319951#comment-14319951 ] Olaf Flebbe commented on YARN-2847: --- The eclipse:eclipse test trips over the Test from [~Chang Li] . The required user mapred does not exit. Do we need this test anyway? I added a test in the C Part of the patch. Linux native container executor segfaults if default banned user detected - Key: YARN-2847 URL: https://issues.apache.org/jira/browse/YARN-2847 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Affects Versions: 2.5.0, 2.4.1, 2.6.0 Reporter: Jason Lowe Assignee: Chang Li Attachments: YARN-2487.04.trunk.patch, YARN-2487.05.trunk.patch, yarn2847.patch, yarn2847.patch, yarn2847notest.patch The check_user function in container-executor.c can cause a segmentation fault if banned.users is not provided but the user is detected as one of the default users. In that scenario it will call free_values on a NULL pointer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (YARN-2847) Linux native container executor segfaults if default banned user detected
[ https://issues.apache.org/jira/browse/YARN-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olaf Flebbe updated YARN-2847: -- Attachment: YARN-2487.06.trunk.patch Removed Test from the JAVA part of the code Linux native container executor segfaults if default banned user detected - Key: YARN-2847 URL: https://issues.apache.org/jira/browse/YARN-2847 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Affects Versions: 2.5.0, 2.4.1, 2.6.0 Reporter: Jason Lowe Assignee: Olaf Flebbe Attachments: YARN-2487.04.trunk.patch, YARN-2487.05.trunk.patch, YARN-2487.06.trunk.patch, yarn2847.patch, yarn2847.patch, yarn2847notest.patch The check_user function in container-executor.c can cause a segmentation fault if banned.users is not provided but the user is detected as one of the default users. In that scenario it will call free_values on a NULL pointer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2847) Linux native container executor segfaults if default banned user detected
[ https://issues.apache.org/jira/browse/YARN-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14318885#comment-14318885 ] Olaf Flebbe commented on YARN-2847: --- Oops fix not correct Linux native container executor segfaults if default banned user detected - Key: YARN-2847 URL: https://issues.apache.org/jira/browse/YARN-2847 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Affects Versions: 2.5.0, 2.4.1, 2.6.0 Reporter: Jason Lowe Assignee: Chang Li Attachments: YARN-2487.04.trunk.patch, yarn2847.patch, yarn2847.patch, yarn2847notest.patch The check_user function in container-executor.c can cause a segmentation fault if banned.users is not provided but the user is detected as one of the default users. In that scenario it will call free_values on a NULL pointer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (YARN-2847) Linux native container executor segfaults if default banned user detected
[ https://issues.apache.org/jira/browse/YARN-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olaf Flebbe updated YARN-2847: -- Attachment: YARN-2487.05.trunk.patch PATCH from YARN-3180 does not use uninitialized variable, please review Linux native container executor segfaults if default banned user detected - Key: YARN-2847 URL: https://issues.apache.org/jira/browse/YARN-2847 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Affects Versions: 2.5.0, 2.4.1, 2.6.0 Reporter: Jason Lowe Assignee: Chang Li Attachments: YARN-2487.04.trunk.patch, YARN-2487.05.trunk.patch, yarn2847.patch, yarn2847.patch, yarn2847notest.patch The check_user function in container-executor.c can cause a segmentation fault if banned.users is not provided but the user is detected as one of the default users. In that scenario it will call free_values on a NULL pointer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (YARN-3180) container-executor gets SEGV for default banned user
[ https://issues.apache.org/jira/browse/YARN-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olaf Flebbe resolved YARN-3180. --- Resolution: Duplicate container-executor gets SEGV for default banned user Key: YARN-3180 URL: https://issues.apache.org/jira/browse/YARN-3180 Project: Hadoop YARN Issue Type: Bug Affects Versions: 2.4.1, 2.6.1 Reporter: Olaf Flebbe Attachments: 0001-YARN-3180-container-executor-gets-SEGV-for-default-b.patch container-executor dumps core if container-executor.cfg * Does not contain a banned.users statement, getting the default in effect * The banned user id is above min.user.id * The user is contained in the default banned.user and yes this did happened to me. Patch and test appended (relativ to git trunk) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (YARN-2847) Linux native container executor segfaults if default banned user detected
[ https://issues.apache.org/jira/browse/YARN-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olaf Flebbe updated YARN-2847: -- Attachment: YARN-2487.04.trunk.patch Merged test from YARN-3810, cleaned up whitespace errors. Ready for review. Linux native container executor segfaults if default banned user detected - Key: YARN-2847 URL: https://issues.apache.org/jira/browse/YARN-2847 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Affects Versions: 2.5.0 Reporter: Jason Lowe Assignee: Chang Li Attachments: YARN-2487.04.trunk.patch, yarn2847.patch, yarn2847.patch, yarn2847notest.patch The check_user function in container-executor.c can cause a segmentation fault if banned.users is not provided but the user is detected as one of the default users. In that scenario it will call free_values on a NULL pointer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3180) container-executor gets SEGV for default banned user
[ https://issues.apache.org/jira/browse/YARN-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317142#comment-14317142 ] Olaf Flebbe commented on YARN-3180: --- Seems like it. The fix to the logic is the same. The test is different. I do test the exact environment, the other test does test much more than simply the check_user() call. The patch does not apply on git trunk. please apply either . container-executor gets SEGV for default banned user Key: YARN-3180 URL: https://issues.apache.org/jira/browse/YARN-3180 Project: Hadoop YARN Issue Type: Bug Affects Versions: 2.4.1, 2.6.1 Reporter: Olaf Flebbe Attachments: 0001-YARN-3180-container-executor-gets-SEGV-for-default-b.patch container-executor dumps core if container-executor.cfg * Does not contain a banned.users statement, getting the default in effect * The banned user id is above min.user.id * The user is contained in the default banned.user and yes this did happened to me. Patch and test appended (relativ to git trunk) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (YARN-3180) container-executor gets SEGV for default banned user
Olaf Flebbe created YARN-3180: - Summary: container-executor gets SEGV for default banned user Key: YARN-3180 URL: https://issues.apache.org/jira/browse/YARN-3180 Project: Hadoop YARN Issue Type: Bug Affects Versions: 2.4.1, 2.6.1 Reporter: Olaf Flebbe container-executor dumps core if container-executor.cfg * Does not contain a banned.users statement, getting the default in effect * The banned user id is above min.user.id * The user is contained in the default banned.user and yes this did happened to me. Patch and test appended (relativ to git trunk) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (YARN-3180) container-executor gets SEGV for default banned user
[ https://issues.apache.org/jira/browse/YARN-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olaf Flebbe updated YARN-3180: -- Attachment: 0001-YARN-3180-container-executor-gets-SEGV-for-default-b.patch The tests makes the assumption that bin is a valid user. The real problem was triggered for hdfs. If you do not apply the patch to container-executor.c test-container-executor dies. container-executor gets SEGV for default banned user Key: YARN-3180 URL: https://issues.apache.org/jira/browse/YARN-3180 Project: Hadoop YARN Issue Type: Bug Affects Versions: 2.4.1, 2.6.1 Reporter: Olaf Flebbe Attachments: 0001-YARN-3180-container-executor-gets-SEGV-for-default-b.patch container-executor dumps core if container-executor.cfg * Does not contain a banned.users statement, getting the default in effect * The banned user id is above min.user.id * The user is contained in the default banned.user and yes this did happened to me. Patch and test appended (relativ to git trunk) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
